Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Guidance search #3702

Merged

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Apr 20, 2020

Summary

Impacted areas of the application

List general components of the application that this PR will affect:

  • Guidance search page

Screenshots

Screen Shot 2020-04-21 at 12 16 35 PM

Screen Shot 2020-04-21 at 12 15 55 PM

Screen Shot 2020-04-21 at 12 13 37 PM

Screen Shot 2020-04-21 at 4 17 29 PM

Screen Shot 2020-04-22 at 9 19 27 AM

Screen Shot 2020-04-21 at 12 13 20 PM

How to test

  • Pull down this PR
  • export SEARCH_GOV_POLICY_GUIDANCE_KEY in your environment vars. You can grab this API access key by logging into search.gov and accessing the fec_content_s3 site.
  • Go to http://localhost:8000/legal-resources/policy-and-other-guidance/guidance-documents/ and make sure it loads
  • Try a search that includes best bets search like citizens united. The total count should add best bets and results count to give an accurate count

@patphongs patphongs changed the title [WIP] Changes to Guidance search Changes to Guidance search Apr 21, 2020
@patphongs patphongs changed the base branch from develop to release/public-20200428 April 21, 2020 21:02
fec/search/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rfultz rfultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML looks good!

@JonellaCulmer
Copy link
Contributor

@patphongs I believe we're supposed to remove the first paragraph in the footer and just leave the section that says "Note:..."

@patphongs
Copy link
Member Author

I believe we're supposed to remove the first paragraph in the footer and just leave the section that says "Note:..."

Thanks @JonellaCulmer, I have removed the first paragraph:

Screen Shot 2020-04-22 at 9 19 27 AM

@JonellaCulmer JonellaCulmer merged commit 3ae4aa8 into release/public-20200428 Apr 22, 2020
@lbeaufort lbeaufort deleted the feature/3671-guidance-search-edits branch April 23, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants