Fix/tooltip under alignment #1452
Conversation
…it will default to the most recent cycle with data, but it will get you to the current page and then you can manually change cycles
…committee-profile Display political party on committee profile page
|
@xtine in the second screenshot, we seem to have lost the pointy tip of the tooltip altogether, and in the first, it's in a reaaaaaly weird place inside the container. Here's an example of the shape from design files, though I if my memory is right, I think the point might have been adjusting it's location to what it was pointing at...can't remember.
Is this something we could address in this pass? I'm concerned that having the point inside the calendar tooltip looks unexpected and broken. |
|
@jenniferthibault: wow, okay I didn't realize that arrow was wrong (just an interesting design 😆) because I've never worked with the calendar tooltip before. Can you post what it should look like in here? And yeah some time even before merge the tooltip point was lost. I can definitely work on getting that back. I assume the point should just be below the (i) icon in the filter label? |
|
My memory isn't total garbage! It did used to move! I'm trying to hunt down what the design is for the tooltip in the calendar grid view, because the overlapping close X and the event title are off too. Hold plz while I dig some old issues up. |
|
@xtine via https://github.com/18F/FEC/issues/561 I found an old image of what the grid view tooltip is supposed to look like:
You're right about the point—it should be directly centered under the thing that initiates it opening, which is either the circular information icon, or the calendar event |
|
And here are additional Calendar tooltip PRs that I found while looking, in case they're helpful: |
Codecov Report
@@ Coverage Diff @@
## release/public-20171109 #1452 +/- ##
=======================================================
Coverage 79.4% 79.4%
=======================================================
Files 46 46
Lines 3297 3297
Branches 497 497
=======================================================
Hits 2618 2618
Misses 679 679Continue to review full report at Codecov.
|
|
@jenniferthibault: thanks for digging up the old PRs and calendar detail design, I found out that the override properties for calendar detail tooltip weren't showing up so I added specificity to match the designs. |
|
Also I've made sure that Saturday and Sunday event detail tooltips won't be hidden:
|
There was a problem hiding this comment.
THEY'RE SO BEAUTIFUL 😻
Thanks so much for patching these up, everything I'm seeing in your screenshots above looks right 👍
I'm still learning what thing best workflow is for our new pattern library environment, so would love your guidance. Since the tooltips in the pattern library are busted too, would we want to file a partner PR to fix that in the pattern library repo as part of the documentation step in a a PR like this? Or would it be a separate, non-dependent task entirely?
|
@jenniferthibault: I think we should make a non-dependent task. We need to migrate pattern library to circle and I still need to make a style asset migration script so those need to be done first of course. If those weren't issues I would be up for a documentation step but we are a bit behind already. |
|
Sounds good, I just made that a separate, non-dependent issue in the pattern library for fixing the busted tooltips based on the work that happened in this PR 👍 https://github.com/18F/fec-pattern-library/issues/20 |
This fix establishes override properties for the calendar detail tooltips so they are properly aligned on month-at-a-glance view. I also restored the top tooltip arrows so they show up now!
https://github.com/18F/fec-cms/issues/1274