Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display political party on committee profile page #1449

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Display political party on committee profile page #1449

merged 1 commit into from
Nov 6, 2017

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Nov 4, 2017

No description provided.

@pkfec pkfec self-assigned this Nov 4, 2017
@pkfec pkfec requested review from xtine and fec-jli November 4, 2017 02:50
@pkfec
Copy link
Contributor Author

pkfec commented Nov 4, 2017

  • fetch party_type variable from committee api.
  • add party_type variable to template_variables for committee.

@xtine and @fec-jli please review this change.
cc @PaulClark2 @jwchumley @hcaofec

fec-jli
fec-jli approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more attribute "party_full" to call back. It works

@xtine xtine merged commit 9098ee0 into develop Nov 6, 2017
@xtine xtine deleted the feature/display-political-party-on-committee-profile branch November 6, 2017 22:48
@PaulClark2 PaulClark2 mentioned this pull request Nov 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fec-jli fec-jli fec-jli approved these changes

@xtine xtine xtine approved these changes

Assignees

@pkfec pkfec

Labels
Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkfec @xtine @fec-jli