Skip to content
This repository has been archived by the owner on Dec 3, 2017. It is now read-only.

Tooltip adjustments #402

Merged
merged 4 commits into from
Jun 30, 2016
Merged

Tooltip adjustments #402

merged 4 commits into from
Jun 30, 2016

Conversation

noahmanger
Copy link
Contributor

@noahmanger noahmanger commented Jun 21, 2016

Summary

Adjusts the way that tooltips should be marked up in order for them to be positioned more consistently and for the point to always be under the question mark trigger (if present). Specifically, the .tooltip__container class should now wrap the .tooltip_trigger and .tooltip only, not the text associated with the trigger as it previously was.

Along these lines, I replaced the CSS-generated arrow with an SVG, as in order to get the border effect on the CSS arrow we essentially had to overlap a blue and white triangle. For whatever reason, they would often be misaligned in some places but not others, and the simplest solution was to just make a static asset.

This also contains some minor spacing adjustments to the calendar list view.

Noah Manger added 3 commits June 20, 2016 16:58
- Now using an svg for the arrow instead of CSS because the CSS
generated arrow was too hard to get just right
@codecov-io
Copy link

codecov-io commented Jun 29, 2016

Current coverage is 62.72%

Merging #402 into master will increase coverage by 1.08%

@@             master       #402   diff @@
==========================================
  Files            20         20          
  Lines          1254       1312    +58   
  Methods         211        231    +20   
  Messages          0          0          
  Branches        220        234    +14   
==========================================
+ Hits            773        823    +50   
- Misses          481        489     +8   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by a6d46a8...66611fe

@noahmanger
Copy link
Contributor Author

cc @adborden on this. Are you using tooltips at all on legal stuff? If so, this introduces a semi-breaking change.

@adborden
Copy link
Contributor

No, not using tooltips explicitly, although they might appear in some of the FEC components we're using.. (but I can't think of any).

@adborden adborden merged commit 8ba40be into master Jun 30, 2016
@LindsayYoung LindsayYoung deleted the tooltip-adjustments branch April 3, 2017 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants