Adds tooltip content to calendar events #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The content looks great here. We'll have to take out the definition for EC and IE periods— we're still working on building support for these. :( But everything else can get implemented and launched. |
|
We're not planning on including this in this week's release, and I think that's fine. |
|
Sounds good. Just wanted to make sure we don't accidentally release it later. I'll keep trucking on this :) |
added 5 commits
June 28, 2016 18:00
cc @emileighoutlaw : for technical reasons, I converted these to paragraphs. Is that ok?
Current coverage is 89.02% (diff: 69.23%)@@ develop #361 diff @@
==========================================
Files 4 4
Lines 224 237 +13
Methods 38 40 +2
Messages 0 0
Branches 34 39 +5
==========================================
+ Hits 202 211 +9
- Misses 22 26 +4
Partials 0 0
|
|
I added in the reporting tooltip. I believe this PR is ready for a merge (Although I'll wait for Noah to get back and add the Resolves: https://github.com/18F/fec-cms/issues/337 |
|
This looks good, thanks @noahmanger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for category tooltips in list view.
Requires 18F/fec-style#402
Resolves https://github.com/18F/fec-cms/issues/337