Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement raising/spending breakdown charts back into production #2200

Closed
4 tasks done
JonellaCulmer opened this issue Jul 19, 2018 · 7 comments
Closed
4 tasks done

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Jul 19, 2018

What we're after: Following the takedown and critical updates made to improve our raising/spending breakdown bar charts, and as part of the reimplementation work for the raising/spending line charts here (#2199), we need to now reimplement them back into production.

The URL can stay the same but we need to acknowledge that it will now be moved from where it previously lived.

Completion criteria:

  • Meet to discuss the re-implementation of this bar chart
  • Talk to content about a logical URL and page name now that we've removed the word, "Breakdown" from the button on line charts
  • Reimplement the breakdown charts for the raising and spending information in both places where the line charts now exist: data landing page, advanced data: raising, advanced data: spending
  • Change some terms and labels based on talks with content.
@llienfec
Copy link
Contributor

Suggestions are with Content Team. We should have an answer for you soon.

@llienfec
Copy link
Contributor

Big thanks to the Content Team for going through so many name suggestions! It was a struggle to find something descriptive, correct and plain language. Our winner is: "Raising: by the numbers" as the page title/URL with a similar change for spending.

cc: @JonellaCulmer

@AmyKort
Copy link

AmyKort commented Sep 20, 2018

Thanks @llienfec for doing all of the heavy lifting on this!

@patphongs
Copy link
Member

Thanks @llienfec! As you're reviewing the change @JonellaCulmer we've also got some file names that need to change, they are currently called

  • breakdowns.jinja
  • breakdowns.js
  • raising-breakdown.jinja
  • spending-breakdown.jinja

@JonellaCulmer
Copy link
Contributor Author

@llienfec Great! Just to clarify, the URL would be: /data/raising-by-the-numbers and /data/spending-by-the-numbers.

@patphongs How about the following?

  • bythenumbers.jinja
  • bythenumbers.js
  • raising-bythenumbers.jinja
  • spending-bythenumbers.jinja

@llienfec
Copy link
Contributor

Yep, that URL works great. Thanks!

@patphongs
Copy link
Member

Changes have been made to file names and paths to use the bythenumbers syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants