Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the data for the /totals/pac-party/ (/totals/{committee_type}/) endpoint #4873

Closed
2 tasks done
rfultz opened this issue Jun 2, 2021 · 1 comment
Closed
2 tasks done
Assignees
Milestone

Comments

@rfultz
Copy link
Contributor

rfultz commented Jun 2, 2021

What we’re after

If we're going to build a feature using an endpoint that hasn't been on fec.gov before, we should take some time to look for major data issues before the feature goes live. The totals on /totals/pac-party/ should match the totals on the committee profile page, which come from /committee/<committee_id>/totals/. We could spot-check the data or write a script similar to https://github.com/lbeaufort/scripts/blob/master/compare_candidate_totals.py.

Optionally we could also research why we pulled PACs from the raising by the numbers page - what data issues existed?

Completion criteria

(What does the end state look like - as long as this task(s) is done, this work is complete)

  • Check to make sure the totals in /totals/pac-party/ match the totals on /committee/<committee_id>/totals/
  • Enter any follow-up issues

References/resources/technical considerations

Candidate totals checking script: https://github.com/lbeaufort/scripts/blob/master/compare_candidate_totals.py.

@rfultz rfultz added this to the Sprint 15.1 milestone Jun 2, 2021
@lbeaufort lbeaufort changed the title Test the data for /totals/pac-party/ Test the data for the /totals/pac-party/ endpoint Jun 4, 2021
@lbeaufort lbeaufort changed the title Test the data for the /totals/pac-party/ endpoint Test the data for the /totals/pac-party/ (/totals/{committee_type}/) endpoint Jun 4, 2021
@lbeaufort lbeaufort self-assigned this Jun 4, 2021
@lbeaufort
Copy link
Member

Thank you to @hcaofec for pointing out that these two endpoints have the same underlying materialized view and very similar logic. I took some of the top raising PACs and spot-checked the totals (google doc here: https://docs.google.com/spreadsheets/d/1wJGI579Og-yYuZZTTWmIOnEMHAgAapPnh12XolyCDNo/edit#gid=0) but I think the data looks good to use. We should re-check after we make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants