-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement raising and spending bar charts #2365
Conversation
…age and data landing page - Activated more raising buttons on line charts
Codecov Report
@@ Coverage Diff @@
## develop #2365 +/- ##
========================================
Coverage 74.26% 74.26%
========================================
Files 111 111
Lines 6628 6628
Branches 589 589
========================================
Hits 4922 4922
Misses 1706 1706
Continue to review full report at Codecov.
|
@patphongs Is this issue still waiting on something, or is it ready for review? |
@JonellaCulmer Just need to implement the rest of the name changes as documented here: #2200 (comment) and it should be ready for review |
@JonellaCulmer Changes to the naming convention have been made. Please review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @patphongs Thank you!
Summary
We needed to reimplement the raising and spending bar charts. This PR reactivates the links to those features
Impacted areas of the application
List general components of the application that this PR will affect: