Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement raising and spending bar charts #2365

Merged
merged 4 commits into from
Sep 28, 2018

Conversation

patphongs
Copy link
Member

Summary

Impacted areas of the application

List general components of the application that this PR will affect:

  • Data landing page
  • Advanced raising tab
  • Advanced spending tab

…age and data landing page

- Activated more raising buttons on line charts
@patphongs patphongs changed the title Reimplement raising and spending bar charts [WIP] Reimplement raising and spending bar charts Sep 14, 2018
@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #2365 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2365   +/-   ##
========================================
  Coverage    74.26%   74.26%           
========================================
  Files          111      111           
  Lines         6628     6628           
  Branches       589      589           
========================================
  Hits          4922     4922           
  Misses        1706     1706
Impacted Files Coverage Δ
fec/data/urls.py 100% <ø> (ø) ⬆️
fec/data/views.py 37.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8342ff6...9710b4d. Read the comment docs.

@JonellaCulmer
Copy link
Contributor

@patphongs Is this issue still waiting on something, or is it ready for review?

@patphongs
Copy link
Member Author

@JonellaCulmer Just need to implement the rest of the name changes as documented here: #2200 (comment) and it should be ready for review

@patphongs patphongs changed the title [WIP] Reimplement raising and spending bar charts Reimplement raising and spending bar charts Sep 28, 2018
@patphongs patphongs requested a review from apburnes September 28, 2018 17:50
@patphongs
Copy link
Member Author

@JonellaCulmer Changes to the naming convention have been made. Please review, thanks!

Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @patphongs Thank you!

@JonellaCulmer JonellaCulmer merged commit 3f3f78d into develop Sep 28, 2018
@lbeaufort lbeaufort deleted the feature/2200-reimplement-bar-charts branch October 2, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants