Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Reimplement raising/spending line charts back into production #2199

Closed
3 tasks done
Tracked by #140
JonellaCulmer opened this issue Jul 19, 2018 · 6 comments
Closed
3 tasks done
Tracked by #140

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented Jul 19, 2018

What we're after: Following taking down and making critical updates to our raising and spending line charts, we need to reimplement them back into production.

Some considerations:
As part of the data fix here (fecgov/openFEC#3240), there were some slight name changes to parameters that must be considered as part of this reimplementation.

Also, recent usability testing suggested that users were not going to the bottom of the campaign finance data landing page and subsequently are not seeing the raising and spending charts. As part of this ticket, we should consider placing the raising and spending charts on the applicable advanced data pages where we know our users frequent.

Completion criteria:

  • Review and address parameters with name changes
  • Mock-up alternative solution for displaying raising and spending line charts on advanced data pages
  • Discuss solution in design sync
@patphongs patphongs changed the title Reimplement raising/spending line charts back into production Design: Reimplement raising/spending line charts back into production Jul 30, 2018
@JonellaCulmer
Copy link
Contributor Author

JonellaCulmer commented Aug 13, 2018

During design sync 8/10, we discussed the reimplementation of the cumulative raising/spending line charts. Part of that reimplementation, we discussed moving the line charts to the advanced data pages.

From our user testing, we identified that very few of our users would think to look at the bottom of our data landing page for these high-level charts. Most were inclined to look on the advanced data pages for high-level birds-eye-view data. The mock-ups below address that change and incorporate the reaction box, to get an idea of user sentiment regarding the charts.

Additionally, we may want to consider re-implementing the charts on the data landing page, along with the reaction box. If we're able to track which reaction charts receive feedback, we may be able to learn even more about how our users are using/seeing the charts on the different pages.

Designs:
screen shot 2018-08-15 at 10 20 59 am
screen shot 2018-08-15 at 10 21 34 am

Next steps:

  • Confirm shift of line charts to advanced data pages and possibly back on the data landing page @AmyKort @PaulClark2 @jwchumley @patphongs
  • Identify whether the reaction chart is something trackable(?)/comparable on different pages
  • Make any necessary updates
  • Move to an implementation issue
  • Create a testing issue for followup.

@JonellaCulmer JonellaCulmer added this to the Sprint 6.6 milestone Aug 16, 2018
@JonellaCulmer
Copy link
Contributor Author

We had a productive conversation about the addition of the raising and spending line charts on their respective advanced data pages. Additionally, we intend to reimplement the charts back onto the data landing page. The charts, coupled with a reaction box, will allow us to get feedback on which table placement works better for our users.

Based on that design sync comments, I have updated the mockups. There are also some unanswered questions that will be added to a followup content issue, specifically for the "Raising breakdown" and "Advanced data" language.

Updatd designs:
screen shot 2018-08-17 at 3 49 25 pm
screen shot 2018-08-17 at 3 49 59 pm

@JonellaCulmer
Copy link
Contributor Author

@apburnes As part of your ongoing PR, are you able to take a look at the first item on the checklist in the original comment? Below:

Some considerations:
As part of the data fix here (fecgov/openFEC#3240), there were some slight name changes to parameters that must be considered as part of this reimplementation.

@apburnes
Copy link
Contributor

Will take a look.

@apburnes
Copy link
Contributor

The endpoint was updated and the chart is using the updated API endpoint. Nothing to do.

@patphongs
Copy link
Member

Design is finished and another issue for the line charts is outstanding coupled with a PR #2276 to reimplement. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants