fix: Prefer installing gopy from feast's fork as opposed to upstream #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2839 +/- ##
==========================================
+ Coverage 79.64% 80.14% +0.50%
==========================================
Files 174 175 +1
Lines 15534 16125 +591
==========================================
+ Hits 12372 12924 +552
- Misses 3162 3201 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kevjumba
reviewed
Jun 22, 2022
adchia
reviewed
Jun 22, 2022
| @@ -2,6 +2,8 @@ module github.com/feast-dev/feast | |||
|
|
|||
| go 1.17 | |||
|
|
|||
| replace github.com/go-python/gopy v0.4.0 => github.com/feast-dev/gopy v0.4.1-0.20220429180328-4257ac71a4d0 | |||
There was a problem hiding this comment.
was the main change to pin it at v0.40.0? was the re-ordering of “replace” needed in go.mod?
There was a problem hiding this comment.
Pinning to v0.4.0 in makefile totally makes sense, since 0.4.0 is not latest version anymore. But this move probably changes nothing.
There was a problem hiding this comment.
@pyalex is right, the line change has no effect.
There was a problem hiding this comment.
Pinning was the first main change. The other main change was in setup.py to pass in the go env to go commands. Without that, the go subprocess would behave unexpectedly since the go config would be different since the process environment isn't inherited by default.
Signed-off-by: Achal Shah <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@achals Is this the long term solution or are we planning to move back to upstream gopy? Is there some fundamental reason to use a fork? |
|
@judahrand I would love to upstream these changes and not maintain a fork. @pyalex do you think this is feasible? |
kevjumba
pushed a commit
that referenced
this pull request
Jun 23, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-23) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5))
kevjumba
pushed a commit
that referenced
this pull request
Jun 24, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-24) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5))
felixwang9817
pushed a commit
that referenced
this pull request
Jun 24, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-24) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Correctly generate projects-list.json when calling feast ui and using postgres as a source ([#2845](#2845)) ([bee8076](bee8076)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add feast repo-upgrade for automated repo upgrades ([#2733](#2733)) ([a3304d4](a3304d4)) * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5))
felixwang9817
pushed a commit
that referenced
this pull request
Jun 25, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-25) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Correctly generate projects-list.json when calling feast ui and using postgres as a source ([#2845](#2845)) ([bee8076](bee8076)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add feast repo-upgrade for automated repo upgrades ([#2733](#2733)) ([a3304d4](a3304d4)) * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5))
kevjumba
pushed a commit
that referenced
this pull request
Jun 28, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-28) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Correctly generate projects-list.json when calling feast ui and using postgres as a source ([#2845](#2845)) ([bee8076](bee8076)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Go install gopy instead using go mod tidy ([#2863](#2863)) ([2f2b519](2f2b519)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add feast repo-upgrade for automated repo upgrades ([#2733](#2733)) ([a3304d4](a3304d4)) * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5)) ### Reverts * Revert "Create main.yml" (#2867) ([47922a4](47922a4)), closes [#2867](#2867)
kevjumba
pushed a commit
that referenced
this pull request
Jun 28, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-28) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Correctly generate projects-list.json when calling feast ui and using postgres as a source ([#2845](#2845)) ([bee8076](bee8076)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fix workflow syntax error ([#2869](#2869)) ([fae45a1](fae45a1)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Go install gopy instead using go mod tidy ([#2863](#2863)) ([2f2b519](2f2b519)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Sync publish and build_wheels workflow to fix verify wheel error. ([#2871](#2871)) ([b0f050a](b0f050a)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add feast repo-upgrade for automated repo upgrades ([#2733](#2733)) ([a3304d4](a3304d4)) * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5)) ### Reverts * Revert "chore(release): release 0.22.0" (#2870) ([ffb0892](ffb0892)), closes [#2870](#2870) * Revert "Create main.yml" (#2867) ([47922a4](47922a4)), closes [#2867](#2867)
kevjumba
pushed a commit
that referenced
this pull request
Jun 29, 2022
# [0.22.0](v0.21.0...v0.22.0) (2022-06-29) ### Bug Fixes * Add columns for user metadata in the tables ([#2760](#2760)) ([269055e](269055e)) * Add project columns in the SQL Registry ([#2784](#2784)) ([336fdd1](336fdd1)) * Add S3FS dependency (which Dask depends on for S3 files) ([#2701](#2701)) ([5d6fa94](5d6fa94)) * Bugfixes for how registry is loaded ([#2768](#2768)) ([ecb8b2a](ecb8b2a)) * Conversion of null timestamp from proto to python ([#2814](#2814)) ([cb23648](cb23648)) * Correct feature statuses during feature logging test ([#2709](#2709)) ([cebf609](cebf609)) * Correctly generate projects-list.json when calling feast ui and using postgres as a source ([#2845](#2845)) ([bee8076](bee8076)) * Dynamodb drops missing entities when batching ([#2802](#2802)) ([a2e9209](a2e9209)) * Enable faulthandler and disable flaky tests ([#2815](#2815)) ([4934d84](4934d84)) * Explicitly translate errors when instantiating the go fs ([#2842](#2842)) ([7a2c4cd](7a2c4cd)) * Fix broken roadmap links ([#2690](#2690)) ([b3ba8aa](b3ba8aa)) * Fix bugs in applying stream feature view and retrieving online features ([#2754](#2754)) ([d024e5e](d024e5e)) * Fix Feast UI failure with new way of specifying entities ([#2773](#2773)) ([0d1ac01](0d1ac01)) * Fix feature view __getitem__ for feature services ([#2769](#2769)) ([88cc47d](88cc47d)) * Fix issue when user specifies a port for feast ui ([#2692](#2692)) ([1c621fe](1c621fe)) * Fix macos wheel version for 310 and also checkout edited go files ([#2890](#2890)) ([bdf170f](bdf170f)) * Fix on demand feature view crash from inference when it uses df.apply ([#2713](#2713)) ([c5539fd](c5539fd)) * Fix SparkKafkaProcessor `query_timeout` parameter ([#2789](#2789)) ([a8d282d](a8d282d)) * Fix workflow syntax error ([#2869](#2869)) ([fae45a1](fae45a1)) * Fixed custom S3 endpoint read fail ([#2786](#2786)) ([6fec431](6fec431)) * Go install gopy instead using go mod tidy ([#2863](#2863)) ([2f2b519](2f2b519)) * Hydrate infra object in the sql registry proto() method ([#2782](#2782)) ([452dcd3](452dcd3)) * Implement apply_materialization and infra methods in sql registry ([#2775](#2775)) ([4ed107c](4ed107c)) * Minor refactor to format exception message ([#2764](#2764)) ([da763c6](da763c6)) * Prefer installing gopy from feast's fork as opposed to upstream ([#2839](#2839)) ([34c997d](34c997d)) * Python server is not correctly starting in integration tests ([#2706](#2706)) ([7583a0b](7583a0b)) * Random port allocation for python server in tests ([#2710](#2710)) ([dee8090](dee8090)) * Refactor test to reuse LocalRegistryFile ([#2763](#2763)) ([4339c0a](4339c0a)) * Revert "chore(release): release 0.22.0" ([#2852](#2852)) ([e6a4636](e6a4636)) * Stop running go mod tidy in setup.py ([#2877](#2877)) ([676ecbb](676ecbb)), closes [/github.com/pypa/cibuildwheel/issues/189#issuecomment-549933912](https://github.com//github.com/pypa/cibuildwheel/issues/189/issues/issuecomment-549933912) * Support push sources in stream feature views ([#2704](#2704)) ([0d60eaa](0d60eaa)) * Sync publish and build_wheels workflow to fix verify wheel error. ([#2871](#2871)) ([b0f050a](b0f050a)) * Update roadmap with stream feature view rfc ([#2824](#2824)) ([fc8f890](fc8f890)) * Update udf tests and add base functions to streaming fcos and fix some nonetype errors ([#2776](#2776)) ([331a214](331a214)) ### Features * Add feast repo-upgrade for automated repo upgrades ([#2733](#2733)) ([a3304d4](a3304d4)) * Add file write_to_offline_store functionality ([#2808](#2808)) ([c0e2ad7](c0e2ad7)) * Add http endpoint to the Go feature server ([#2658](#2658)) ([3347a57](3347a57)) * Add simple TLS support in Go RedisOnlineStore ([#2860](#2860)) ([521488d](521488d)) * Add StreamProcessor and SparkKafkaProcessor as contrib ([#2777](#2777)) ([83ab682](83ab682)) * Added Spark support for Delta and Avro ([#2757](#2757)) ([7d16516](7d16516)) * CLI interface for validation of logged features ([#2718](#2718)) ([c8b11b3](c8b11b3)) * Enable stream feature view materialization ([#2798](#2798)) ([a06700d](a06700d)) * Enable stream feature view materialization ([#2807](#2807)) ([7d57724](7d57724)) * Implement `offline_write_batch` for BigQuery and Snowflake ([#2840](#2840)) ([97444e4](97444e4)) * Offline push endpoint for pushing to offline stores ([#2837](#2837)) ([a88cd30](a88cd30)) * Push to Redshift batch source offline store directly ([#2819](#2819)) ([5748a8b](5748a8b)) * Scaffold for unified push api ([#2796](#2796)) ([1bd0930](1bd0930)) * SQLAlchemy Registry Support ([#2734](#2734)) ([b3fe39c](b3fe39c)) * Stream Feature View FCOS ([#2750](#2750)) ([0cf3c92](0cf3c92)) * Update stream fcos to have watermark and sliding interval ([#2765](#2765)) ([3256952](3256952)) * Validating logged features via Python SDK ([#2640](#2640)) ([2874fc5](2874fc5)) ### Reverts * Revert "chore(release): release 0.22.0" (#2891) ([e5abf58](e5abf58)), closes [#2891](#2891) * Revert "chore(release): release 0.22.0" (#2870) ([ffb0892](ffb0892)), closes [#2870](#2870) * Revert "Create main.yml" (#2867) ([47922a4](47922a4)), closes [#2867](#2867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
In
go.mod, we're replacinggo-python/gopywithfeast-dev/gopy, but for whatever reason we don't do the same thing insetup.pyorMakefile. This results in us using a different version of gopy from the one that will actually work (i.e. our fork).This was made worse by the face the the upstream repo landed a bunch of commits and the new version of that project totally borked our build process.
I think this should fix the release pipeline (https://github.com/feast-dev/feast/runs/6993658741?check_suite_focus=true) as well as the flaky test (#2830)
Which issue(s) this PR fixes:
Fixes #