Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable final go server test #2830

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #2830 (58a4d10) into master (7d344b7) will decrease coverage by 2.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   59.63%   57.29%   -2.35%     
==========================================
  Files         174      150      -24     
  Lines       15493    13192    -2301     
==========================================
- Hits         9239     7558    -1681     
+ Misses       6254     5634     -620     
Flag Coverage Δ
unittests 57.29% <ø> (-2.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/tests/integration/e2e/test_go_feature_server.py 32.83% <ø> (-0.50%) ⬇️
sdk/python/tests/utils/cli_utils.py 39.53% <0.00%> (-58.14%) ⬇️
sdk/python/feast/infra/registry_stores/sql.py 34.61% <0.00%> (-35.00%) ⬇️
sdk/python/feast/on_demand_feature_view.py 41.50% <0.00%> (-32.84%) ⬇️
sdk/python/feast/feature_view_projection.py 67.64% <0.00%> (-23.53%) ⬇️
sdk/python/feast/feature.py 46.34% <0.00%> (-21.96%) ⬇️
sdk/python/feast/feature_service.py 73.52% <0.00%> (-11.77%) ⬇️
sdk/python/feast/repo_config.py 68.44% <0.00%> (-11.56%) ⬇️
sdk/python/feast/repo_operations.py 41.42% <0.00%> (-11.43%) ⬇️
...stores/contrib/spark_offline_store/spark_source.py 50.35% <0.00%> (-10.80%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d344b7...58a4d10. Read the comment docs.

@felixwang9817 felixwang9817 changed the title ci: Delete most integration tests ci: Delete all integration tests except registration Jun 22, 2022
@felixwang9817 felixwang9817 changed the title ci: Delete all integration tests except registration ci: Delete all integration tests except registration [WIP] Jun 22, 2022
@felixwang9817 felixwang9817 marked this pull request as draft June 22, 2022 02:40
@felixwang9817 felixwang9817 changed the title ci: Delete all integration tests except registration [WIP] ci: Check if registration integration tests pass [WIP] Jun 22, 2022
@felixwang9817 felixwang9817 changed the title ci: Check if registration integration tests pass [WIP] ci: Check if registration and online store integration tests pass [WIP] Jun 22, 2022
@felixwang9817 felixwang9817 changed the title ci: Check if registration and online store integration tests pass [WIP] ci: Check if registration and online store and offline store integration tests pass [WIP] Jun 22, 2022
@felixwang9817 felixwang9817 changed the title ci: Check if registration and online store and offline store integration tests pass [WIP] ci: Check e2e integration tests pass [WIP] Jun 22, 2022
@felixwang9817 felixwang9817 changed the title ci: Check e2e integration tests pass [WIP] ci: Disable final go server test Jun 22, 2022
@felixwang9817 felixwang9817 marked this pull request as ready for review June 22, 2022 17:24
Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants