fix: Go install gopy instead using go mod tidy (#2863)

* fix: Go install gopy instead using go mod tidy Signed-off-by: Achal Shah <[email protected]> * remove newline Signed-off-by: Achal Shah <[email protected]> * fix Signed-off-by: Achal Shah <[email protected]> * fix Signed-off-by: Achal Shah <[email protected]>
feast-dev · Jun 27, 2022 · 2f2b519 · 2f2b519
1 parent 412d249
commit 2f2b519
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/sdk/python/tests/integration/feature_repos/integration_test_repo_config.py b/sdk/python/tests/integration/feature_repos/integration_test_repo_config.py
@@ -51,8 +51,8 @@ def __repr__(self) -> str:
                 f"{self.provider.upper()}",
                 f"{self.offline_store_creator.__name__.split('.')[-1].replace('DataSourceCreator', '')}",
                 online_store_type,
-                f"python_fs={self.python_feature_server}",
-                f"go_fs={self.go_feature_retrieval}",
+                f"python_fs:{self.python_feature_server}",
+                f"go_fs:{self.go_feature_retrieval}",
             ]
         )
 

diff --git a/setup.py b/setup.py
@@ -424,8 +424,18 @@ def build_extension(self, ext: Extension):
             subprocess.check_output(["go", "env", "-json"]).decode("utf-8").strip()
         )
 
+        print(f"Go env: {go_env}")
+        print(f"CWD: {os.getcwd()}")
+
         destination = os.path.dirname(os.path.abspath(self.get_ext_fullpath(ext.name)))
-        subprocess.check_call(["go", "mod", "tidy"], env={"PATH": bin_path, **go_env})
+        subprocess.check_call(["go", "install", "golang.org/x/tools/cmd/goimports"],
+                              env={"PATH": bin_path, **go_env})
+        subprocess.check_call(["go", "get", "github.com/go-python/[email protected]"],
+                              env={"PATH": bin_path, **go_env})
+        subprocess.check_call(["go", "install", "github.com/go-python/gopy"],
+                              env={"PATH": bin_path, **go_env})
+        subprocess.check_call(["go", "mod", "tidy"],
+                              env={"PATH": bin_path, **go_env})
         subprocess.check_call(
             [
                 "gopy",