Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renable tests after fixing gopy installation issue that was blocking tests. #2841

Closed
wants to merge 2 commits into from

Conversation

kevjumba
Copy link
Collaborator

@kevjumba kevjumba commented Jun 23, 2022

Signed-off-by: Kevin Zhang [email protected]

What this PR does / why we need it:
Undoes part of #2815 and does so because of #2839.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Kevin Zhang <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2841 (ae70387) into master (a88cd30) will decrease coverage by 20.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #2841       +/-   ##
===========================================
- Coverage   79.68%   59.42%   -20.26%     
===========================================
  Files         175      175               
  Lines       15572    15618       +46     
===========================================
- Hits        12408     9281     -3127     
- Misses       3164     6337     +3173     
Flag Coverage Δ
integrationtests ?
unittests 59.42% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/tests/integration/e2e/test_go_feature_server.py 34.30% <100.00%> (-8.24%) ⬇️
.../integration/online_store/test_universal_online.py 17.82% <100.00%> (-73.37%) ⬇️
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
...ts/integration/offline_store/test_offline_write.py 28.16% <0.00%> (-71.84%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a88cd30...ae70387. Read the comment docs.

@achals
Copy link
Member

achals commented Jun 23, 2022

We should be using pytest.mark.skip instead of commenting out tests, totally my bad for not doing that.

Also, can you update the PR title and description to provide more context? And link to the previous PR?

@achals achals changed the title fix: Renable tests after flake fix: Renable tests after fixing gopy installation issue Jun 23, 2022
@kevjumba kevjumba changed the title fix: Renable tests after fixing gopy installation issue fix: Renable tests after fixing gopy installation issue that was blocking tests. Jun 23, 2022
Signed-off-by: Kevin Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants