Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update driver configurations (2021-06-02) #417

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

leodido
Copy link
Member

@leodido leodido commented Jun 2, 2021

Prebuilt drivers update

@maxgio92
Copy link
Member

maxgio92 commented Jun 3, 2021

/retest

@maxgio92
Copy link
Member

maxgio92 commented Jun 3, 2021

/approve

@poiana poiana added the approved label Jun 3, 2021
maxgio92
maxgio92 previously approved these changes Jun 3, 2021
@poiana
Copy link
Contributor

poiana commented Jun 3, 2021

LGTM label has been added.

Git tree hash: fd7d392e59230de8cd86079d8d43caa237b3eb69

@maxgio92
Copy link
Member

maxgio92 commented Jun 3, 2021

As for the chat, #414 should unblock ci/circleci: scan/terraform job from failing as some scanning checks are now blocking.

@maxgio92
Copy link
Member

maxgio92 commented Jun 3, 2021

Waiting now #418 thanks to @jonahjon

@maxgio92
Copy link
Member

maxgio92 commented Jun 4, 2021

/retest

@maxgio92
Copy link
Member

maxgio92 commented Jun 4, 2021

Rebased @leodido as we said on master as new fixes have been pushed in the meantime

@jonahjon
Copy link
Contributor

jonahjon commented Jun 7, 2021

/approve

@jonahjon
Copy link
Contributor

jonahjon commented Jun 7, 2021

/lgtm

@poiana
Copy link
Contributor

poiana commented Jun 7, 2021

LGTM label has been added.

Git tree hash: 3b5dddf090900276971add35f87fc06b647454da

@leodido
Copy link
Member Author

leodido commented Jun 7, 2021 via email

@leodido
Copy link
Member Author

leodido commented Jun 8, 2021

Hmmm, wondering why "build-drivers-ubuntu-aws-presubmit" job fails while its logs say "DBG build complete" ...

@maxgio92
Copy link
Member

maxgio92 commented Jun 8, 2021

hey @leodido, this is due to the fact that the #410 version of build-drivers that still had a bug has been published before approval.
In detail Make I doesn't exit with 0 I think, and the published one exits with the Make target exit code.
This bug has been fixed yesterday night and (erroneously) published, so the drivers-build jobs should now work.

Instead, about the fact that the CI image has been published before approval, I opened #421 and PR #422 to fix it.

so a /retest should enable to pass them
/retest

@maxgio92
Copy link
Member

maxgio92 commented Jun 8, 2021

/retest

@maxgio92 maxgio92 mentioned this pull request Jun 8, 2021
15 tasks
@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/retest

@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/test build-drivers-ubuntu-aws-presubmit

@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/test build-drivers-ubuntu-generic-presubmit

@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/retest

@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/test build-drivers-ubuntu-aws-3-presubmit

@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

/retest

@poiana poiana removed the lgtm label Jun 8, 2021
@jonahjon
Copy link
Contributor

jonahjon commented Jun 8, 2021

If these pass, will go fix merge conflicts on other driver PR's

leogr
leogr previously approved these changes Jun 9, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 9, 2021
@poiana
Copy link
Contributor

poiana commented Jun 9, 2021

LGTM label has been added.

Git tree hash: c69b5f4027a6cd3cc355ae11587c69e175e8a2d6

@leogr
Copy link
Member

leogr commented Jun 9, 2021

/hold
rebase needed

@leogr leogr mentioned this pull request Jun 9, 2021
@leogr
Copy link
Member

leogr commented Jun 10, 2021

/hold cancel

@poiana
Copy link
Contributor

poiana commented Jun 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonahjon, leodido, leogr, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonahjon,leodido,leogr,maxgio92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a5e508d into master Jun 10, 2021
@poiana poiana deleted the update/drivers-2021-06-02 branch June 10, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants