-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update driver configurations (2021-06-02) #417
Conversation
/retest |
/approve |
LGTM label has been added. Git tree hash: fd7d392e59230de8cd86079d8d43caa237b3eb69
|
As for the chat, #414 should unblock |
/retest |
62b8ad0
to
03866a4
Compare
Rebased @leodido as we said on master as new fixes have been pushed in the meantime |
/approve |
/lgtm |
LGTM label has been added. Git tree hash: 3b5dddf090900276971add35f87fc06b647454da
|
/test build-drivers-amazonlinux2-presubmit
On Mon, 7 Jun 2021 at 19:52 poiana ***@***.***> wrote:
@leodido <https://github.com/leodido>: The following test *failed*, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
build-drivers-amazonlinux2-presubmit 03866a4
<03866a4>
link
<http://prow.falco.org/view/s3/falco-prow-logs/pr-logs/pull/falcosecurity_test-infra/417/build-drivers-amazonlinux2-presubmit/1401926989153046528> /test
build-drivers-amazonlinux2-presubmit
Full PR test history
<http://prow.falco.org/pr-history?org=falcosecurity&repo=test-infra&pr=417>.
Please help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/falcosecurity/test-infra/issues?q=is:issue+is:open>
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#417 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5J42KIUC65PAP2D6ZF5DTRUBO3ANCNFSM455YX5JQ>
.
--
L.
|
Hmmm, wondering why "build-drivers-ubuntu-aws-presubmit" job fails while its logs say "DBG build complete" ... |
hey @leodido, this is due to the fact that the #410 version of Instead, about the fact that the CI image has been published before approval, I opened #421 and PR #422 to fix it. so a /retest should enable to pass them |
/retest |
/retest |
/test build-drivers-ubuntu-aws-presubmit |
/test build-drivers-ubuntu-generic-presubmit |
/retest |
/test build-drivers-ubuntu-aws-3-presubmit |
/retest |
If these pass, will go fix merge conflicts on other driver PR's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: c69b5f4027a6cd3cc355ae11587c69e175e8a2d6
|
/hold |
Signed-off-by: Leonardo Di Donato <[email protected]>
b86f806
to
d12b081
Compare
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonahjon, leodido, leogr, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prebuilt drivers update