Upgrade EKS Terraform module to v17.0.3 without disruption #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maxgio92 <[email protected]>
…isruption Signed-off-by: maxgio92 <[email protected]>
Signed-off-by: maxgio92 <[email protected]>
Signed-off-by: maxgio92 <[email protected]>
jonahjon
approved these changes
Jun 3, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonahjon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 2bb0a352c709a1dcd86a4cb9130223541e635852
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades and locks the EKS Terraform module to v17.0.3 version without introducing disruption (see commit about the
name_prefixintroduction for Node Groups which causes to re-create the resources).Furthermore, this PR adds two skip on infra scanning check, as I think they have a pretty low priority now. We can then improve there.