Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split drivers build jobs #410

Merged
merged 7 commits into from
Jun 8, 2021
Merged

Split drivers build jobs #410

merged 7 commits into from
Jun 8, 2021

Conversation

maxgio92
Copy link
Member

@maxgio92 maxgio92 commented May 26, 2021

This PR aims to starting implement what is proposed in FR #406.

  • First, the build-drivers image script now accepts a optional and positional arguments as pattern string to also:
    • filter by kernel version (as expected by DBG specific_target Make target)
    • filter by driver version
  • Driver build jobs for ubuntu-generic and ubuntu-aws distro variants are split into jobs for kernel version 3, 4 and 5
  • Furthermore, the build-drivers.sh script has been refactored, so that we can also call it like that (from the root of this repo):
PUBLISH_S3=false ENSURE_DOCKER=false DBG_WORKDIR=$PWD/driverkit \
./images/build-drivers/build-drivers.sh amazonlinux 4.14.77 85c88952b018fdbce2464222c3303229f5bfcfad

@poiana
Copy link
Contributor

poiana commented May 26, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@poiana poiana requested review from jonahjon and leogr May 26, 2021 15:31
@maxgio92 maxgio92 changed the title wip: Split ubuntu drivers build jobs wip: Split drivers build jobs May 26, 2021
@maxgio92 maxgio92 marked this pull request as ready for review May 28, 2021 15:05
@maxgio92
Copy link
Member Author

What do you think @jonahjon?

@jonahjon
Copy link
Contributor

@maxgio92 I think this is awesome idea, lets give it a whirl and test it.

@maxgio92 maxgio92 changed the title wip: Split drivers build jobs Split drivers build jobs Jun 1, 2021
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely Max! Finally 👏

Left one comment :)

Also: you probably forgot to create the ProwJobs for ubuntu-generic 3.* kernels (we have a bunch of them) ;)

images/build-drivers/build-drivers.sh Outdated Show resolved Hide resolved
images/build-drivers/build-drivers.sh Outdated Show resolved Hide resolved
@maxgio92 maxgio92 force-pushed the feat/split-drivers-build-jobs branch from 143cfc6 to 476332b Compare June 4, 2021 14:07
@maxgio92 maxgio92 changed the title Split drivers build jobs wip: Split drivers build jobs Jun 4, 2021
@maxgio92 maxgio92 changed the title wip: Split drivers build jobs Split drivers build jobs Jun 4, 2021
@maxgio92
Copy link
Member Author

maxgio92 commented Jun 4, 2021

I updated the description since I added a refactoring on the build-drivers.sh script. I'm testing it.

@maxgio92 maxgio92 force-pushed the feat/split-drivers-build-jobs branch from 55d937b to b78ffc4 Compare June 4, 2021 16:13
@maxgio92
Copy link
Member Author

maxgio92 commented Jun 4, 2021

The local tests passed.

@maxgio92
Copy link
Member Author

maxgio92 commented Jun 7, 2021

At this point, as of #421, if other build-drivers work, this PR can be considered already working and approved (or at least tests on production passed :D)

@maxgio92
Copy link
Member Author

maxgio92 commented Jun 8, 2021

/test build-images-build-drivers

@poiana
Copy link
Contributor

poiana commented Jun 8, 2021

LGTM label has been added.

Git tree hash: a2fd6d24c23df5f4592dadadb18b99480d4484a1

@poiana poiana added the approved label Jun 8, 2021
@leodido
Copy link
Member

leodido commented Jun 8, 2021

/approve

@poiana
Copy link
Contributor

poiana commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fcccf55 into master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants