-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split drivers build jobs #410
Conversation
Skipping CI for Draft Pull Request. |
What do you think @jonahjon? |
@maxgio92 I think this is awesome idea, lets give it a whirl and test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is lovely Max! Finally 👏
Left one comment :)
Also: you probably forgot to create the ProwJobs for ubuntu-generic
3.* kernels (we have a bunch of them) ;)
…nel version Signed-off-by: maxgio92 <[email protected]>
…per kernel version Signed-off-by: maxgio92 <[email protected]>
Signed-off-by: maxgio92 <[email protected]>
143cfc6
to
476332b
Compare
I updated the description since I added a refactoring on the |
Signed-off-by: maxgio92 <[email protected]>
55d937b
to
b78ffc4
Compare
The local tests passed. |
Signed-off-by: maxgio92 <[email protected]>
Signed-off-by: maxgio92 <[email protected]>
Signed-off-by: maxgio92 <[email protected]>
At this point, as of #421, if other |
/test build-images-build-drivers |
LGTM label has been added. Git tree hash: a2fd6d24c23df5f4592dadadb18b99480d4484a1
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR aims to starting implement what is proposed in FR #406.
build-drivers
image script now accepts a optional and positional arguments as pattern string to also:specific_target
Make target)ubuntu-generic
andubuntu-aws
distro variants are split into jobs for kernel version 3, 4 and 5build-drivers.sh
script has been refactored, so that we can also call it like that (from the root of this repo):PUBLISH_S3=false ENSURE_DOCKER=false DBG_WORKDIR=$PWD/driverkit \ ./images/build-drivers/build-drivers.sh amazonlinux 4.14.77 85c88952b018fdbce2464222c3303229f5bfcfad