Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(location): standardize abbreviated parameter #2061

Merged
merged 5 commits into from
Apr 17, 2023
Merged

chore(location): standardize abbreviated parameter #2061

merged 5 commits into from
Apr 17, 2023

Conversation

Shinigami92
Copy link
Member

related to #1349

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module deprecation A deprecation was made in the PR labels Apr 16, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 16, 2023 13:11
@Shinigami92 Shinigami92 self-assigned this Apr 16, 2023
@Shinigami92 Shinigami92 mentioned this pull request Apr 16, 2023
Merged
@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@62b1aed). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2f1d33e differs from pull request most recent head 9369093. Consider uploading reports for the commit 9369093 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2061   +/-   ##
=======================================
  Coverage        ?   99.61%           
=======================================
  Files           ?     2535           
  Lines           ?   241788           
  Branches        ?     1287           
=======================================
  Hits            ?   240861           
  Misses          ?      900           
  Partials        ?       27

@ST-DDT
Copy link
Member

ST-DDT commented Apr 16, 2023

There are lint errors.

ST-DDT
ST-DDT previously approved these changes Apr 16, 2023
View reviewed changes
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Apr 16, 2023
@ST-DDT ST-DDT requested review from a team April 16, 2023 13:54
@xDivisionByZerox
Copy link
Member

What about:

  • date.month({ abbr })
  • date.weekday({ abbr })

xDivisionByZerox added a commit that referenced this pull request Apr 16, 2023
@xDivisionByZerox
docs: align with #2061
b281524
@ST-DDT ST-DDT requested review from a team April 17, 2023 07:30
@ST-DDT
Copy link
Member

ST-DDT commented Apr 17, 2023

What about:

* date.month({ abbr })

* date.weekday({ abbr })

We should fix them as well, but in a different PR.

@ST-DDT ST-DDT enabled auto-merge (squash) April 17, 2023 08:14
@ST-DDT ST-DDT merged commit 4df3de6 into next Apr 17, 2023
@ST-DDT ST-DDT deleted the 1349-standardize-location-abbr branch April 17, 2023 08:20
@Shinigami92 Shinigami92 mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @ST-DDT @xDivisionByZerox @matthewmayer