Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(location): merge state and stateAbbr #2060

Merged
merged 9 commits into from
Apr 17, 2023
Merged

refactor(location): merge state and stateAbbr #2060

merged 9 commits into from
Apr 17, 2023

Conversation

xDivisionByZerox
Copy link
Member

References #1346 (comment)

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: location Something is referring to the location module deprecation A deprecation was made in the PR labels Apr 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team April 16, 2023 12:33
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 16, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 16, 2023 12:33
@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

Merging #2060 (18b4866) into next (bb9e0e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 18b4866 differs from pull request most recent head 6b74b6e. Consider uploading reports for the commit 6b74b6e to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2060   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2535     2535           
  Lines      241868   241892   +24     
  Branches     1286     1288    +2     
=======================================
+ Hits       240941   240965   +24     
  Misses        900      900           
  Partials       27       27
Impacted Files Coverage Δ
src/modules/location/index.ts 99.16% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team April 16, 2023 12:42
matthewmayer
matthewmayer requested changes Apr 16, 2023
View reviewed changes
src/modules/location/index.ts Outdated Show resolved Hide resolved
src/modules/location/index.ts Show resolved Hide resolved
@xDivisionByZerox xDivisionByZerox mentioned this pull request Apr 16, 2023
Closed
ST-DDT
ST-DDT requested changes Apr 16, 2023
View reviewed changes
src/modules/location/index.ts Outdated Show resolved Hide resolved
src/modules/location/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team and Shinigami92 April 17, 2023 08:03
matthewmayer
matthewmayer approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though we should come back and review this works as expected after #2045 and #2004 are done.

@ST-DDT ST-DDT enabled auto-merge (squash) April 17, 2023 13:20
@ST-DDT ST-DDT merged commit 5c8638b into next Apr 17, 2023
@Shinigami92 Shinigami92 deleted the refactor/location/merge-state-and-state-abbr branch April 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
deprecation A deprecation was made in the PR m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92