refactor(date): rename abbr to abbreviated

[Shinigami92]

reference #2061 (comment)

[Shinigami92]

@ST-DDT How can I fix the deprecation test without adding multiple signature overloads to the methods? These would be overkill in my opinion for just deprecating/renaming a property from the options.

[ST-DDT]

@ST-DDT How can I fix the deprecation test without adding multiple signature overloads to the methods? These would be overkill in my opinion for just deprecating/renaming a property from the options.

That is sadly not possible. When typing a method or something, Ts always takes the last signature.
This also affected the type FakerOptions = ConstructorParameter[0]. As well as our doc generation.

[Shinigami92]

This also affected the type FakerOptions = ConstructorParameter[0]. As well as our doc generation.

Should I add an ignore to the test or really quadruple the signature?

[ST-DDT]

Should I add an ignore to the test or really quadruple the signature?

For consistency reasons, please add the mixed signature.

[Shinigami92]

For consistency reasons, please add the mixed signature.

done

[codecov]

Codecov Report

Merging #2068 (3b41abc) into next (db8792c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2068      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files        2535     2535              
  Lines      241892   242163     +271     
  Branches     1287     1291       +4     
==========================================
+ Hits       240970   241232     +262     
- Misses        895      904       +9     
  Partials       27       27              

Impacted Files	Coverage Δ
src/modules/date/index.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[ST-DDT]

The CI still fails.

[Shinigami92]

The CI still fails.

ts-check:tests is not in the preflight script 🤔

oh it is! but it does not exit !0 👀