-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove dynamic locale switching support #1735
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1735 +/- ##
==========================================
- Coverage 99.64% 99.62% -0.02%
==========================================
Files 2355 2356 +1
Lines 236763 236565 -198
Branches 1158 1192 +34
==========================================
- Hits 235919 235678 -241
- Misses 822 865 +43
Partials 22 22
|
@matthewmayer do you have any more reviews you want to have into the PR before merging? |
sorry my bad i didnt realise that blocked merge. approved now. I have some further ideas for improving migration guide but that can be saved for a seperate PR. |
🎉 I will try to find some time the next days to address #1748 again |
Closes #1340
Removes the ability to change the locale on existing Faker instances.
New Features
en_AU_ocker
)allLocales.en_AU_ocker
)fakerEN_AU_ocker
)allFakers.en_AU_ocker
)en_AU_ocker
->en_AU
->en
( ->en
if not already present ( ->global
later))Changed Features
faker
instance is nowen
onlyLost Features
ToDos for later PRs
global
locale data into own locale (Add global locale #1441)findFaker(locale: string): Faker
method ???