Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run seeded tests for all locales #1749

Open
ST-DDT opened this issue Jan 17, 2023 · 4 comments
Open

Run seeded tests for all locales #1749

ST-DDT opened this issue Jan 17, 2023 · 4 comments
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 17, 2023

Clear and concise description of the problem

Currently the seeded tests only run for the en locale.

Suggested solution

Run the seeded tests for all locales.

Pro:

  • Generate visible examples for all locales

Con:

  • Might cause a review overload due to the amount of generated test snapshots

Alternative

Do nothing extra

Additional context

The discussion originally came up in #1735 (comment)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test s: needs decision Needs team/maintainer decision labels Jan 17, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 17, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 17, 2023

For now, I'm kind of against adding this as this reduces the probability that someone actually reviews the test snapshots.

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 19, 2023

Team decision

We will change the seeded tests to run all tests for all faker instances and verify, but only the main faker instance will write test snapshots.
This will render the all_functional.spec.ts obsolete.

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Jan 19, 2023
@xDivisionByZerox
Copy link
Member

Is this required for v8? I could be implemented in v8-x as well, no?

@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 29, 2023

I think its just nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants