Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global locale #1441

Closed
Shinigami92 opened this issue Oct 13, 2022 · 2 comments · Fixed by #1748
Closed

Add global locale #1441

Shinigami92 opened this issue Oct 13, 2022 · 2 comments · Fixed by #1748
Assignees
@Shinigami92
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@Shinigami92
Copy link
Member

Shinigami92 commented Oct 13, 2022 •
edited
Loading

We want to move global locale data out of locale definitions to their related modules.
These data are the same for every language and therefore doesn't need to exist in locale en or be override-able by any other locale.

Example: mime-types, emojis, ...
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Oct 13, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 13, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Oct 13, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Oct 13, 2022
@ST-DDT ST-DDT mentioned this issue Jan 13, 2023
Merged
@ST-DDT
Copy link
Member

ST-DDT commented Jan 17, 2023

I think we should rather introduce a global locale.
Like any of our other data there is no reason why we shouldn't make them replaceable.

@ST-DDT ST-DDT mentioned this issue Jan 17, 2023
Merged
@Shinigami92
Copy link
Member Author

As it doesn't make a difference if we put them in global locale or in the source directly, I'm fine with that, esm/cjs would duplicate them any way
We can only get rid of this duplication in the long run by getting rid of cjs in total 🤷

So yes, lets do it that way 👍

@Shinigami92 Shinigami92 linked a pull request Jan 17, 2023 that will close this issue
feat: add base locale #1748
Merged
@Shinigami92 Shinigami92 mentioned this issue Jan 17, 2023
Merged
@ST-DDT ST-DDT changed the title Move global locale data to their modules Add global locale Jan 26, 2023
@ST-DDT ST-DDT mentioned this issue Feb 4, 2023
Closed
@github-project-automation github-project-automation bot moved this from Todo to Done in Faker Roadmap Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

feat: add base locale faker-js/faker
2 participants
@ST-DDT @Shinigami92