This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Update documentation and remove a generic except #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Lyears
pushed a commit
to Lyears/maskrcnn-benchmark
that referenced
this pull request
Jun 28, 2020
* Add ImportError to generic except * Black formatter * OpenCV is no longer optional * Update README w.r.t. FPN_POST_NMS_PER_BATCH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some nits:
ImportErrorto a genericexceptand swap the order (first try the new API, then fallback to the old one as you suggested in APIs moved to torch.hub #673 (review))