Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Add OpenCV in the INSTALL instructions #694

Merged

Conversation

rodrigoberriel
Copy link
Contributor

Minor stuff on the INSTALL instructions:

  1. After b4d5465, OpenCV is now required. We can either perform a check (maybe the user is using only Faster R-CNN) or just add opencv-python in the INSTALL instructions. This PR goes with the second option;

  2. This PR also fixes the ~github used during the apex install. The convention was adopted after the beginning of the mixed-precision PR.

If you do a fresh install and try to run the train command on the README, you get this error:

Traceback (most recent call last):
  File "tools/train_net.py", line 15, in <module>
    from maskrcnn_benchmark.data import make_data_loader
  File "/home/berriel/projects/maskrcnn-benchmark-fork/maskrcnn_benchmark/data/__init__.py", line 2, in <module>
    from .build import make_data_loader
  File "/home/berriel/projects/maskrcnn-benchmark-fork/maskrcnn_benchmark/data/build.py", line 10, in <module>
    from . import datasets as D
  File "/home/berriel/projects/maskrcnn-benchmark-fork/maskrcnn_benchmark/data/datasets/__init__.py", line 2, in <module>
    from .coco import COCODataset
  File "/home/berriel/projects/maskrcnn-benchmark-fork/maskrcnn_benchmark/data/datasets/coco.py", line 6, in <module>
    from maskrcnn_benchmark.structures.segmentation_mask import SegmentationMask
  File "/home/berriel/projects/maskrcnn-benchmark-fork/maskrcnn_benchmark/structures/segmentation_mask.py", line 1, in <module>
    import cv2
ImportError: No module named 'cv2'

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 19, 2019
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 66c3e56 into facebookresearch:master Apr 20, 2019
Lyears pushed a commit to Lyears/maskrcnn-benchmark that referenced this pull request Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants