This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Add a switch for POST_NMS per batch/image during training #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #676, adding the
MODEL.RPN.FPN_POST_NMS_PER_BATCH
switch:True
(default): the code behaves AS IS, to keep it consistent with Detectron;False
: POST_NMS is then applied per image, as "it should be":maskrcnn-benchmark/maskrcnn_benchmark/modeling/rpn/inference.py
Lines 157 to 158 in 08fcf12
I was wondering if I should add a comment on the README; something like this (changes in bold):