Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding #344

Closed
wants to merge 1 commit into from

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Jan 18, 2017

Followup of #335, fix #326. This commit add the YGLayoutGetBorder(node, edge) function, which correctly takes RTL/LTR into account when resolving EDGE_START & EDGE_END.

@arcanis
Copy link
Contributor Author

arcanis commented Jan 18, 2017

@emilsjolander Can you publish a release on npm once this PR is merged? Due to this repository being monolithic by design, the package cannot be used with npm and yarn without performing a manual clone :)

@emilsjolander
Copy link
Contributor

@arcanis sure, I can do this later this week or early next week.

@facebook-github-bot
Copy link
Contributor

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 26, 2017
Summary:
Followup of #335, fix #326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
@emilsjolander
Copy link
Contributor

@arcanis What should I do to publish this on npm? I'm new to that whole ecosystem.

@emilsjolander
Copy link
Contributor

@arcanis Also could you have a look at the js tests failing on travis?

@arcanis
Copy link
Contributor Author

arcanis commented Jan 27, 2017

I think the tests are failing because the javascript/build/Release/nbind.js file hasn't been regenerated after one of the breaking changes - I've just pulled the repo, rebuilt it, and everything passed (this theory is supported by the fact that the native module tests are passing, which makes sense because they are automatically rebuilt when running npm install).

As for publishing, first ensure you have an npm account (I'm not sure if fb requires projects to be published under an umbrella account) by running npm adduser - If you don't have one, it should create it automatically. Otherwise, it will log you in.

Publish the first release:

  • Jump into the javascript directory
  • Run npm run build:all
  • Run npm publish

Publish future releases:

  • Jump into the javascript directory
  • Run npm run build:all
  • Run npm version <major/minor/patch> (will respectively bump major/minor/patch version number)
  • Run npm publish

If you want, I can publish the initial release then give you access to the package.

@emilsjolander
Copy link
Contributor

@arcanis I can give it a try! thanks

edmofro pushed a commit to edmofro/react-native that referenced this pull request Feb 6, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 7, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
normanjoyner pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
vincentriemer pushed a commit to vincentriemer/yoga-dom that referenced this pull request May 9, 2018
Summary:
Followup of #335, fix #326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content box
3 participants