Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevMenu] Reload shortcut does not work with alternative keyboard layouts #326

Closed
alisnic opened this issue Mar 27, 2015 · 6 comments
Closed

[DevMenu] Reload shortcut does not work with alternative keyboard layouts #326

alisnic opened this issue Mar 27, 2015 · 6 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@alisnic
Copy link

alisnic commented Mar 27, 2015

I am a Colemak user, cmd-R does not reload the app within the simulator. If I switch to QWERTY, the shortcut works.
@alisnic alisnic changed the title Reload shortcut does not work on alternative keyboard layouts Reload shortcut does not work with alternative keyboard layouts Mar 27, 2015
@vjeux
Copy link
Contributor

vjeux commented Mar 27, 2015

Thanks for flagging. cmd+R support is using some trickery already. I'm unsure if it's even possible to detect different keyboard layouts and change the shortcut accordingly :x

@vjeux vjeux mentioned this issue Mar 27, 2015
Closed
@tehfailsafe
Copy link
Contributor

Does disabling the menu item Hardware > Keyboard > iOS uses same layout as OSX fix it while keeping the layout?

tehfailsafe added a commit to tehfailsafe/react-native that referenced this issue Mar 27, 2015
@tehfailsafe
Add recurring issues for troubleshooting
e8a3f44 
Hopefully alleviates new issues getting created for similar problems. 
Addresses facebook#257 facebook#304 facebook#306 facebook#326
@alisnic
Copy link
Author

alisnic commented Mar 28, 2015

@tehfailsafe nope, but shake gesture as a workaround is pretty nice, since its shortcut (cmd-ctrl-z) works on any layout

@brentvatne brentvatne changed the title Reload shortcut does not work with alternative keyboard layouts [DevMenu] Reload shortcut does not work with alternative keyboard layouts May 30, 2015
@bradediger
Copy link

This works properly if you change the iOS hardware keyboard layout:

Home > Settings > General > Keyboard > Hardware Keyboard > English > (your layout)

iOS then passes the hardware keyboard events correctly. This is now working for me using Dvorak.

@brentvatne
Copy link
Collaborator

Thanks @bradediger 😄 🚀

@feifanzhou
Copy link

I am using Dvorak. Cmd-R doesn't work, but Cmd-P (where R would be in QWERTY) does work.

facebook-github-bot pushed a commit that referenced this issue Jan 15, 2017
@arcanis @facebook-github-bot
Add YGLayoutGetMargin
ae4fa4b 
Summary:
Fix #326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌
Closes facebook/yoga#335

Reviewed By: gkassabli

Differential Revision: D4409399

Pulled By: emilsjolander

fbshipit-source-id: 8153f6701cab60b55a485f6d2e0b9f7767481090
nicktate pushed a commit to nicktate/react-native that referenced this issue Jan 19, 2017
@arcanis @nicktate
Add YGLayoutGetMargin
4cd2be1 
Summary:
Fix facebook#326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌
Closes facebook/yoga#335

Reviewed By: gkassabli

Differential Revision: D4409399

Pulled By: emilsjolander

fbshipit-source-id: 8153f6701cab60b55a485f6d2e0b9f7767481090
facebook-github-bot pushed a commit that referenced this issue Jan 26, 2017
@arcanis @facebook-github-bot
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
3a476a8 
Summary:
Followup of #335, fix #326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
edmofro pushed a commit to edmofro/react-native that referenced this issue Feb 6, 2017
@arcanis
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
881fd78 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 7, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
bcc78f8 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
normanjoyner pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @normanjoyner
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
7adf3fe 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
9d2d37a 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
4f0bf5c 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
d5b8d49 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
73b1d13 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
249fdb1 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
0d468d8 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
bfd3c26 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
1c87ba9 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
3dab161 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
40b1f24 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
01c4bb5 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
bdd0595 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
6048762 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
nicktate pushed a commit to nicktate/react-native that referenced this issue Feb 9, 2017
@arcanis @nicktate
Add YGLayoutGetBorder, counterpart of YGLayoutGetPadding
54945a1 
Summary:
Followup of facebook#335, fix facebook#326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`.
Closes facebook/yoga#344

Reviewed By: dshahidehpour

Differential Revision: D4459950

Pulled By: emilsjolander

fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
@facebook facebook locked as resolved and limited conversation to collaborators Jul 23, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@bradediger @brentvatne @vjeux @tadeuzagallo @tehfailsafe @alisnic @feifanzhou @react-native-bot