Add YGLayoutGetMargin #335
Conversation
|
Could you add the c# and java bindings for this as well? Should be fairly straight forward as it will look exactly like the padding ones. |
|
Eh eh, I was working on them, they've just been pushed :) I haven't been able to test them yet, will Travis run the tests for those interfaces as well ? |
|
Yup it will :) thanks! |
|
Seems good, tests are now passing |
|
@emilsjolander I started looking at how I can implement |
|
@arcanis I would rather it was a PR based on top of this one. Trying to move to smaller pull requests where possible as it makes it much easier to grok the code. Thanks 👍 |
|
Ok 👍 |
| @@ -333,6 +333,12 @@ public void SetPosition(YogaEdge edge, YogaValue value) | |||
| } | |||
| } | |||
|
|
|||
| [Obsolete("use LayoutMargin properties")] | |||
There was a problem hiding this comment.
Don't add an Obsolete property :p all these will be removed soon enough.
|
@arcanis Looks good now, thanks! |
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Fix #326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌 Closes facebook/yoga#335 Reviewed By: gkassabli Differential Revision: D4409399 Pulled By: emilsjolander fbshipit-source-id: 8153f6701cab60b55a485f6d2e0b9f7767481090
Summary: Fix facebook#326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌 Closes facebook/yoga#335 Reviewed By: gkassabli Differential Revision: D4409399 Pulled By: emilsjolander fbshipit-source-id: 8153f6701cab60b55a485f6d2e0b9f7767481090
Summary: Followup of #335, fix #326. This commit add the `YGLayoutGetBorder(node, edge)` function, which correctly takes RTL/LTR into account when resolving `EDGE_START` & `EDGE_END`. Closes #344 Reviewed By: dshahidehpour Differential Revision: D4459950 Pulled By: emilsjolander fbshipit-source-id: b57eb7a5b1c181a364913c3200a3794a2b7b31a6
Summary: Fix #326. I'll open another PR once this one gets accepted to add support for `YGLayoutGetBorder` 👌 Closes facebook/yoga#335 Reviewed By: gkassabli Differential Revision: D4409399 Pulled By: emilsjolander fbshipit-source-id: 8153f6701cab60b55a485f6d2e0b9f7767481090
Fix #326. I'll open another PR once this one gets accepted to add support for
YGLayoutGetBorder👌