Simplify YGConfigSetPointScaleFactor
#1451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
force-pushed
the
export-D51014264
branch
from
5dd7eb8 to
63b6641
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
force-pushed
the
export-D51014264
branch
from
63b6641 to
c0e93cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
force-pushed
the
export-D51014264
branch
from
c0e93cb to
4884d9a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1451 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1451 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
force-pushed
the
export-D51014264
branch
from
4884d9a to
eb8c4a7
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1451 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
force-pushed
the
export-D51014264
branch
from
eb8c4a7 to
d2039ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1451 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
Summary: X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
NickGerleman
force-pushed
the
export-D51014264
branch
from
d2039ea to
5cbfb0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014264 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/yoga#1451 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264
|
This pull request has been merged in 1b1df3a. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/yoga#1451 X-link: facebook/react-native#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264 fbshipit-source-id: 60f4a2df039f74089d5c7fabd4b7d8ac6234ba72
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/yoga#1451 Pull Request resolved: #41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264 fbshipit-source-id: 60f4a2df039f74089d5c7fabd4b7d8ac6234ba72
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1451 Pull Request resolved: facebook#41327 The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler. Reviewed By: yungsters Differential Revision: D51014264 fbshipit-source-id: 60f4a2df039f74089d5c7fabd4b7d8ac6234ba72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The special meaning of
0.0is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler.Differential Revision: D51014264