Modularize and document public API #41317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API 5. Move JNI bindings fully to public API Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API 5. Move JNI bindings fully to public API Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
fa27476 to
c139302
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
c139302 to
e1c905b
Compare
Base commit: 0479beb |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 4, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 4, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
e1c905b to
178ff58
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
178ff58 to
6f4060b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting most public APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping 4. Removed `Yoga-internal.h`, making all top-level headers public. `YGNodeDeallocate` is folded into a public `YGNodeFinalize` API with its use-case documented 5. Move JNI bindings fully to public API Changelog: [Internal] Differential Revision: D50963424
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 9, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 9, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
66ca0df to
327d1c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
327d1c0 to
d934ed0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
d934ed0 to
eca675b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 10, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
force-pushed
the
export-D50963424
branch
from
eca675b to
47d488d
Compare
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/react-native#41317 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
|
This pull request was exported from Phabricator. Differential Revision: D50963424 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424
NickGerleman
force-pushed
the
export-D50963424
branch
from
47d488d to
e8e6d5c
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/react-native#41317 Pull Request resolved: #1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424 fbshipit-source-id: 45124b7370256fc63aefd6d5b7641466e9a79d3b
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 11, 2023
Summary: X-link: facebook/react-native#41317 X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424 fbshipit-source-id: 45124b7370256fc63aefd6d5b7641466e9a79d3b
|
This pull request was successfully merged by @NickGerleman in 5910032. When will my fix make it into a release? | Upcoming Releases |
This was referenced Dec 22, 2023
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41317 X-link: facebook/yoga#1449 This aims to clean up the public Yoga C API, by: 1. Documenting public YGNode, YGValue, YGConfig APIs 2. Splitting APIs for specific objects into different header files (because Yoga.h was big enough without documentation) 3. Reordering headers and definitions for consistent grouping Changelog: [Internal] Reviewed By: joevilches Differential Revision: D50963424 fbshipit-source-id: 45124b7370256fc63aefd6d5b7641466e9a79d3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1449
This aims to clean up the public Yoga C API, by:
Yoga-internal.h, making all top-level headers public.YGNodeDeallocateis folded into a publicYGNodeFinalizeAPIDifferential Revision: D50963424