Skip to content

Commit

Permalink
Simplify YGConfigSetPointScaleFactor (#41327)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebook/yoga#1451

Pull Request resolved: #41327

The special meaning of `0.0` is now explained in the function header, and we aren't doing any sort of insensitive compare here, so the code after should be equivalent and a bit simpler.

Reviewed By: yungsters

Differential Revision: D51014264

fbshipit-source-id: 60f4a2df039f74089d5c7fabd4b7d8ac6234ba72
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Nov 11, 2023
1 parent 5910032 commit a9c23fb
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions packages/react-native/ReactCommon/yoga/yoga/YGConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,7 @@ void YGConfigSetPointScaleFactor(
pixelsInPoint >= 0.0f,
"Scale factor should not be less than zero");

// We store points for Pixel as we will use it for rounding
if (pixelsInPoint == 0.0f) {
// Zero is used to skip rounding
resolveRef(config)->setPointScaleFactor(0.0f);
} else {
resolveRef(config)->setPointScaleFactor(pixelsInPoint);
}
resolveRef(config)->setPointScaleFactor(pixelsInPoint);
}

float YGConfigGetPointScaleFactor(const YGConfigConstRef config) {
Expand Down

0 comments on commit a9c23fb

Please sign in to comment.