Update mon 15 jun #1630
Merged
Update mon 15 jun #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Summary: Adds a CocoaPods subspec for LinkingIOS Discussed in issue facebook#667 Closes facebook#1586 Github Author: Mark Edington <[email protected]> Test Plan: Pull in the subspec and run a sample which calls RCTLinkingManager.openURL(url);
Summary: @public This probably needs more thought - might want to differentiate between console.error and reportError. Test Plan: console.error and reportError no longer redbox. invariant and RCTLogError still do.
Summary: Here is an example project demonstrating this pull request: [AKMapView](https://github.com/adamkrell/AKMapView) Closes facebook#1503 Github Author: Adam Krell <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: - Followup of facebook@45d8fb0 Closes facebook#1558 Github Author: Prathamesh Sonpatki <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: The `InspectorOverlay` component was getting unwieldy, so I broke it into three components: - Inspector - InspectorOverlay - InspectorPanel and added @flow types. The inspector was also living under the `ReactIOS` directory, and I moved it up into the `Libraries` directory, as the inspector will soon be usable [on Android](https://phabricator.fb.com/D2138319). All features of the inspector should remain functional, with the addition of one feature: - you can toggle "touch to inspect" by tapping the "Inspect" button at the bottom of the inspection panel. When inspection is disabled, the panel remains, but you can interact with the app normally without touches being intercepted @public Test Plan: Open the inspector: - touch to inspect things, verify that margin, padding, size and position are reported correctly, and that the component hierarchy is navigable. - tap the "Inspect" button, and verify that you can interact with the app normally. {F22548949} [Video of toggling inspection](https://www.latest.facebook.com/pxlcld/mrs9)
Summary: Without a width or height set for the X or O image they don't appear, fix this problem by adding styles with width and height specified. Closes facebook#1122 Github Author: Rusty Conover <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
…onary in websocketClosed Summary: I am not 100% sure what causes reason to be null but it does happen. Closes facebook#1483 Github Author: Stanislav Vishnevskiy <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: @public Remove extra `JSGlobalContextRetain` that was causing the context ref to leak + remove `self` reference from block and improve invalidation Test Plan: Run the UIExplorer, reload the app a few times, verify that the memory usage is not increasing.
Summary: @public Use consistent `null` handling: `value || null` -> `RCTNullIfNil(value)` `value == null ? nil : value` -> `RCTNilIfNull(value)` `[NSNull null]` -> `(id)kCFNull` Test Plan: The tests should be enough.
…tion Summary: This is a proposal to add `getScrollResponder` to all ScrollView-like components, including ListView. This allows multiple higher-order scroll views to be composed while allowing the owner of the top-level scroll view to call `scrollableView.getScrollResponder().scrollTo(...)` regardless of whether `scrollableView` is a ScrollView, ListView, InvertedScrollView, etc. Closes facebook#766 Github Author: James Ide <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: Added some more exports to React that are either necessary or often useful for component authors. Closes facebook#262 Github Author: James Ide <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: @public setFrame:forRootView: wasn't triggering a batch update, which is required to trigger text update. This meant text wasn't re-displayed after a rotate, only after a touch. I also found a bug that meant we weren't caching textStorage as much as we could be. Fixed that too. Test Plan: * Test <Text> example in UIExplorer and ensure it lays out on rotate. * Test <Timers> example and verify text is still updating * Products shouldn't be affected as they have separate text implementation
Summary: @public Include stack traces in native redboxes (e.g. from RCTLogError). It's not trivial to get the file names and line numbers for every frame of the stack, but we can get the first one which is nice. Test Plan: {F22548418}
Summary: @public `-[RCTJavaScriptExecutor executeBlockOnJavaScriptQueue:]` would always `dispatch_async` for the WebView and WebSocket executors, what caused for any frame aligned dispatch. Test Plan: Test the `Timers, TimerMixin` example on UIExplorer, `requestAnimationFrame` was taking ~33.3ms when debugging, now takes ~16.6ms as expected.
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.