[TicTacToe] Fix missing image styles for TicTacToe example #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a width or height set for the X or O image they don't appear, fix this problem by adding styles with width and height specified.
facebook-github-bot
added
the
CLA Signed
|
@frantic should this be using the require(image!xxx) syntax for images instead? That way, we get the size set automatically, right? |
|
Isn't that only for Xcode bundled images? |
|
Oh right, these are remote images. Sorry, then yes, this is fine. |
|
We should probably stop using these remote images. 😆 |
brentvatne
changed the title
|
@rustyconover - could you update this PR to load the images from |
|
FYI: we're deprecated the automatic style from require(image!... magic so please don't use it going forward ;) |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/691320904330225/int_phab to review. |
sahrens
pushed a commit
to sahrens/react-native
that referenced
this pull request
Jun 12, 2015
Summary: Without a width or height set for the X or O image they don't appear, fix this problem by adding styles with width and height specified. Closes facebook#1122 Github Author: Rusty Conover <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
May 13, 2022
Several more compliance fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a width or height set for the X or O image they don't appear, fix this problem by adding styles with width and height specified.