[WebSocket] Reason can be null which causes an exception with NSDictionary in websocketClosed #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnevskiy
changed the title
facebook-github-bot
added
the
CLA Signed
|
Looks like SocketRocket doesn't guarantee a non-null reason, this lgtm. |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1619666888292087/int_phab to review. |
sahrens
pushed a commit
to sahrens/react-native
that referenced
this pull request
Jun 12, 2015
…onary in websocketClosed Summary: I am not 100% sure what causes reason to be null but it does happen. Closes facebook#1483 Github Author: Stanislav Vishnevskiy <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
* Share - title is not a valid attribute in iOS facebook#27306 * Share - title is not a valid attribute in iOS facebook#27306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure what causes reason to be null but it does happen.