-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom android buildPatch with react-native link #15451
Commits on Sep 11, 2017
-
Improve RCTCxxBridge invalidation
Reviewed By: fromcelticpark Differential Revision: D5536063 fbshipit-source-id: b0f19bebea839c7da84890c338ad4d38293bc99c
Configuration menu - View commit details
-
Copy full SHA for 7b77055 - Browse repository at this point
Copy the full SHA 7b77055View commit details -
Migrate tests away from "jsdom" environment
Reviewed By: leebyron Differential Revision: D5748304 fbshipit-source-id: c66df45f1f35333f994c41eb8ff4cfccc1bb04d4
Configuration menu - View commit details
-
Copy full SHA for bae5505 - Browse repository at this point
Copy the full SHA bae5505View commit details -
Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes #15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124
Configuration menu - View commit details
-
Copy full SHA for 96de23a - Browse repository at this point
Copy the full SHA 96de23aView commit details -
Add all test routes as server snapshot tests
Reviewed By: raluca-elena, TheSavior Differential Revision: D5638532 fbshipit-source-id: 8db8210d0d0d08b9423b0a77f6b8e4e290f2eef0
Configuration menu - View commit details
-
Copy full SHA for 393bf88 - Browse repository at this point
Copy the full SHA 393bf88View commit details -
ReactRawTextShadowNode does not inherit ReactTextShadowNode anymore
Summary: ReactRawTextShadowNode represents "raw" text node (aka textContent), so it cannot have layout or styling, it is just a line of text, a pure string. So, we must not interit it from HUGE ReactTextShadowNode (which represents <Text> node with ReactRawTextShadowNode instance inside). We need this change to make future fancy (and valuable from product perspective) refactoring possible. Stay tuned! Reviewed By: achen1 Differential Revision: D5712961 fbshipit-source-id: 009e48046bdf34ddfd40b93175934969af64b98b
Configuration menu - View commit details
-
Copy full SHA for 80027ce - Browse repository at this point
Copy the full SHA 80027ceView commit details -
Restructured inheritance around ReactTextViewManager and co.
Summary: Abstract class `ReactBaseTextShadowNode` was decoupled from `ReactTextShadowNode` to separate two goals/roles: * `ReactBaseTextShadowNode` represents spanned `<Text>` nodes, which can bear text attributes (both `RCTText` and `RCTVirtualText`); * `ReactTextShadowNode` represents anchor `<Text>` view in Yoga terms, which can bear layout attributes (`RCTText` and `RCTTextInput`). `ReactVirtualTextShadowNode` now inherits `ReactBaseTextShadowNode`. The same architectural changes was applited to view managers. Why? * This is just a better architecture which represents the nature of this objects. * Bunch of "negative" logic which turn off excessive features for some suclasses was removed. * Memory efficiency. * Now we can improve `<TextInput>` component using right inheritance. Yay! Reviewed By: achen1 Differential Revision: D5715830 fbshipit-source-id: ecc0764a03b5b7586fe77ad31f149cd840f4da41
Configuration menu - View commit details
-
Copy full SHA for 6114f86 - Browse repository at this point
Copy the full SHA 6114f86View commit details -
support null titles in AlertIOS
Reviewed By: achen1 Differential Revision: D5807055 fbshipit-source-id: f79579d4cffb9792f49f89a7fb8f7df8e082a3a9
Configuration menu - View commit details
-
Copy full SHA for d726c2c - Browse repository at this point
Copy the full SHA d726c2cView commit details -
Summary: Hi guys, A small typo found in the doc :) Closes #15888 Differential Revision: D5809251 Pulled By: TheSavior fbshipit-source-id: 7a2ca8f2cbca81aa2059ee619a8c6087256e39a6
Configuration menu - View commit details
-
Copy full SHA for b45c91d - Browse repository at this point
Copy the full SHA b45c91dView commit details
Commits on Sep 12, 2017
-
Add missing delete to requestIdleCallback
Summary: This line accidentally became a no-op when the Map was converted to an Object. Closes #15891 Differential Revision: D5811069 Pulled By: TheSavior fbshipit-source-id: 43ac1835d15e2bee67ee45646bc238f917013836
Configuration menu - View commit details
-
Copy full SHA for ce0235e - Browse repository at this point
Copy the full SHA ce0235eView commit details -
Branding: "packager" -> "Metro Bundler"
Summary: This diff renames all the stragglers in comments and strings from variations of "packager" to "Metro Bundler". I did one of three: * Rename "packager" to "Metro Bundler" * Rename "react-native-packager" to "Metro Bundler" * Remove "packager" when code inside of Metro implies that it's about Metro I also removed `Glossary.md` because it is unmaintained and very old. mjesun is currently starting to write documentation for Metro which will supersede whatever was there before. Reviewed By: mjesun Differential Revision: D5802993 fbshipit-source-id: ba99cb5ed04d84b0f7b7a8a0bf28ed99280a940a
Configuration menu - View commit details
-
Copy full SHA for 12eb04b - Browse repository at this point
Copy the full SHA 12eb04bView commit details -
Summary: Previously type Options had excludeActivityTypes property, but in RCTActionSheetManager.m and docs this property is named excludedActivityTypes. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Want to fix error in flow types Actually, it seems there aren't any need for test plan for this PR. Just fix a mistyping error. Closes #15881 Differential Revision: D5813539 Pulled By: ericnakagawa fbshipit-source-id: 7d1269d4c177f920869bf6554f14af6db7a741ee
Configuration menu - View commit details
-
Copy full SHA for 0c5b390 - Browse repository at this point
Copy the full SHA 0c5b390View commit details -
Flow type: saveToCameraRoll returns a string
Summary: Updates the flow typing to return Promise\<string\> instead of Promise\<Object\>. To validate that it actually does return a string, see https://github.com/facebook/react-native/blob/6493a857542c0985470311511c1be80982fcd474/Libraries/CameraRoll/RCTCameraRollManager.m#L98 and https://github.com/facebook/react-native/blob/6493a857542c0985470311511c1be80982fcd474/Libraries/CameraRoll/RCTCameraRollManager.m#L116 Closes #15631 Differential Revision: D5714842 Pulled By: shergin fbshipit-source-id: fb141b014c262bc4fb44419515e56bbe0641d8bf
Configuration menu - View commit details
-
Copy full SHA for 274e407 - Browse repository at this point
Copy the full SHA 274e407View commit details -
Use Node 8 instead of 7 in Travis CI
Summary: Node 8 is stable and newer and also gives us test coverage for npm 5, which is probably better to use for the E2E tests. Closes #15904 Differential Revision: D5814784 Pulled By: hramos fbshipit-source-id: 5b57293e804e1626fd20c200ed54c7210a6ad915
Configuration menu - View commit details
-
Copy full SHA for f6a188a - Browse repository at this point
Copy the full SHA f6a188aView commit details -
Proper support of the accessibilityLabel for <Text> components on iOS
Summary: **PR changes** The RCTText class originally overrode the accessibilityLabel and returned the raw text of the class ignoring if the accessibilityLabel was set explicitly in code. Example: <Text accessibilityLabel="Example"> Hello World </Text> // returns "Hello World" instead of "Example" for the accessibility label My update checks if the super's accessibilityLabel is not nil and returns the value else it returns the raw text itself as a default to mirror what a UIKit's UILabel does. The super's accessibilityLabel is nil if the accessibilityLabel is not ever set in code. I don't check the length of the label because if the value was set to an empty purposely then it will respect that and return whatever was set in code. With the new changes: <Text accessibilityLabel="Example"> Hello World </Text> // returns "Example" for the accessibilityLabel This change doesn't support nested <Text> components with both accessibilityLabel's value set respectively. The parent's value will return. Example: // returns "Example" instead of "Example Test" for the accessibility label <Text accessibilityLabel="Example"> Hello <Text accessibilityLabel="Test"> World </Text> </Text> The workaround is just to set the only the parent view's accessibilityLabel with the label desired for it and all its nested views or just not nest the views if possible. I believe a bigger change would be needed to support accessibility for nested views, for now the changes I have made should satisfy the requirements. Reviewed By: shergin Differential Revision: D5806097 fbshipit-source-id: aef2d7cec4657317fcd7dd557448905e4b767f1a
Configuration menu - View commit details
-
Copy full SHA for 915a020 - Browse repository at this point
Copy the full SHA 915a020View commit details -
Minor documentation correction for exposing native iOS components
Summary: Minor documentation correction for the native components iOS API section. Before: "Sometimes your native component will have some special properties that you don't want to them to be part of the API" After: "Sometimes your native component will have some special properties that you don't want to be part of the API" Confirm section renders correctly via markdown. Closes #15914 Reviewed By: TheSavior Differential Revision: D5817146 Pulled By: buymeasoda fbshipit-source-id: 075441cf7f5f23a4ca512bae48ca8fc319762b1e
1Configuration menu - View commit details
-
Copy full SHA for 3ceb20d - Browse repository at this point
Copy the full SHA 3ceb20dView commit details -
Remove 'box-only' as a layoutOnlyProp
Summary: Currently, having the property `pointerEvents={'box-only'}` marks a view as layoutOnly. For optimization reasons, layoutOnly nodes are [not added to the node hierarchy](https://github.com/facebook/react-native/blob/b103903ec869bc48dfcaf001dc926957d0b5200a/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java#L99) The problem is that should this box ever need to be [transitioned to not-layout-only](https://github.com/facebook/react-native/blob/b103903ec869bc48dfcaf001dc926957d0b5200a/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java#L394) (for example, because you add the a CSS transform property), it must be added to the hierarchy. To add it to the hierarchy the [React Styles Diff Map](https://github.com/facebook/react-native/blob/b103903ec869bc48dfcaf001dc926957d0b5200a/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java#L396) is passed along with the backing shadowNode to create the node. The problem is that at no point were the original `pointerEvents` and so the new node will be created with `pointerEvents = 'auto'`. A more correct fix to this problem might be to have shadowNodes carry around their pointerEvents, although this is likely a greater design decision which is why am I proposing the quick fix now. Will also resolve: react-native-modal/react-native-modal#11 Closes #15529 Reviewed By: AaaChiuuu Differential Revision: D5792012 Pulled By: tomasreimers fbshipit-source-id: 625242c53e16cb293c64811a57f6c3905b3483e0
Configuration menu - View commit details
-
Copy full SHA for 718f4e6 - Browse repository at this point
Copy the full SHA 718f4e6View commit details -
Removing fallback source URL from JS bridge
Summary: Remove fallback logic. It is hard to test whether a bundle is good or bad on device, since it does the fallback, remove the fallback logic now. Reviewed By: javache Differential Revision: D5773542 fbshipit-source-id: 8bb4fdad4c5761ccce915f9f1c2577464e8d37d8
Configuration menu - View commit details
-
Copy full SHA for 1712664 - Browse repository at this point
Copy the full SHA 1712664View commit details
Commits on Sep 13, 2017
-
mActivelyScrolling expected to be true so long as events are being fi…
…red. Summary: **Problem:** It was observed that in [this code path](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java#L292) (i.e. horizontal, paging-enabled scroll view) if you tried to programmatically call the scrollTo method within ~1s of the onMomentumScrollEnd event (which should only be called after all scrolling has ended), the scrollView would scroll to the new location, and then scroll BACK to the original location. For example, assume you had released the scrollView at location B, and the nearest page boundary is A. Then, 1000ms later, you call scrollTo position C. The order of operations would be: 1. Begin scrolling to A from position B (as it is the nearest page boundary) 2. Reach position A 3. Fire onMomentumScrollEnd 4. 1000ms later call scrollTo C 5. scrollView scrolls to C 6. scrollView scrolls BACK to position A (for no apparent reason). **Reason:** I suspect this is because the [smoothlyScrollTo](https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java#L292) will continue to animate towards A, but the [scrollEvents will not fire](https://github.com/facebook/react-native/blob/f954f3d9b674b13977f722bc3b8dc6c1b99fe6c7/ReactAndroid/src/main/java/com/facebook/react/views/scroll/OnScrollDispatchHelper.java#L45) as they are too close to each other. So the true order of events is: 1. Begin scrolling to A from position B (as it is the nearest page boundary) [begin smoothlyScrollTo] [scroll towards position A] [mActivelyScrolling is true] 2. Reach position A [mActivelyScrolling is true] [scroll towards position A] [mActivelyScrolling is false, as there is another scrollEvent, but because it is close enough to the same location it is ignored] 3. Fire onMomentumScrollEnd 4. 1000ms later call scrollTo C [scroll towards position C] 5. scrollView scrolls to C [scroll towards position A as the original smoothlyScrollTo animation was never completed] 6. scrollView scrolls BACK to position A. This is an untested hypothesis, but seems to explain the behavior, and the solution is more semantically correct anyway. If there is an easy way to rebuild the android binaries happy to test it myself! Just let me know! **Solution:** Move the mActivelyAnimating outside the mOnScrollDispatchHelper.onScrollChanged helper, because the HorizontalScrollView event should be considered to be animating so long as onScrollChanged events are being fired. Closes #15146 Reviewed By: AaaChiuuu Differential Revision: D5792026 Pulled By: tomasreimers fbshipit-source-id: 9654fda038d4a687cc32f4c32dc312baa34627ed
Configuration menu - View commit details
-
Copy full SHA for cbb0ccb - Browse repository at this point
Copy the full SHA cbb0ccbView commit details -
Add Example for TouchableOpacity.js
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Adding example with [react-native-web-player](https://github.com/dabbott/react-native-web-player) Screenshot on http://localhost:8079/react-native/docs/touchableopacity.html ![react-native-touchableopacity](https://user-images.githubusercontent.com/13135332/30335218-bd32fb0e-9807-11e7-976d-5235402fdba8.png) Closes #15911 Differential Revision: D5817180 Pulled By: TheSavior fbshipit-source-id: 6399a53dabf8e3f0cf680aeb41d8afbaa2ce11e8
Configuration menu - View commit details
-
Copy full SHA for fa1b533 - Browse repository at this point
Copy the full SHA fa1b533View commit details -
Add missing Contents.json, delete files that shouldn't be in .xcassets
Reviewed By: dinhviethoa Differential Revision: D5802851 fbshipit-source-id: 78e4b375bd0a0ed48d30bfb7fc746de6a2bd999e
Configuration menu - View commit details
-
Copy full SHA for 9731b58 - Browse repository at this point
Copy the full SHA 9731b58View commit details -
Reviewed By: yungsters, TheSavior Differential Revision: D5813153 fbshipit-source-id: f086e1fc5ea3d6fd9e6aa5fbd150d1ae9787cced
Configuration menu - View commit details
-
Copy full SHA for 2259538 - Browse repository at this point
Copy the full SHA 2259538View commit details -
Fixed issue with remeasuring ReactTextShadowNode
Summary: This fixes the regression recently introduced during refactoring of text-related classes. So, added fragment of code was lost in D5715830. See how it looked before: https://github.com/facebook/react-native/blob/9f5bdd7b497427506dab753ed12017900cb5ffe7/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java#L424-L431 Reviewed By: TheSavior Differential Revision: D5827424 fbshipit-source-id: 5df99620057ff6a27105dd05903c7f5def85c5d2
Configuration menu - View commit details
-
Copy full SHA for a177979 - Browse repository at this point
Copy the full SHA a177979View commit details
Commits on Sep 14, 2017
-
Allow data lists to include 0 or '' (falsey items)
Summary: Fixing #13578 <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) Closes #15419 Reviewed By: sahrens Differential Revision: D5795844 Pulled By: tomasreimers fbshipit-source-id: 4cdf97a2f5e83e38f4e12af771b512e7dddd212a
Configuration menu - View commit details
-
Copy full SHA for ae1a4f0 - Browse repository at this point
Copy the full SHA ae1a4f0View commit details -
Access AppState constants on main thread
Summary: iOS 11 now requires this to be accessed on the main thread. I think this is causing tests to fail, as the Main Thread Checker is turned on there. Reviewed By: javache Differential Revision: D5826570 fbshipit-source-id: 6acb7174c756a2ad657602f14c666f71b1ee8fe9
Configuration menu - View commit details
-
Copy full SHA for e8c83d1 - Browse repository at this point
Copy the full SHA e8c83d1View commit details -
Fix build errors exposed by building against clang 5.0
Reviewed By: rachit-siamwalla Differential Revision: D5828898 fbshipit-source-id: 23fa587bcd1d1b6c612cc816f1aa7b03da0c187d
Configuration menu - View commit details
-
Copy full SHA for e846a9f - Browse repository at this point
Copy the full SHA e846a9fView commit details -
Refactor how symlinks are discovered in local-cli, support scoped mod…
…ules Summary: This PR refactors the symlink finding logic in local-cli in order to support nested symlinked modules as well as symlinked scoped NPM modules. Run tests, or try project with `npm link`'ed or `yarn link`'ed dependencies. Closes #15776 Reviewed By: cpojer Differential Revision: D5823008 Pulled By: jeanlauliac fbshipit-source-id: f2daeceef37bed2f8a136a0a5918730f9832884c
Configuration menu - View commit details
-
Copy full SHA for 39f83c4 - Browse repository at this point
Copy the full SHA 39f83c4View commit details -
Upgrade babel-plugin-react-transform to v3.x
Summary: babel-plugin-react-transform@3 includes support for HMR on `React.PureComponent`: gaearon/babel-plugin-react-transform#106 Reviewed By: davidaurelio Differential Revision: D5814322 fbshipit-source-id: 36e83ffa00f9d4ff079665aec1e8341725811a8e
Configuration menu - View commit details
-
Copy full SHA for f568090 - Browse repository at this point
Copy the full SHA f568090View commit details -
Make <TextInput multiline> default blurOnSubmit to false.
Reviewed By: achen1 Differential Revision: D5830633 fbshipit-source-id: 3d0880656f14cfafa0f15c4341021799f20f40ed
Configuration menu - View commit details
-
Copy full SHA for adb6646 - Browse repository at this point
Copy the full SHA adb6646View commit details -
Fix crash when trying to load photo library assets with nil image url
Summary: This avoids a crash when we try to load a PHAsset with nil image url. Specifically, the following condition evaluates to true when `imageURL` is nil: ```objc if ([imageURL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame) { assetID = [imageURL absoluteString]; results = [PHAsset fetchAssetsWithALAssetURLs:@[imageURL] options:nil]; } ``` The crash will be "attempt to insert nil object from objects[0]" when we build the `@[imageURL]` array literal. We've seen this emerge as a very common crash among Expo users, so I wanted to at least provide a clear error message instead of terminating the app. Load an image from the photo library with a nil request url. Closes #15952 Differential Revision: D5835219 Pulled By: ericnakagawa fbshipit-source-id: 7be00a15e674a0905cf5c27c526ce9085d1b308f
Configuration menu - View commit details
-
Copy full SHA for 7fab093 - Browse repository at this point
Copy the full SHA 7fab093View commit details -
Reviewed By: achen1 Differential Revision: D5740438 fbshipit-source-id: eca6160e0ff9089e1f70ead0f2269ce152258c19
Configuration menu - View commit details
-
Copy full SHA for 6c2c2ec - Browse repository at this point
Copy the full SHA 6c2c2ecView commit details
Commits on Sep 15, 2017
-
ReactNative sync (c3718c4...abce30f): the one about the Prepack optim…
…izations Reviewed By: sophiebits Differential Revision: D5626312 fbshipit-source-id: f8158ccb14f991b681fba34fb23933042266939d
Configuration menu - View commit details
-
Copy full SHA for e9780bd - Browse repository at this point
Copy the full SHA e9780bdView commit details -
Native view manager event types exposed to JS via view config
Differential Revision: D5814210 fbshipit-source-id: 41291f0d6b39af77f66173f6a699d88f9f4ccc74
Configuration menu - View commit details
-
Copy full SHA for 75c94a8 - Browse repository at this point
Copy the full SHA 75c94a8View commit details -
Bump metro-bundler dependency to 0.17
Reviewed By: davidaurelio Differential Revision: D5834180 fbshipit-source-id: 121efc7000bff7aff121d44e6b0b8eed1d4e81ae
Configuration menu - View commit details
-
Copy full SHA for 327a0dd - Browse repository at this point
Copy the full SHA 327a0ddView commit details -
Use the Config type from Metro
Reviewed By: davidaurelio Differential Revision: D5832633 fbshipit-source-id: 8e4e0e6a2907e485a5627c87161af2d0672b4f56
Configuration menu - View commit details
-
Copy full SHA for 2f78d19 - Browse repository at this point
Copy the full SHA 2f78d19View commit details -
Move destroy threads in catalystinstance off the UI thread
Reviewed By: cwdick Differential Revision: D5842135 fbshipit-source-id: e9c44c4129d4d10da8781798df121f5c676766f8
Configuration menu - View commit details
-
Copy full SHA for cf2ef84 - Browse repository at this point
Copy the full SHA cf2ef84View commit details -
Zero out all fields in YGZeroOutLayoutRecursivly using memset
Reviewed By: emilsjolander Differential Revision: D5842351 fbshipit-source-id: d2c2b6f829588a200525b7ccbdb63003cb4dcc4e
Configuration menu - View commit details
-
Copy full SHA for d0f36d7 - Browse repository at this point
Copy the full SHA d0f36d7View commit details -
Bump react/jsx-no-undef (undefined require) from warning to error
Reviewed By: weicool Differential Revision: D5843154 fbshipit-source-id: 0729cb19e3b3664a235320e908af51b2f56cc4ae
Configuration menu - View commit details
-
Copy full SHA for 2cb87df - Browse repository at this point
Copy the full SHA 2cb87dfView commit details -
Added Flow types for React Native host components
Reviewed By: calebmer Differential Revision: D5844473 fbshipit-source-id: 2893e5a5ee58d147a2f7d351143a7ce0eb8eebe3
Configuration menu - View commit details
-
Copy full SHA for 11b4084 - Browse repository at this point
Copy the full SHA 11b4084View commit details -
Re-added global event-type Map to UIManager constants
Reviewed By: sophiebits Differential Revision: D5846806 fbshipit-source-id: 7b0a54bd5a4b877f0c5915f11392ee0d34718dbe
Configuration menu - View commit details
-
Copy full SHA for d1372fa - Browse repository at this point
Copy the full SHA d1372faView commit details
Commits on Sep 18, 2017
-
BREAKING: Removed support of nested content inside <Image> on Android
Summary: Use <ImageBackground> instead. Reviewed By: yungsters Differential Revision: D5190170 fbshipit-source-id: 29acf99db9a31351dbfe8eeefa61abd439f8618c
Configuration menu - View commit details
-
Copy full SHA for 3ff463f - Browse repository at this point
Copy the full SHA 3ff463fView commit details -
Text to Spannable conversion is now using PRIORITY flag to enforce th…
…e order of spans Summary: When we convert nested <Text> components to Spannable object we must enforce the order of spans somehow, otherwise we will have Spannable object with unpredictable order of spans, which will produce unpredictalbe text layout. We can do it only using `Spannable.SPAN_PRIORITY` feature because Spannable objects do not maintain the order of spans internally. We also have to fix this to implement autoexpandable <TextInput>. Reviewed By: achen1 Differential Revision: D5811172 fbshipit-source-id: 5bc68b869e58aba27d6986581af9fe3343d116a7
Configuration menu - View commit details
-
Copy full SHA for 7efd4fa - Browse repository at this point
Copy the full SHA 7efd4faView commit details -
use
uniqBy
for iteratee supportSummary: I noticed `uniq` does not take a second parameter the way it's being used here. I think the function what was intended is [uniqBy](https://lodash.com/docs/4.17.4#uniqBy) Closes #15615 Differential Revision: D5852155 Pulled By: hramos fbshipit-source-id: 892d0bf7f24d30c24620350f698ffb416907ccc5
Configuration menu - View commit details
-
Copy full SHA for df8d0d1 - Browse repository at this point
Copy the full SHA df8d0d1View commit details -
re #15915 HeadlessJsTaskService is expected to run on UI thread
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Headless tasks are required to run in the main thread, however due to the nature of the React context creation flow, the handler may be returned outside of the main thread, causing the HeadlessJsTaskContext to throw an exception. Swipe out the app. send push notification from a server that starts a HeadlessJsTaskService Closes #15940 Differential Revision: D5852448 Pulled By: foghina fbshipit-source-id: 54c58a1eb7434dd5de5c39c28f6e068ed15ead9d
Configuration menu - View commit details
-
Copy full SHA for 7953707 - Browse repository at this point
Copy the full SHA 7953707View commit details -
Refactored executeApplicationScript in RCTCxxBridge
Reviewed By: dcaspi Differential Revision: D5850957 fbshipit-source-id: d2cacfd99fd7ffca70b0dcf0bf252ea160268c05
Configuration menu - View commit details
-
Copy full SHA for 6e28179 - Browse repository at this point
Copy the full SHA 6e28179View commit details -
Force local builds to use regular JS bundles
Reviewed By: dcaspi Differential Revision: D5824552 fbshipit-source-id: a435fc0ad5b43a8bd3c6a873a4147c4d92190f4e
Configuration menu - View commit details
-
Copy full SHA for 6b733a4 - Browse repository at this point
Copy the full SHA 6b733a4View commit details -
Using mutex inside RCTUIManagerObserverCoordinator instead of GCD
Reviewed By: javache Differential Revision: D5843832 fbshipit-source-id: f4051755a5de83431f8bed1b765b5d8118b5ab88
Configuration menu - View commit details
-
Copy full SHA for 38c8b6d - Browse repository at this point
Copy the full SHA 38c8b6dView commit details -
Fixing clowntown in RCTUIManager
Reviewed By: mmmulani Differential Revision: D5851596 fbshipit-source-id: 952dc8af4ee2af4522725873187b6281b62642cc
Configuration menu - View commit details
-
Copy full SHA for d7f6208 - Browse repository at this point
Copy the full SHA d7f6208View commit details -
Using
indexOfObjectIdenticalTo
instead ofindexOfObject
in RCTUIM……anager Summary: This should be much more performant (and it better illustrates the intension of the code). The fix was suggested by Adlai-Holler. Reviewed By: mmmulani Differential Revision: D5851595 fbshipit-source-id: 45d172a5fa796549c6dcea8f35c5cbb2a4c2d2e0
Configuration menu - View commit details
-
Copy full SHA for 9d9e250 - Browse repository at this point
Copy the full SHA 9d9e250View commit details -
React sync for revisions abce30f...b5ac963
Reviewed By: sophiebits Differential Revision: D5853012 fbshipit-source-id: d0ebf12d2c801dc3e232fe18f9cc25e477812350
Configuration menu - View commit details
-
Copy full SHA for 8bf8b21 - Browse repository at this point
Copy the full SHA 8bf8b21View commit details
Commits on Sep 19, 2017
-
Base class for all object private data passed to JSC
Reviewed By: amnn Differential Revision: D5761937 fbshipit-source-id: de88cf8b959fc855c3c0786f817bb6032491c819
Configuration menu - View commit details
-
Copy full SHA for d6c519b - Browse repository at this point
Copy the full SHA d6c519bView commit details -
More useful utilities in jschelpers
Reviewed By: mhorowitz Differential Revision: D5785204 fbshipit-source-id: 4c5240f24c6a69bb781896d3af32d4d16fc2387c
Configuration menu - View commit details
-
Copy full SHA for 0ee502d - Browse repository at this point
Copy the full SHA 0ee502dView commit details -
Add getter for JS Executor Factory
Reviewed By: mhorowitz Differential Revision: D5857012 fbshipit-source-id: 8c9fc0095c512325968234f48d6728b63d61913d
Configuration menu - View commit details
-
Copy full SHA for e764361 - Browse repository at this point
Copy the full SHA e764361View commit details -
Reviewed By: AaaChiuuu Differential Revision: D5855139 fbshipit-source-id: 3837769a4da90d9752de75669c6395fabcd3b18b
Configuration menu - View commit details
-
Copy full SHA for 9e37352 - Browse repository at this point
Copy the full SHA 9e37352View commit details -
Fixed runtime error with ProgressBarAndroid
Reviewed By: yungsters Differential Revision: D5857305 fbshipit-source-id: 2fc20a848fa4dce5c1ac3fb7e986536618e25548
7Configuration menu - View commit details
-
Copy full SHA for ccddbf8 - Browse repository at this point
Copy the full SHA ccddbf8View commit details -
Reviewed By: shergin Differential Revision: D5854859 fbshipit-source-id: 96d4ced9f5481ae1df8741f9d09da4bc939e8ed8
Configuration menu - View commit details
-
Copy full SHA for 01bcbd4 - Browse repository at this point
Copy the full SHA 01bcbd4View commit details -
Reviewed By: achen1 Differential Revision: D5855613 fbshipit-source-id: 2eac7ba6a9d95f6cd3a58a1df4ec0b170f34d6ed
Configuration menu - View commit details
-
Copy full SHA for 87a1dc4 - Browse repository at this point
Copy the full SHA 87a1dc4View commit details -
Fix setBackground for Android sdk version 15 and below
Reviewed By: achen1 Differential Revision: D5854430 fbshipit-source-id: 1276f3d7e94b757f9a9dd412a2ef8b72e8427ffb
3Configuration menu - View commit details
-
Copy full SHA for 5180995 - Browse repository at this point
Copy the full SHA 5180995View commit details -
Untangle NativeAnimatedNodesManager from UIManager internals.
Reviewed By: AaaChiuuu Differential Revision: D5861523 fbshipit-source-id: 39eb79b91d4d5e2295d03369f1be585ae7836c75
Configuration menu - View commit details
-
Copy full SHA for 4fc9e20 - Browse repository at this point
Copy the full SHA 4fc9e20View commit details -
Reviewed By: achen1 Differential Revision: D5740501 fbshipit-source-id: 3a88cd95d3a58aac24968e577f4eb3096d47d4ec
Configuration menu - View commit details
-
Copy full SHA for 12f123d - Browse repository at this point
Copy the full SHA 12f123dView commit details -
Document Android native communication
Summary: Native communication is documented for iOS but not Android. Typically pages in Guides (IOS) and Guides (Android) share a common structure/content but provide language specific examples. I followed this pattern with the Android native communication documentation. It is missing some content that the iOS documentation contains, such as the layout computation flow. But provides a solid base for future efforts. Ran local instance of React Native website. Went to http://localhost:8079 and read through the new page (react-native/docs/communication-android.html). Also tested links two/from the page. As a result of this link testing, I updated the Native Modules Android documentation to link to the Apple TV documentation, as it is now the previous page on the navigation sidebar. Closes #14316 Differential Revision: D5865137 Pulled By: hramos fbshipit-source-id: 10ec7d2b08667e70bc38576ecc56da457859e8b1
Configuration menu - View commit details
-
Copy full SHA for a43a988 - Browse repository at this point
Copy the full SHA a43a988View commit details -
Fixed issue with measuring text with NaN width
Summary: Looks like `-[NSLayoutManager ensureLayoutForTextContainer:textContainer]` has a bug that cause infinite loop inside this method during measuring some special characters AND when specified `width` equals NaN (which is useless anyways). So, we cover this case in this diff. Reviewed By: javache Differential Revision: D5859767 fbshipit-source-id: 58a5910f21f282bf5b82494916b5b02ad72d357f
Configuration menu - View commit details
-
Copy full SHA for 6b11259 - Browse repository at this point
Copy the full SHA 6b11259View commit details -
add node/npm version to ISSUE_TEMPLATE.md
Summary: A huge number of Issues are opened with some key information about node/npm versions missing. Adding this information as a required part of the ISSUE_TEMPLATE may help issues get closed faster. Once merged in, check ISSUE_TEMPLATE by opening new issue, verify new line is there. Closes #14422 Differential Revision: D5865411 Pulled By: hramos fbshipit-source-id: 70e776c8635de38fb149471656e6d260f9eb2537
Configuration menu - View commit details
-
Copy full SHA for e99fbfc - Browse repository at this point
Copy the full SHA e99fbfcView commit details -
Revert faulty change to HelloWorld demo in docs
Summary: Related to commit/diff: 6e99e31#diff-692279cda23c48738b9688454811448a The above change breaks "HelloWorld" demo in docs, as you can see at the bottom of the below screenshot: ![image](https://user-images.githubusercontent.com/5363847/30427914-9477d4ee-9949-11e7-8be6-3d6990d6e267.png) This pull request reverts things just enough to get the demo working correctly again. I'm new to react-native so I'm not sure if there is another (read: better) solution but by accepting this pull request it would prevent noobs like myself from falling at the first hurdle! Closes #15947 Differential Revision: D5866110 Pulled By: hramos fbshipit-source-id: a453e4373b8af528e3ef2fa6a5a029ff398b0398
5Configuration menu - View commit details
-
Copy full SHA for c25a3db - Browse repository at this point
Copy the full SHA c25a3dbView commit details -
Fixed package.json peerDependencies
Reviewed By: sophiebits Differential Revision: D5860751 fbshipit-source-id: 634ccf22d40bf80eabed467cb1c874f5b02c4f8d
Configuration menu - View commit details
-
Copy full SHA for ed77dbb - Browse repository at this point
Copy the full SHA ed77dbbView commit details -
Add props for overriding native component
Summary: Opening a new PR for #10946 (see discussion there). This PR builds upon #14775 (iOS ViewManager inheritance) and #14261 (more extensible Android WebView). **Motivation** When `WebView.android.js` and `WebView.ios.js` use `requireNativeComponent`, they are hard-coded to require `RCTWebView`. This means if you want to re-use the same JS-logic, but require a custom native WebView-implementation, you have to duplicate the entire JS-code files. The same is true if you want to pass through any custom events or props, which you want to set on the custom native `WebView`. What I'm trying to solve with this PR is to able to extend native WebView logic, and being able to re-use and extend existing WebView JS-logic. This is done by adding a new `nativeConfig` prop on WebView. I've also moved the extra `requireNativeComponent` config to `WebView.extraNativeComponentConfig` for easier re-use. **Test plan** jacobp100 has been kind enough to help me with docs for this new feature. So that is part of the PR and can be read for some information. I've also created an example app which demonstrates how to use this functionality: https://github.com/cbrevik/webview-native-config-example If you've implemented the native side as in the example repo above, it should be fairly easy to use from JavaScript like this: ```javascript import React, { Component, PropTypes } from 'react'; import { WebView, requireNativeComponent, NativeModules } from 'react-native'; const { CustomWebViewManager } = NativeModules; export default class CustomWebView extends Component { static propTypes = { ...WebView.propTypes, finalUrl: PropTypes.string, onNavigationCompleted: PropTypes.func, }; _onNavigationCompleted = (event) => { const { onNavigationCompleted } = this.props; onNavigationCompleted && onNavigationCompleted(event); } render() { return ( <WebView {...this.props} nativeConfig={{ component: RCTCustomWebView, props: { finalUrl: this.props.finalUrl, onNavigationCompleted: this._onNavigationCompleted, }, viewManager: CustomWebViewManager }} /> ); } } const RCTCustomWebView = requireNativeComponent( 'RCTCustomWebView', CustomWebView, WebView.extraNativeComponentConfig ); ``` As you see, you require the custom native implementation at the bottom, and send in that along with any custom props with the `nativeConfig` prop on the `WebView`. You also send in the `viewManager` since iOS requires that for `startLoadWithResult`. **Discussion** As noted in the original PR, this could in principle be done with more React Native components, to make it easier for the community to re-use and extend native components. Closes #15016 Differential Revision: D5701280 Pulled By: hramos fbshipit-source-id: 6c3702654339b037ee81d190c623b8857550e972
Configuration menu - View commit details
-
Copy full SHA for f426a83 - Browse repository at this point
Copy the full SHA f426a83View commit details -
Fix Flow errors in ListViewData source.
Differential Revision: D5839414 fbshipit-source-id: 7a0c7b3d27be728c74e08d3a8209deb3ca68dd63
1Configuration menu - View commit details
-
Copy full SHA for 11963d8 - Browse repository at this point
Copy the full SHA 11963d8View commit details
Commits on Sep 20, 2017
-
Fix Content-Type header checking of React/RCTJavascriptLoader.mm #15791
Configuration menu - View commit details
-
Copy full SHA for 3ae45d5 - Browse repository at this point
Copy the full SHA 3ae45d5View commit details -
Synchronize all relay packages
Reviewed By: mjmahone Differential Revision: D5842774 fbshipit-source-id: 40c57619901e15b0baa62c59837fc887c100652b
Configuration menu - View commit details
-
Copy full SHA for 628cbe1 - Browse repository at this point
Copy the full SHA 628cbe1View commit details -
Detangle destroy and create accesses
Differential Revision: D5823786 fbshipit-source-id: d6a6e29b856361a6b1d5ab48397607a844b5ab53
Configuration menu - View commit details
-
Copy full SHA for 6334ed2 - Browse repository at this point
Copy the full SHA 6334ed2View commit details -
Add interface for ReactShadowNode
Reviewed By: AaaChiuuu Differential Revision: D5871546 fbshipit-source-id: 7c338fe3b747a79377a54867c789028d221b3dd5
Configuration menu - View commit details
-
Copy full SHA for 08befb7 - Browse repository at this point
Copy the full SHA 08befb7View commit details -
Reviewed By: achen1 Differential Revision: D5740540 fbshipit-source-id: 9989424812fdcfd0a54c2ccf1e973aa7cc2a1f67
Configuration menu - View commit details
-
Copy full SHA for 565a241 - Browse repository at this point
Copy the full SHA 565a241View commit details -
Fix shrinking in non strech alignments
Summary: This fixes shrinking of elements which are in a non stretch alignment Fixes #633 Closes facebook/yoga#634 Differential Revision: D5874862 Pulled By: emilsjolander fbshipit-source-id: 1426aa6b60f6ba42c2be702e6f24cea935ab7acb
Configuration menu - View commit details
-
Copy full SHA for aa8eb80 - Browse repository at this point
Copy the full SHA aa8eb80View commit details -
Fix onSubmitEditing dispatch behavior with blurOnSubmit/multiline com…
…binations. Summary: Fixes #15863 on master. Behavior of `onSubmitEditing` is now consistent between iOS and Android. Tapping the submit button in a TextInput dispatches the event precisely when doing so does not make a newline (when blurOnSubmit is true or multiline is false). 1. Run this app on iOS and Android: ``` // flow import React, { Component } from 'react'; import { StyleSheet, TextInput, View } from 'react-native'; type State = { toggled: boolean }; type Props = { blurOnSubmit: boolean, multiline: boolean }; class ToggleColorInput extends Component<Props, State> { state: State = { toggled: false }; props: Props; toggle = () => { this.setState({ toggled: !this.state.toggled }); } render() { return ( <TextInput blurOnSubmit={this.props.blurOnSubmit} multiline={this.props.multiline} onSubmitEditing={this.toggle} style={[styles.textInput, {backgroundColor: this.state.toggled ? 'blue' : 'azure'}]} underlineColorAndroid='transparent' /> ) } } export default class App extends Component<{}> { render() { return ( <View> <ToggleColorInput blurOnSubmit={true} multiline={true} /> <ToggleColorInput blurOnSubmit={true} multiline={false} /> <ToggleColorInput blurOnSubmit={false} multiline={true} /> <ToggleColorInput blurOnSubmit={false} multiline={false} /> </View> ); } } const styles = StyleSheet.create({ textInput: { height: 75, borderWidth: 1, borderColor: 'black' } }); ``` 2. You see four TextInputs, with each combination of the `blurOnSubmit` and `multiline` properties. For each TextInput, type some text and tap the submit button. 3. The TextInputs in this test will toggle background color when they emit an `onSubmitEditing` event. Verify the following behavior on each platform: * blurOnSubmit && isMultiline => Submit event emitted, blurred, no newline inserted * blurOnSubmit && !isMultiline => Submit event emitted, blurred * !blurOnSubmit && isMultiline => Submit event emitted, newline inserted * !blurOnSubmit && !isMultiline => Submit event emitted Closes #16040 Differential Revision: D5877401 Pulled By: shergin fbshipit-source-id: 741bcc06d8b69d7025f2cb42dd0bee4fa01cd88e
Configuration menu - View commit details
-
Copy full SHA for 4d54b48 - Browse repository at this point
Copy the full SHA 4d54b48View commit details
Commits on Sep 21, 2017
-
Add closed-form damped harmonic oscillator algorithm to Animated.spring
Summary: As I was working on mimicking iOS animations for my ongoing work with `react-navigation`, one task I had was to match the "push from right" animation that is common in UINavigationController. I was able to grab the exact animation values for this animation with some LLDB magic, and found that the screen is animated using a `CASpringAnimation` with the parameters: - stiffness: 1000 - damping: 500 - mass: 3 After spending a considerable amount of time attempting to replicate the spring created with these values by CASpringAnimation by specifying values for tension and friction in the current `Animated.spring` implementation, I was unable to come up with mathematically equivalent values that could replicate the spring _exactly_. After doing some research, I ended up disassembling the QuartzCore framework, reading the assembly, and determined that Apple's implementation of `CASpringAnimation` does not use an integrated, numerical animation model as we do in Animated.spring, but instead solved for the closed form of the equations that govern damped harmonic oscillation (the differential equations themselves are [here](https://en.wikipedia.org/wiki/Harmonic_oscillator#Damped_harmonic_oscillator), and a paper describing the math to arrive at the closed-form solution to the second-order ODE that describes the DHO is [here](http://planetmath.org/sites/default/files/texpdf/39745.pdf)). Though we can get the currently implemented RK4 integration close by tweaking some values, it is, the current model is at it's core, an approximation. It seemed that if I wanted to implement the `CASpringAnimation` behavior _exactly_, I needed to implement the analytical model (as is implemented in `CASpringAnimation`) in `Animated`. We add three new optional parameters to `Animated.spring` (to both the JS and native implementations): - `stiffness`, a value describing the spring's stiffness coefficient - `damping`, a value defining how the spring's motion should be damped due to the forces of friction (technically called the _viscous damping coefficient_). - `mass`, a value describing the mass of the object attached to the end of the simulated spring Just like if a developer were to specify `bounciness`/`speed` and `tension`/`friction` in the same config, specifying any of these new parameters while also specifying the aforementioned config values will cause an error to be thrown. ~Defaults for `Animated.spring` across all three implementations (JS/iOS/Android) stay the same, so this is intended to be *a non-breaking change*.~ ~If `stiffness`, `damping`, or `mass` are provided in the config, we switch to animating the spring with the new damped harmonic oscillator model (`DHO` as described in the code).~ We replace the old RK4 integration implementation with our new analytic implementation. Tension/friction nicely correspond directly to stiffness/damping with the mass of the spring locked at 1. This is intended to be *a non-breaking change*, but there may be very slight differences in people's springs (maybe not even noticeable to the naked eye), given the fact that this implementation is more accurate. The DHO animation algorithm will calculate the _position_ of the spring at time _t_ explicitly and in an analytical fashion, and use this calculation to update the animation's value. It will also analytically calculate the velocity at time _t_, so as to allow animated value tracking to continue to work as expected. Also, docs have been updated to cover the new configuration options (and also I added docs for Animated configuration options that were missing, such as `restDisplacementThreshold`, etc). Run tests. Run "Animated Gratuitous App" and "NativeAnimation" example in RNTester. Closes #15322 Differential Revision: D5794791 Pulled By: hramos fbshipit-source-id: 58ed9e134a097e321c85c417a142576f6a8952f8
Configuration menu - View commit details
-
Copy full SHA for 26133be - Browse repository at this point
Copy the full SHA 26133beView commit details -
Revert D5874862: [yoga][PR] Fix shrinking in non strech alignments
Differential Revision: D5874862 fbshipit-source-id: 24517d26b18c11fb9f75c6d3b5faae360711ea9e
Configuration menu - View commit details
-
Copy full SHA for 244045e - Browse repository at this point
Copy the full SHA 244045eView commit details -
Improve formatting of YogaNode.print() on Android
Reviewed By: emilsjolander Differential Revision: D5842889 fbshipit-source-id: 8ecc829dc43614934c47fd3a68317259e403325a
Configuration menu - View commit details
-
Copy full SHA for 67d0cc5 - Browse repository at this point
Copy the full SHA 67d0cc5View commit details -
Reviewed By: cwdick Differential Revision: D5874529 fbshipit-source-id: 0ee9d740b4445419e3143942514475751763520d
Configuration menu - View commit details
-
Copy full SHA for b9be9a0 - Browse repository at this point
Copy the full SHA b9be9a0View commit details -
Allow "nativeRequire" to accept "bundleId" and "moduleId" values
Differential Revision: D5850960 fbshipit-source-id: 4d7aa0ed7542181861649a2089d90c3cf98723e9
Configuration menu - View commit details
-
Copy full SHA for da2ea26 - Browse repository at this point
Copy the full SHA da2ea26View commit details -
Initial implementation of multiple RAM bundles registry
Differential Revision: D5850963 fbshipit-source-id: e1bd6d74953872d38e73a20f6d054905a7e4c80c
Configuration menu - View commit details
-
Copy full SHA for 2f952fb - Browse repository at this point
Copy the full SHA 2f952fbView commit details -
Configure JSExector with BundleRegistry instead of JSModulesUnbundle.
Differential Revision: D5850968 fbshipit-source-id: e5e7ad92c2347c2641551fcf820f061ffde5fed6
Configuration menu - View commit details
-
Copy full SHA for 7982191 - Browse repository at this point
Copy the full SHA 7982191View commit details -
Added iOS support for loading multiple RAM bundles
Differential Revision: D5850970 fbshipit-source-id: 88ab6fe3822f1bc4195007f8ec83177a84c27569
Configuration menu - View commit details
-
Copy full SHA for 1aeb767 - Browse repository at this point
Copy the full SHA 1aeb767View commit details -
Update HeadlessJSAndroid.md explaining parameters
Summary: HeadlessJsTaskConfig parameters can be unclear, so I added one more parameter that was left set by default and the respective comments. Closes #16054 Differential Revision: D5881373 Pulled By: hramos fbshipit-source-id: 3d271f73921417d82e3a2c7a1aaabe92aef7ec69
Configuration menu - View commit details
-
Copy full SHA for f25233b - Browse repository at this point
Copy the full SHA f25233bView commit details -
Improved documentation for ActionSheetIOS.js
Summary: This change improves the documentation for `ActionSheetIOS.js`. It's a bit skimpy as is. Closes #16030 Differential Revision: D5882446 Pulled By: hramos fbshipit-source-id: b59ce299a9142ebf015ed674c59e1e435deb759a
Configuration menu - View commit details
-
Copy full SHA for 5317b68 - Browse repository at this point
Copy the full SHA 5317b68View commit details -
Add the import statement to examples
Summary: As a new user it took me a while to figure out you can import these examples directly. The import statement completes the example for new users like me who have no idea these components can be imported. It is a very important piece of information and it is hard to find otherwise. I think this should be added to all the other component examples as well. Documentation only. Closes #15501 Differential Revision: D5882436 Pulled By: hramos fbshipit-source-id: 2da0fe4c7c41e2fdb6b13a945460e17e16442d62
Configuration menu - View commit details
-
Copy full SHA for 70558b9 - Browse repository at this point
Copy the full SHA 70558b9View commit details -
Reviewed By: fkgozali Differential Revision: D5881825 fbshipit-source-id: 38debe598830c4cc969b5251cfdfd8941ac36e9d
Configuration menu - View commit details
-
Copy full SHA for 6ce69dc - Browse repository at this point
Copy the full SHA 6ce69dcView commit details -
Silence annoying logs in iOS 11
Summary: Apple changed what messages get logged when a web socket connection fails. Lets hide them to make life better for engineers. Reviewed By: javache Differential Revision: D5879306 fbshipit-source-id: cde06405b4af251159269218bf922916a79ac840
Configuration menu - View commit details
-
Copy full SHA for f01c73d - Browse repository at this point
Copy the full SHA f01c73dView commit details -
Summary: Following the migration guide. Let's see what happens here. Closes #14955 Differential Revision: D5877682 Pulled By: hramos fbshipit-source-id: 2a40560120b5d8d28bc6c52cc5e5916fd1bba336
Configuration menu - View commit details
-
Copy full SHA for 8fa9984 - Browse repository at this point
Copy the full SHA 8fa9984View commit details -
Add rigdern to the issue task force
Summary: I've helped contribute around [70 pull requests](https://github.com/facebook/react-native/pulls/rigdern) to React Native and would like to help triage issues. Adam Comella Microsoft Corp. Closes #16059 Differential Revision: D5884339 Pulled By: hramos fbshipit-source-id: ba7468fd8e2a5e8f3f054bcafa652a7988f10a78
Configuration menu - View commit details
-
Copy full SHA for dd87db3 - Browse repository at this point
Copy the full SHA dd87db3View commit details -
Summary: Adds an onDismiss so that navigation events can be chained to the dismissing of a modal. Reviewed By: sahrens Differential Revision: D5852953 fbshipit-source-id: a86e36fdd5b0b206c2dd9fa248e2a88da22efa31
Configuration menu - View commit details
-
Copy full SHA for a389ffb - Browse repository at this point
Copy the full SHA a389ffbView commit details
Commits on Sep 22, 2017
-
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Adding example on components section with [react-native-web-player](https://github.com/dabbott/react-native-web-player) - ActivityIndicator - TouchableOpacity - TouchableHighlight Screenshot on http://localhost:8079/react-native/docs/activityindicator.html ![react-native-activityindicator](https://user-images.githubusercontent.com/13135332/30432801-adca0982-9988-11e7-8e70-94ad9e42ea43.png) Screenshot on http://localhost:8079/react-native/docs/touchableopacity.html ![react-native-touchableopacity](https://user-images.githubusercontent.com/13135332/30432718-80570554-9988-11e7-9c81-15ab98327fed.png) Screenshot on http://localhost:8079/react-native/docs/touchablehighlight.html ![react-native-touchablehighlight](https://user-images.githubusercontent.com/13135332/30432733-8290fbb8-9988-11e7-94a1-86c3166e544d.png) Closes #15950 Differential Revision: D5881366 Pulled By: hramos fbshipit-source-id: 2926071723defedf9ed5cb1b1128204256c71dd9
Configuration menu - View commit details
-
Copy full SHA for f7f3473 - Browse repository at this point
Copy the full SHA f7f3473View commit details -
Improve DX for FBReactKitIntegrationTests
Summary: - Enable logging so `console.log` shows up in Xcode console (and CI?) - Allow loading from bundler for rapid JS iteration. - Add option to enable JS debugging, although it's a little ghetto. Reviewed By: mmmulani Differential Revision: D5869085 fbshipit-source-id: 9c4831859f1491f7f75786f730d8549d69623888
Configuration menu - View commit details
-
Copy full SHA for af2e3fe - Browse repository at this point
Copy the full SHA af2e3feView commit details -
Revert D5850970: Added iOS support for loading multiple RAM bundles
Differential Revision: D5850970 fbshipit-source-id: 8b0f9bc296ac2944b8b7657a4119b6787d810a2c
Configuration menu - View commit details
-
Copy full SHA for 526fd6b - Browse repository at this point
Copy the full SHA 526fd6bView commit details -
Revert D5850968: Configure JSExector with BundleRegistry instead of J…
…SModulesUnbundle. Differential Revision: D5850968 fbshipit-source-id: f4c9dc8d5f14cdd32195463e8786242e708770e9
Configuration menu - View commit details
-
Copy full SHA for 0aa1293 - Browse repository at this point
Copy the full SHA 0aa1293View commit details -
react-native link
andreact-native unlink
update.Summary: 1. Fix bug: Android project do not delete font files when run `react-native unlink`. 2. Add feature, link images to iOS project when run `react-native link`. Closes #14801 Differential Revision: D5890051 Pulled By: hramos fbshipit-source-id: 28223d181ac5ed51d70df29a56eb56b2cce9aecb
Configuration menu - View commit details
-
Copy full SHA for c1058b1 - Browse repository at this point
Copy the full SHA c1058b1View commit details -
Add locking around CatalystInstance.getJavaScriptContext()
Reviewed By: kathryngray Differential Revision: D5861693 fbshipit-source-id: 226ff15622d5e1a8ae3ad4c63f1434bd95c1fa21
Configuration menu - View commit details
-
Copy full SHA for e9aab0d - Browse repository at this point
Copy the full SHA e9aab0dView commit details -
Configure JSExector with BundleRegistry instead of JSModulesUnbundle
Differential Revision: D5890458 fbshipit-source-id: 968be95786ffbf53aa98928d4d3e3bd52a84b3dc
Configuration menu - View commit details
-
Copy full SHA for 7d11573 - Browse repository at this point
Copy the full SHA 7d11573View commit details -
Added iOS support for loading multiple RAM bundles
Differential Revision: D5890466 fbshipit-source-id: e7805f90a7c446f5f75427c3fadcd133a3f7ad18
Configuration menu - View commit details
-
Copy full SHA for 7d2021e - Browse repository at this point
Copy the full SHA 7d2021eView commit details -
Give complex FlatList example more motivation
Summary: Previously, the example MyListItem never referenced the selected prop, leaving ambiguity about the intention of the demo. By adding a concrete implementation with coloring based on the selected prop, we can see that this is a demo of a multi-select list for batch actions instead of, say, a click-to-navigate nested list. Here is a working Snack demo for future reference: https://snack.expo.io/BkRMRTGB- References #14872 <!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. In other words, a test plan is *required*. Bonus points for screenshots and videos! Please read the Contribution Guidelines at https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md to learn more about contributing to React Native. Happy contributing! --> Closes #14957 Differential Revision: D5892186 Pulled By: sahrens fbshipit-source-id: c7b46b5f6eae8f36bd4bda7cbbd354cc22108b42
Configuration menu - View commit details
-
Copy full SHA for 82b4b9b - Browse repository at this point
Copy the full SHA 82b4b9bView commit details -
Deprecate older API uses of
prebuilt_cxx_library
Reviewed By: ttsugriy Differential Revision: D5878523 fbshipit-source-id: 2c8c1fd1d19597ff7459bbd527c89573520db74b
Configuration menu - View commit details
-
Copy full SHA for 49359e8 - Browse repository at this point
Copy the full SHA 49359e8View commit details
Commits on Sep 23, 2017
-
Avoid oversending modalDismissed event
Reviewed By: shergin Differential Revision: D5895366 fbshipit-source-id: 6d1ca424d2d43fadb48354a1cbad94714448a380
Configuration menu - View commit details
-
Copy full SHA for 9bf936c - Browse repository at this point
Copy the full SHA 9bf936cView commit details
Commits on Sep 24, 2017
-
Adding TLSv1 support for custom SSL socket factory
Summary: This problem tries to solve issue #14244 Implemented a fetch request to a TLSv1 server. It now successfully resolves TLS handshake. Tested same fetch to TLSv1.2 server and still successfully resolves TLS handshake. Closes #14245 Differential Revision: D5898689 Pulled By: shergin fbshipit-source-id: 8766ebe6909443367651ab868aa5ff62747cd906
Configuration menu - View commit details
-
Copy full SHA for 0818f3b - Browse repository at this point
Copy the full SHA 0818f3bView commit details -
Create 2017-09-21-react-native-monthly-4.md
Summary: Closes #16056 Differential Revision: D5896471 Pulled By: hramos fbshipit-source-id: e3327e4897c04e13459a4b6991e64d67f546257c
Configuration menu - View commit details
-
Copy full SHA for e5d4d49 - Browse repository at this point
Copy the full SHA e5d4d49View commit details
Commits on Sep 25, 2017
-
Introducting
-[UIManager.setLocalData:forView:]
, the way to provide…… environmental data to ShadowView Summary: In some cases we need a way to specify some environmental data to shadow view to improve layout (or do something similar), so `localData` serves these needs. For example, any stateful embedded native views may benefit from this. Have in mind that this data is not supposed to interfere with the state of the shadow view. Reviewed By: mmmulani Differential Revision: D5884711 fbshipit-source-id: f0bf66e4608894ec4479b8aca262afcfba6b9f4b
2Configuration menu - View commit details
-
Copy full SHA for 8b4ed94 - Browse repository at this point
Copy the full SHA 8b4ed94View commit details -
Summary: <SafeAreaView> renders nested content and automatically applies paddings reflect the portion of the view that is not covered by navigation bars, tab bars, toolbars, and other ancestor views. Moreover, and most importantly, Safe Area's paddings feflect physical limitation of the screen, such as rounded corners or camera notches (aka sensor housing area on iPhone X). Reviewed By: mmmulani Differential Revision: D5886411 fbshipit-source-id: 7ecc7aa34de8f5527c4e59b0fb4efba3aaea28c8
7Configuration menu - View commit details
-
Copy full SHA for 983b054 - Browse repository at this point
Copy the full SHA 983b054View commit details -
SafeAreaViewExample inside RNTester
Reviewed By: mmmulani Differential Revision: D5888672 fbshipit-source-id: 3de827cbbbb71c9d4bfcc8a1830eea962e707bbe
Configuration menu - View commit details
-
Copy full SHA for 7e5d433 - Browse repository at this point
Copy the full SHA 7e5d433View commit details -
Enabled pretier (@Format) for all files in ReactNative folder
Reviewed By: mmmulani Differential Revision: D5894100 fbshipit-source-id: fae0d02547c0f049fc77f87f209b2ae4f2a298fd
1Configuration menu - View commit details
-
Copy full SHA for 8606e04 - Browse repository at this point
Copy the full SHA 8606e04View commit details -
Using SafeAreaView in YellowBox
Summary: Now it does not clipped on iPhone X. {F74889000} Reviewed By: mmmulani Differential Revision: D5894101 fbshipit-source-id: 5dc91583aa38bb14607421e5afc2ae796e35cce0
Configuration menu - View commit details
-
Copy full SHA for e10f778 - Browse repository at this point
Copy the full SHA e10f778View commit details -
Adding error message including stacktrace
Reviewed By: shergin Differential Revision: D5887667 fbshipit-source-id: 6c1f1ad74db886a01f76171cdcafa97169fef4c3
Configuration menu - View commit details
-
Copy full SHA for eae0241 - Browse repository at this point
Copy the full SHA eae0241View commit details -
Fix format warnings for clang 5.0
Reviewed By: mzlee Differential Revision: D5900751 fbshipit-source-id: 4e9aea068aab3d2d882b8fb103a8828e861da97c
Configuration menu - View commit details
-
Copy full SHA for d005c8c - Browse repository at this point
Copy the full SHA d005c8cView commit details -
Add a hack to fix the Modal component interacting with LayoutAnimation
Summary: As per the comment, <Modal> uses entering/leaving the view hierarchy as a cue to show/hide the modal. By re-adding it, we are causing a bunch of confusion. Reviewed By: shergin Differential Revision: D5893607 fbshipit-source-id: ecd05799751a9bba843998ae93f24fe35edca8b4
Configuration menu - View commit details
-
Copy full SHA for e220878 - Browse repository at this point
Copy the full SHA e220878View commit details -
Revert D5894101: [RN] Using SafeAreaView in YellowBox
Differential Revision: D5894101 fbshipit-source-id: b18b09572c2362d4867ed94a406f56206cdfe6d5
Configuration menu - View commit details
-
Copy full SHA for 5536252 - Browse repository at this point
Copy the full SHA 5536252View commit details -
Summary: Closes #16088 Differential Revision: D5903999 Pulled By: hramos fbshipit-source-id: 707b97d2727fbc5cad82c468ce86a8959ec1c104
Configuration menu - View commit details
-
Copy full SHA for c5d8785 - Browse repository at this point
Copy the full SHA c5d8785View commit details -
Revert D5887667: Adding error message including stacktrace
Differential Revision: D5887667 fbshipit-source-id: 2b3b877317bd4bfddcb5d7886c7399c669d4bbd6
Configuration menu - View commit details
-
Copy full SHA for 3649fce - Browse repository at this point
Copy the full SHA 3649fceView commit details
Commits on Sep 26, 2017
-
Small NaN related optimisation in RCTShadowText
Summary: NaN values can not be compared directly, so we have to use `isnan` function. Reviewed By: mmmulani Differential Revision: D5859761 fbshipit-source-id: bf99a1ae574cd820265bef0c2bd255b194c5dc3c
Configuration menu - View commit details
-
Copy full SHA for 73b596c - Browse repository at this point
Copy the full SHA 73b596cView commit details -
Using modern API to get available size in RCTShadowText
Summary: This is just more correct. Reviewed By: javache Differential Revision: D5860755 fbshipit-source-id: 8ae0e92b2faedfb6dfa02f59f2a63a044bb6912d
Configuration menu - View commit details
-
Copy full SHA for eeda4f3 - Browse repository at this point
Copy the full SHA eeda4f3View commit details -
Summary: As of v1.4.0, a new devtools hook is used that is hosted within `relay-devtools` instead of `relay-runtime`. That allows debugging of production relay apps, and reduces byte size of Relay. As a result, relay-debugger-react-native-runtime and RelayDebugger can be removed. Reviewed By: kassens Differential Revision: D5904296 fbshipit-source-id: 2b215f5a25ecb2922b00cdf86f7d31415d8d1328
Configuration menu - View commit details
-
Copy full SHA for bd70f3a - Browse repository at this point
Copy the full SHA bd70f3aView commit details -
Use const reference in RCTNativeModule::invokeInner
Reviewed By: mhorowitz Differential Revision: D5909088 fbshipit-source-id: 3104e3d0a4b29d457c3c7fad2a29e2f0943b478d
Configuration menu - View commit details
-
Copy full SHA for 29e7659 - Browse repository at this point
Copy the full SHA 29e7659View commit details -
adding error message including stacktrace and example
Reviewed By: fkgozali Differential Revision: D5908789 fbshipit-source-id: 061e414d5105df607b7dcafefb134ad9c94a9a71
Configuration menu - View commit details
-
Copy full SHA for b694f96 - Browse repository at this point
Copy the full SHA b694f96View commit details -
Native Animated - Allow events that are dispatched from any thread
Summary: Instead of preventing events from working when not on the UI Thread we can just dispatch to it instead. **Test plan** Tested manually that animated events still work in RNTester Closes #15953 Differential Revision: D5909816 Pulled By: shergin fbshipit-source-id: 48d02b6aa9f2bc3bcb638e8852fccaac3f205276
Configuration menu - View commit details
-
Copy full SHA for 3cbc361 - Browse repository at this point
Copy the full SHA 3cbc361View commit details -
Using SafeAreaView in YellowBox (2nd attempt)
Summary: Now it does not clipped on iPhone X. Reviewed By: yungsters Differential Revision: D5907527 fbshipit-source-id: 10d05e4ac5d16a9e257efa78795bff9f14f4c0bb
Configuration menu - View commit details
-
Copy full SHA for c70ac24 - Browse repository at this point
Copy the full SHA c70ac24View commit details -
Allow applicationId to be specified on build
Summary: Added the ability to define a specific applicationId (in case it's different to the package name) <details> Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. Please read the [Contribution Guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md) to learn more about contributing to React Native. </details> We have a specific requirement that our package name differs from the applicationId but not in a way that allows us to add it as a suffix to our package name. I wanted to add the option to specify a specific applicationId. `react-native run-android --appId <Specific Application Id>` Closes #14524 Differential Revision: D5910259 Pulled By: shergin fbshipit-source-id: 768fbc910f6b520dd18936f6bceeee136fca7025
Configuration menu - View commit details
-
Copy full SHA for 9796295 - Browse repository at this point
Copy the full SHA 9796295View commit details -
Summary: Hey ! I noticed that the `minimumTrackTintColor` and `maximumTrackTintColor` are exchanged in iOS and Android. In iOS, `minimumTrackTintColor` is the left color and `maximumTrackTintColor` is the right color. In Android, `minimumTrackTintColor` is the right color and `maximumTrackTintColor` is the left color. With this code : ```jsx <Slider style={{ width: 300 }} minimumTrackTintColor="red" maximumTrackTintColor="blue" /> ``` |iOS|Android| |----|----| |![image](https://user-images.githubusercontent.com/17292331/30700555-2b8ae828-9ee8-11e7-94a3-f1d3adee7fd5.png)|![screenshot_2017-09-21-15-59-59](https://user-images.githubusercontent.com/17292331/30699855-246c1280-9ee6-11e7-9653-e61c4798a50f.png)| |iOS|Android| |----|----| |![image](https://user-images.githubusercontent.com/17292331/30700563-2fc8c25c-9ee8-11e7-9c0d-955d9921660f.png) (same)|![screenshot_2017-09-21-16-12-04](https://user-images.githubusercontent.com/17292331/30700418-def3e136-9ee7-11e7-982b-48aeba23a5ea.png)| Closes #16053 Differential Revision: D5910299 Pulled By: shergin fbshipit-source-id: 74851e4cc6d54f72ea2755200e26b0d921890b48
Configuration menu - View commit details
-
Copy full SHA for 31904d5 - Browse repository at this point
Copy the full SHA 31904d5View commit details -
Move debugger client code to its own folder
Reviewed By: davidaurelio Differential Revision: D5899764 fbshipit-source-id: 3498dd71a11b47841a492cf77df7c887404c1719
Configuration menu - View commit details
-
Copy full SHA for e6596dc - Browse repository at this point
Copy the full SHA e6596dcView commit details -
Use BitmapRegionDecoder to efficiently crop images on Android
Summary: The Android ImageEditingManager is inefficient and slow when cropping images. It loads the full resolution image into memory and then crops it. This leads to slow performance and occasional OutOfMemory Exceptions. [BitmapRegionDecoder](https://developer.android.com/reference/android/graphics/BitmapRegionDecoder.html) can be used to crop without needing to load the full resolution image into memory. Using it is much more efficient and much faster. Relevant issue: #10470 Attempt to crop a very large image (2000x2000) on Android. With this change, the crop should happen almost instantly. On the master branch, it should take 2-3 seconds (and might run out of memory). Please let me know if there's anything else I can provide. Closes #15439 Differential Revision: D5628223 Pulled By: shergin fbshipit-source-id: bf314e76134cd015380968ec4533225e724c4b26
Configuration menu - View commit details
-
Copy full SHA for 64ffe45 - Browse repository at this point
Copy the full SHA 64ffe45View commit details -
Only disallow changes if the value actually changed
Differential Revision: D5884661 fbshipit-source-id: 2d9fe28a0ecfc46afc9ca459975455e1fd13d19b
Configuration menu - View commit details
-
Copy full SHA for 6f6329d - Browse repository at this point
Copy the full SHA 6f6329dView commit details -
explicitly show how to add the optional listener
Summary: The previous example only showed where to add the optional "listener" but didn't show how to make use of it. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) Closes #15576 Differential Revision: D5911716 Pulled By: shergin fbshipit-source-id: 60023470d23c2cbbde47ab9aa82c7ecef73be467
Configuration menu - View commit details
-
Copy full SHA for e3a6be5 - Browse repository at this point
Copy the full SHA e3a6be5View commit details -
Fixes removeClipSubviews check for offscreen rendering of ListViews
Summary: This issue has been open for a really long time, but I'm pretty sure this is the line that needed to change: #1831 What was happening here is that `CGRectIsEmpty` returns true when either height or width is zero. With the current logic, one of those would always be zero when the parent was rendered off screen. This ensures that there the intersection be of CGSizeZero for the view to actually be clipped. That being said, there seems to be something more complex going on here that I'm not understanding? I would think that you'd simply want to check if the child view's frame is within the bounds of the parent at all. If it was, then don't clip it. If I'm in the wrong, could someone explain this a bit more? If so, I'll fix this issue. Using this [repository](https://github.com/jcharlet/react_native_listview_bug), this one line change fixes the issue and still clips cells as they are scrolled off screen. Closes #15669 Differential Revision: D5815056 Pulled By: shergin fbshipit-source-id: 32382e4954139e4d5af67d786422fd87173b1a1a
Configuration menu - View commit details
-
Copy full SHA for 03ae65b - Browse repository at this point
Copy the full SHA 03ae65bView commit details -
Update typings for Promise.all() for D5827319
Reviewed By: samwgoldman Differential Revision: D5830645 fbshipit-source-id: db2bb0715aab58d3601712ee0b080abaa9f8f131
Configuration menu - View commit details
-
Copy full SHA for 292b19d - Browse repository at this point
Copy the full SHA 292b19dView commit details -
Make the runBeforeMainModule config param to RN repo and make it abso…
…lute Reviewed By: davidaurelio Differential Revision: D5880700 fbshipit-source-id: 5df6781026030395900388c561283abadefa6511
Configuration menu - View commit details
-
Copy full SHA for 34487c0 - Browse repository at this point
Copy the full SHA 34487c0View commit details -
Bunch of utility funcs were moved to RCTUIManagerUtils
Summary: Because `RCTUIManager` is already overcomplicated and that stuff deserves separate file and header. Reviewed By: javache Differential Revision: D5856653 fbshipit-source-id: 7001bb8ba611976bf3b82d6a25f5619810a35b34
Configuration menu - View commit details
-
Copy full SHA for 6d67e2d - Browse repository at this point
Copy the full SHA 6d67e2dView commit details -
Summary: Added the executable path to the `COMMON_EDITORS` Added the executable name to the arguments selections <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Need to be able to jump to specific files and line numbers in WebStorm and autodetect WebStorm as editor, without setting up any environment vars. Start a new RN project in WebStorm, make some JS errors and click the errors to confirm that it will jump to the right file and line number in WebStorm. Make sure that none of the other `COMMON_EDITORS` are running, unless you set the `REACT_EDITOR` environment variable. Closes #15984 Differential Revision: D5911698 Pulled By: shergin fbshipit-source-id: 54fced7539520553dd2a93bf7ca7e4f457b0bfc3
Configuration menu - View commit details
-
Copy full SHA for 43d394c - Browse repository at this point
Copy the full SHA 43d394cView commit details
Commits on Sep 27, 2017
-
Make Module.getName() synchronous
Reviewed By: cpojer Differential Revision: D5911221 fbshipit-source-id: 2381d70008adff9e0f7613fe43c8fb562222acd6
Configuration menu - View commit details
-
Copy full SHA for ee8aedd - Browse repository at this point
Copy the full SHA ee8aeddView commit details -
Default TextInput autoCapitalize to sentences on Android
Summary: Currently `TextInput.autoCapitalize` is defaulting to 'none' on Android. This PR sets the default to 'sentences', to match iOS and the PropTypes documentation. Fixes #14846 Closes #14853 Differential Revision: D5918196 Pulled By: shergin fbshipit-source-id: d0d00e75d44a410c6821b4ff8910099aae2b2c7c
Configuration menu - View commit details
-
Copy full SHA for 227a5f4 - Browse repository at this point
Copy the full SHA 227a5f4View commit details -
Un-inline-ing a method declared as export
Reviewed By: compnerd Differential Revision: D5909847 fbshipit-source-id: 7108dd88271e640e1881b20c0cbf1ad28bbf63c9
Configuration menu - View commit details
-
Copy full SHA for 5038b06 - Browse repository at this point
Copy the full SHA 5038b06View commit details -
Reviewed By: fkgozali Differential Revision: D5763293 fbshipit-source-id: 865ed74a78606cb54f274ebedae49de980dcab6f
Configuration menu - View commit details
-
Copy full SHA for 888c6e7 - Browse repository at this point
Copy the full SHA 888c6e7View commit details -
Differential Revision: D5763302 fbshipit-source-id: a91ca1786c7ac8eb9aa3dd43555a7a223dc6f9cf
Configuration menu - View commit details
-
Copy full SHA for 70c6700 - Browse repository at this point
Copy the full SHA 70c6700View commit details -
Log call stack symbols in case of native module method's failure
Differential Revision: D5921069 fbshipit-source-id: c386a836e6f3c314d668e02f3bae243dadcab6e3
Configuration menu - View commit details
-
Copy full SHA for 47f6068 - Browse repository at this point
Copy the full SHA 47f6068View commit details -
Bump metro-bundler dependency to 0.19.x
Reviewed By: cpojer Differential Revision: D5920597 fbshipit-source-id: fdc4f50ffdb43487e7c3480b7cc587b7ff483681
Configuration menu - View commit details
-
Copy full SHA for 28525ba - Browse repository at this point
Copy the full SHA 28525baView commit details -
Summary: Closes #16089 Differential Revision: D5906760 Pulled By: hramos fbshipit-source-id: 523a5b63d7c0882fe7d257bdbc07b86e672f501d
Configuration menu - View commit details
-
Copy full SHA for 01a6178 - Browse repository at this point
Copy the full SHA 01a6178View commit details -
Enabling
flashScrollIndicators
example for all platformsSummary: ... because it was recently implemented for Android. Reviewed By: mmmulani Differential Revision: D5916305 fbshipit-source-id: b8af0f8712e36aee5c44f7ede41da25fc944134f
Configuration menu - View commit details
-
Copy full SHA for e9a090f - Browse repository at this point
Copy the full SHA e9a090fView commit details -
Reviewed By: achen1 Differential Revision: D5741087 fbshipit-source-id: f6b8f713cb3c4e48b417b47557a45ff9a4a5bf05
Configuration menu - View commit details
-
Copy full SHA for 672db77 - Browse repository at this point
Copy the full SHA 672db77View commit details -
Backed out changeset 7c338fe3b747
Reviewed By: AaaChiuuu Differential Revision: D5926999 fbshipit-source-id: 58595f74f1fab764b63b5d7d6c2f20d8edb2efda
Configuration menu - View commit details
-
Copy full SHA for 9b3cc30 - Browse repository at this point
Copy the full SHA 9b3cc30View commit details
Commits on Sep 28, 2017
-
Validate that JS and Native code versions match for RN releases
Summary: Basic implementation of the proposal in #15271 Note that this should not affect facebook internally since they are not using OSS releases. Points to consider: - How strict should the version match be, right now I just match exact versions. - Wasn't able to use haste for ReactNativeVersion because I was getting duplicate module provider caused by the template file in scripts/versiontemplates. I tried adding the scripts folder to modulePathIgnorePatterns in package.json but that didn't help. - Redscreen vs. warning, I think warning is useless because if the app crashes you won't have time to see the warning. - Should the check and native modules be __DEV__ only? **Test plan** Tested that it works when version match and that it redscreens when versions don't before getting other errors on Android and iOS. Closes #15518 Differential Revision: D5813551 Pulled By: hramos fbshipit-source-id: 901757e25724b0f22bf39de172b56309d0dd5a95
Configuration menu - View commit details
-
Copy full SHA for 1af645b - Browse repository at this point
Copy the full SHA 1af645bView commit details -
Add onScrollToIndexFailed support
Summary: Allows handling the case of wanting to scroll beyond the measured window. Reviewed By: TheSavior Differential Revision: D5915331 fbshipit-source-id: 329927632f4d04f213567ce4bbe547b04b8ea86d
Configuration menu - View commit details
-
Copy full SHA for e16b514 - Browse repository at this point
Copy the full SHA e16b514View commit details -
Removed unused imports from RCTUIManager
Reviewed By: mmmulani Differential Revision: D5916606 fbshipit-source-id: f7a301928f68bc2aa15a8e50c4b25f2779d27567
Configuration menu - View commit details
-
Copy full SHA for ac6b1d1 - Browse repository at this point
Copy the full SHA ac6b1d1View commit details -
Add missing node-notifier npm dependency
Summary: local-cli now depends on the node-notifier package but it wasn't listed in package.json. Closes #15905 Reviewed By: TheSavior Differential Revision: D5814773 Pulled By: hramos fbshipit-source-id: 3c397b0a21fea5009f35a69515e70a6d78ece375
Configuration menu - View commit details
-
Copy full SHA for 4119182 - Browse repository at this point
Copy the full SHA 4119182View commit details -
missing parentheses in example code
Summary: in the example code for configuring animations, Easing.back should be Easing.back() <!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. In other words, a test plan is *required*. Bonus points for screenshots and videos! Please read the Contribution Guidelines at https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md to learn more about contributing to React Native. Happy contributing! --> Closes #15273 Differential Revision: D5929874 Pulled By: shergin fbshipit-source-id: 89921d0dda899e1697ee1fa5d96752964a2dc3f9
Configuration menu - View commit details
-
Copy full SHA for 235c887 - Browse repository at this point
Copy the full SHA 235c887View commit details -
Reviewed By: achen1 Differential Revision: D5741372 fbshipit-source-id: 65d46decd26e563ab3cd9ea72c3a391ba32c67bb
Configuration menu - View commit details
-
Copy full SHA for 652dfd0 - Browse repository at this point
Copy the full SHA 652dfd0View commit details -
always pass key parameter to RCTReadFile
Differential Revision: D5921064 fbshipit-source-id: ad2dd352060fcb2c873dc5a91781797c9abd6c33
Configuration menu - View commit details
-
Copy full SHA for c4f7ce9 - Browse repository at this point
Copy the full SHA c4f7ce9View commit details -
Implement lazy discovery for ViewManagers.
Reviewed By: kathryngray Differential Revision: D5865095 fbshipit-source-id: c94970e4cd7aafb20cf844c48feea053ac8b6b0f
Configuration menu - View commit details
-
Copy full SHA for da30b04 - Browse repository at this point
Copy the full SHA da30b04View commit details -
Make ios-install-third-party.sh more robust
Summary: See #14423 This adds checks after download that each file is present, and has the correct sha1 hash. If not, it will retry several times, and fail if it can't successfully download the file. If a file is downloaded, the unpack and command will run, even if the third-party dir already exists. The diagnostics printed in the event of failure are improved. This should be self-healing for anybody who has a bad ~/.rncache directory. The checksum will fail, and the files will be redownloaded. Reviewed By: hramos Differential Revision: D5930707 fbshipit-source-id: cb15af949294243448ccc3995ec3f0396b1922b6
Configuration menu - View commit details
-
Copy full SHA for 05cb7ce - Browse repository at this point
Copy the full SHA 05cb7ceView commit details -
Reviewed By: javache Differential Revision: D5925489 fbshipit-source-id: 799b530a2540850722ad1910263030afb951c4c5
Configuration menu - View commit details
-
Copy full SHA for 089add4 - Browse repository at this point
Copy the full SHA 089add4View commit details
Commits on Sep 29, 2017
-
fix arc drawing when sweep >= 360
Summary: I hit this issue in my own component https://github.com/nihgwu/react-native-pie, and find this https://stackoverflow.com/questions/19383842/weird-behaviour-in-drawing-a-ring-using-path-arcto-in-android, after this change, it looks exactly the same on both Android and iOS Closes #15042 Differential Revision: D5937957 Pulled By: shergin fbshipit-source-id: 3c88565a1cc90d82edd819d048f40d4961f78b3c
Configuration menu - View commit details
-
Copy full SHA for b64e6c7 - Browse repository at this point
Copy the full SHA b64e6c7View commit details -
Reviewed By: sahrens Differential Revision: D5912488 fbshipit-source-id: 3d2872a7712c00badcbd8341a7d058df14a9091a
10Configuration menu - View commit details
-
Copy full SHA for d8cc6e3 - Browse repository at this point
Copy the full SHA d8cc6e3View commit details -
fix params order in comments clamp.js
Summary: /** * param {number} value * param {number} min * param {number} max * return {number} */ should be: /** * param {number} min * param {number} value * param {number} max * return {number} */ <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) Closes #16077 Differential Revision: D5938021 Pulled By: shergin fbshipit-source-id: 3a6e4ff5ab39a657bc0d9271ae2a2600998b2ddf
Configuration menu - View commit details
-
Copy full SHA for 3849765 - Browse repository at this point
Copy the full SHA 3849765View commit details -
Add Delta Bundler client to JS remote debugger
Reviewed By: jeanlauliac Differential Revision: D5899825 fbshipit-source-id: 9c5815ef234507034016becaabae754129b96c71
Configuration menu - View commit details
-
Copy full SHA for ace7273 - Browse repository at this point
Copy the full SHA ace7273View commit details -
Add Source Map support to e2e deltas in chrome debugger
Reviewed By: jeanlauliac Differential Revision: D5917380 fbshipit-source-id: 31391bc03c420b8e7af5c840fbea2fb0dd5f7bbc
Configuration menu - View commit details
-
Copy full SHA for 15130d5 - Browse repository at this point
Copy the full SHA 15130d5View commit details -
Reviewed By: AaaChiuuu Differential Revision: D5932865 fbshipit-source-id: 700983d7fc44c4ee5f77b58ef54cec62869009e0
1Configuration menu - View commit details
-
Copy full SHA for 7320ca5 - Browse repository at this point
Copy the full SHA 7320ca5View commit details -
metro-bundler: add fs#writeFileSync to the mock
Reviewed By: rafeca Differential Revision: D5931412 fbshipit-source-id: 2b51617b57963c424446b04e9381e6500323af56
Configuration menu - View commit details
-
Copy full SHA for b3fc642 - Browse repository at this point
Copy the full SHA b3fc642View commit details -
Add gating to the JS delta client on the remote debugger
Reviewed By: jeanlauliac Differential Revision: D5940923 fbshipit-source-id: 1ef4cd52ef3567f2e726217636253802a2e6bb40
Configuration menu - View commit details
-
Copy full SHA for a0e88c2 - Browse repository at this point
Copy the full SHA a0e88c2View commit details -
Don't set defaultProps for default view manager values
Summary: The Android ViewManager already has disabled set to false by default. When setting it in defaultProps we send it over for every text view, which is unnecessary. On platforms that don't support disabled this may also cause unnecessary log noise. Closes #16139 Differential Revision: D5944334 Pulled By: javache fbshipit-source-id: 54c4b65f345cd284759d01d075522f5aa2f74298
Configuration menu - View commit details
-
Copy full SHA for e691699 - Browse repository at this point
Copy the full SHA e691699View commit details -
Added Android support for loading multiple RAM bundles
Differential Revision: D5901574 fbshipit-source-id: 395bae41e58505918d7ad20ac432eba3361361ea
Configuration menu - View commit details
-
Copy full SHA for 4162d73 - Browse repository at this point
Copy the full SHA 4162d73View commit details -
Summary: MaskedViewIOS instead of MaskedView Closes #16135 Differential Revision: D5942428 Pulled By: shergin fbshipit-source-id: 44e771d9a318c66c8721775bcaf8506eb0fbbecd
Configuration menu - View commit details
-
Copy full SHA for a004e2b - Browse repository at this point
Copy the full SHA a004e2bView commit details -
Add include_defs("//ReactAndroid/DEFS") to all BUCK files in ReactAnd…
…roid Reviewed By: mmmulani Differential Revision: D5915945 fbshipit-source-id: 49bce07e4f5a2f4a8985b992e1e7d9ea4ef6c654
Configuration menu - View commit details
-
Copy full SHA for ebb42ee - Browse repository at this point
Copy the full SHA ebb42eeView commit details -
Change all calls to no-console from no-console-disallow
Reviewed By: TheSavior Differential Revision: D5944700 fbshipit-source-id: cdd78d1b32fa98d8a792a39ccc3cb37241ab4366
Configuration menu - View commit details
-
Copy full SHA for d3e1a21 - Browse repository at this point
Copy the full SHA d3e1a21View commit details
Commits on Sep 30, 2017
-
Fix error appearing when disconnecting HMR client
Reviewed By: cpojer Differential Revision: D5944285 fbshipit-source-id: 5751f6ad2b999872aa3d33e1c7fca105b3156da4
Configuration menu - View commit details
-
Copy full SHA for 38ec30b - Browse repository at this point
Copy the full SHA 38ec30bView commit details -
make view hierarchy optimizer smarter
Reviewed By: shergin Differential Revision: D5744725 fbshipit-source-id: 4042310494a2bbd3d3472485ad8496d592eb28ac
Configuration menu - View commit details
-
Copy full SHA for e7af72b - Browse repository at this point
Copy the full SHA e7af72bView commit details -
Reviewed By: shergin Differential Revision: D5917111 fbshipit-source-id: e3d97f26b6aada199f700ec6659ace0d7dffd4c5
11Configuration menu - View commit details
-
Copy full SHA for 30044fd - Browse repository at this point
Copy the full SHA 30044fdView commit details -
Changed React to React Native in README.md
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Referencing #16142 Closes #16146 Differential Revision: D5950544 Pulled By: TheSavior fbshipit-source-id: 6a679ed2ca1fdb91a4240f02e68bbef858b5b645
Configuration menu - View commit details
-
Copy full SHA for 9cf2b11 - Browse repository at this point
Copy the full SHA 9cf2b11View commit details
Commits on Oct 2, 2017
-
Fixed RNTester project file for Apple TV
Summary: Now it compiles and works. Reviewed By: fromcelticpark Differential Revision: D5952026 fbshipit-source-id: df0408108ab29b77592d78b29553d2e65686f2f2
Configuration menu - View commit details
-
Copy full SHA for cd74e46 - Browse repository at this point
Copy the full SHA cd74e46View commit details -
iOS: Support allowFontScaling on TextInput
Summary: Currently, only `Text` supports the `allowFontScaling` prop. This commit adds support for it on `TextInput`. As part of this change, the TextInput setters for font attributes (e.g. size, weight) had to be refactored. The problem with them is that they use RCTFont's helpers which create a new font based on an existing font. These helpers lose information. In particular, they lose the scaleMultiplier. For example, suppose the font size is 12 and the device's font multiplier is set to 1.5. So we'd create a font with size 12 and scaleMultiplier 1.5 which is an effective size of 18 (which is the only thing stored in the font). Next, suppose the device's font multiplier changes to 1. So we'd use an RCTFont helper to create a new font based on the existing font but with a scaleMultiplier of 1. However, the font didn't store the font size (12) and scaleMultiplier (1.5) separately. It just knows the (effective) font size of 18. So RCTFont thinks the new font has a font size of 18 and a scaleMultiplier of 1 so its effective font size is 18. This is incorrect and it should have been 12. To fix this, the font attributes are now all stored individually. Anytime one of them changes, updateFont is called which recreates the font from scratch. This happens to fix some bugs around fontStyle and fontWeight which were reported several times before: #13730, #12738, #2140, #8533. Created a test app where I verified that `allowFontScaling` works properly for `TextInputs` for all values (`undefined`, `true`, `false`) for a variety of `TextInputs`: - Singleline TextInput - Singleline TextInput's placeholder - Multiline TextInput - Multiline TextInput's placeholder - Multiline TextInput using children instead of `value` Also, verified switching `fontSize`, `fontWeight`, `fontStyle` and `fontFamily` through a bunch of combinations works properly. Lastly, my team has been using this change in our app. Adam Comella Microsoft Corp. Closes #14030 Reviewed By: TheSavior Differential Revision: D5899959 Pulled By: shergin fbshipit-source-id: c8c8c4d4d670cd2a142286e79bfffef3b58cecd3
Configuration menu - View commit details
-
Copy full SHA for 9c4ec30 - Browse repository at this point
Copy the full SHA 9c4ec30View commit details -
BREAKING: Add interface for ReactShadowNode
Reviewed By: AaaChiuuu Differential Revision: D5943137 fbshipit-source-id: 00950190e0256303d423ae86c6c18facf173ad6a
Configuration menu - View commit details
-
Copy full SHA for a5d1d25 - Browse repository at this point
Copy the full SHA a5d1d25View commit details -
RN buck: bundleCommand: add test for multiple bundles
Reviewed By: davidaurelio Differential Revision: D5932971 fbshipit-source-id: 317e4503b87224cb3fa4ed7819b8af334d0b186b
Configuration menu - View commit details
-
Copy full SHA for 53a339a - Browse repository at this point
Copy the full SHA 53a339aView commit details -
Re-render views when direction changes
Summary: This is required for D5874536, wherein I'll be introducing direction-aware props for borders. When a view's border changes due to a direction update, only the frames of its children update. Therefore, only the children `UIView`s get a chance to be re-rendered. This is incorrect because the view that's had its borders changed also needs to re-render. So, I keep a track of the layout direction in a property on all shadow views. Then, when I update that prop within `applyLayoutNode`, I push shadow views into the `viewsWithNewFrames` set. Reviewed By: mmmulani Differential Revision: D5944488 fbshipit-source-id: 3f23e9973f3555612920703cdb6cec38e6360d2d
Configuration menu - View commit details
-
Copy full SHA for 9bbc70c - Browse repository at this point
Copy the full SHA 9bbc70cView commit details -
Revert D5944488: [RN][iOS]: Re-render views when direction changes
Differential Revision: D5944488 fbshipit-source-id: 79e695dcc0ea7d09544ace1525828333a5818c5a
Configuration menu - View commit details
-
Copy full SHA for abed3cf - Browse repository at this point
Copy the full SHA abed3cfView commit details -
Introducting
UIManager.setLocalData()
, the way to provide environme……ntal data to ShadowNode Summary: In some cases we need a way to provide some peice of data to shadow node to improve layout (or do something similar), `setLocalData` allows to do this. Reviewed By: AaaChiuuu Differential Revision: D5828368 fbshipit-source-id: bf6a04f460dc7695a16269426d365b78909bc8eb
Configuration menu - View commit details
-
Copy full SHA for d0790fe - Browse repository at this point
Copy the full SHA d0790feView commit details -
Intrinsic content size for ReactTextInput (aka autoexpandable <TextIn…
…put> on Android) Summary: After this diff the intrinsic content size of <TextInput> reflects the size of text inside EditText, it means that if there is no additional style constraints, <TextInput> will grow with containing text. If you want to constraint minimum or maximum height, just do it via Yoga styling. Reviewed By: achen1 Differential Revision: D5828366 fbshipit-source-id: eccd0cb4ccf724c7096c947332a64a0a1e402673
Configuration menu - View commit details
-
Copy full SHA for c550f27 - Browse repository at this point
Copy the full SHA c550f27View commit details
Commits on Oct 3, 2017
-
Extend unit test for buildStyleInterpolator
Reviewed By: vjeux Differential Revision: D5950672 fbshipit-source-id: 921ed6ae6a2b307b050c721cedd4b51e880695ae
Configuration menu - View commit details
-
Copy full SHA for 3e31038 - Browse repository at this point
Copy the full SHA 3e31038View commit details -
Avoid eval in buildStyleInterpolator
Reviewed By: vjeux Differential Revision: D5950405 fbshipit-source-id: ee794317f820e8fbb87752b88539171115a8e00e
Configuration menu - View commit details
-
Copy full SHA for 915ac20 - Browse repository at this point
Copy the full SHA 915ac20View commit details -
Summary: This fixes [#15801](#15801) We ran into a strange crash on iOS (debug only). After removing the clutter I was able to reproduce it in a tiny app. You can check it out [here.](https://github.com/simonracz/textinput_stress) The UI in JS and native are not always in sync (which is okay). Due to this, a native view might call back into JS, which is no longer present in the shadow view hierarchy there. I think this should be also okay. TextInput in some cases calls into [setIntrinsicContentView](https://github.com/facebook/react-native/blob/6d67e2dbbcd658b7f845ebb0d0156bd64dc68226/React/Modules/RCTUIManager.m#L382), where it triggers an overly enthusiastic `NSAssert` and crashes the app. Check out [textinput_stress](https://github.com/simonracz/textinput_stress) Rotate the simulator a few times to see the crash or the lack of crash. Closes #16170 Differential Revision: D5959776 Pulled By: shergin fbshipit-source-id: f39f5a3f1d86b330ecf7cbccd90871bc01fd69d9
Configuration menu - View commit details
-
Copy full SHA for be27f44 - Browse repository at this point
Copy the full SHA be27f44View commit details -
Using RCTExecuteOnUIManagerQueue convinient func in all conseptually …
…identical cases Summary: Reasons: * It is more clear and readable; * It is more semantical; * It allows us to add some magic (and complexity, to be fair) to the RCTExecuteOnUIManagerQueue. (See next diffs in the stack.) Reviewed By: javache Differential Revision: D5935466 fbshipit-source-id: aeb18d6e11c047eb19182a656da581b6ce073602
Configuration menu - View commit details
-
Copy full SHA for feba4f6 - Browse repository at this point
Copy the full SHA feba4f6View commit details -
Using RCTExecuteOnMainQueue in RCTUIManager
Reviewed By: javache Differential Revision: D5937423 fbshipit-source-id: 1b7f5976acdfdfd00c6aa5c13e80113ba1e04434
Configuration menu - View commit details
-
Copy full SHA for 9cd095e - Browse repository at this point
Copy the full SHA 9cd095eView commit details -
Reviewed By: zjj010104 Differential Revision: D5961716 fbshipit-source-id: 0efaf38380b0b2e9440375ce0a7623a543f3fbd0
Configuration menu - View commit details
-
Copy full SHA for f368287 - Browse repository at this point
Copy the full SHA f368287View commit details -
Reviewed By: calebmer Differential Revision: D5958715 fbshipit-source-id: 7feda03a9540e69bf8d9b4eb89720248ff43294f
Configuration menu - View commit details
-
Copy full SHA for a16ef18 - Browse repository at this point
Copy the full SHA a16ef18View commit details -
DeviceInfo.isIPhoneX_deprecated: ugly and temporary way to fix your U…
…I on iPhone X Summary: If you are a product developer and you need to fix your app's issues related to iPhone X limitations asap, you can temporary use `DeviceInfo.isIPhoneX_deprecated`. You can, but you should not. Please consider use new <SafeAreaView>. This prop was initially named so ugly because we are trying to discourage the community to use it. However, we understand that sometimes we need a "band-aid" to prevent our apps bleeding. Note: This prop (DeviceInfo.isIPhoneX_deprecated) will be removed completely after 06/18. Reviewed By: fkgozali Differential Revision: D5946329 fbshipit-source-id: 5d6dcaf0e2d175327d59cde4b5ec2e01cd77ec70
Configuration menu - View commit details
-
Copy full SHA for 33f4779 - Browse repository at this point
Copy the full SHA 33f4779View commit details -
Add headers prop in source array type prop
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> My first contribution 👍 (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) Closes #16155 Differential Revision: D5962399 Pulled By: shergin fbshipit-source-id: b7a44d53d875b32d04c1b876eb7ec2f30a9d0d80
Configuration menu - View commit details
-
Copy full SHA for ddc2210 - Browse repository at this point
Copy the full SHA ddc2210View commit details -
Reviewed By: fkgozali Differential Revision: D5962566 fbshipit-source-id: 5f92890a08b6e900b8d54f35c48e783166ce5897
Configuration menu - View commit details
-
Copy full SHA for 6ba9ad8 - Browse repository at this point
Copy the full SHA 6ba9ad8View commit details -
Fix regression in Java->C++->JS ViewManagers interaction.
Reviewed By: bvaughn Differential Revision: D5953937 fbshipit-source-id: 8bc5dd8a483054ab9830ab653f2a3b41cad6c791
Configuration menu - View commit details
-
Copy full SHA for 346af55 - Browse repository at this point
Copy the full SHA 346af55View commit details -
Add a check in InitializeCore.js that PlatformConstants native module…
… is present Summary: In some enviroments PlatformConstants native module may not be presented in a project, which results in a call to undefined property and a RedBox Reviewed By: javache Differential Revision: D5960879 fbshipit-source-id: 80aecbe2f2a61cb410abd5f0dce8ba855e166991
Configuration menu - View commit details
-
Copy full SHA for 96f23e7 - Browse repository at this point
Copy the full SHA 96f23e7View commit details -
Add AppIdentity and DeviceIdentity to Inspector
Reviewed By: Hypuk Differential Revision: D5924011 fbshipit-source-id: a81d420dbe1a5ede203d2fa313548e19664b9587
Configuration menu - View commit details
-
Copy full SHA for da14fad - Browse repository at this point
Copy the full SHA da14fadView commit details -
Add isNetworkInspected to check if a JS VM needs to be paused on launch
Reviewed By: mhorowitz Differential Revision: D5924019 fbshipit-source-id: 6b1cfc94d149883236ad06619fc54018d57cb0e7
Configuration menu - View commit details
-
Copy full SHA for 9056314 - Browse repository at this point
Copy the full SHA 9056314View commit details -
Fix DeviceIdentity on RN for Android
Reviewed By: Hypuk Differential Revision: D5963912 fbshipit-source-id: 3959e5ab6af66512f0035efea7919572554e10b4
Configuration menu - View commit details
-
Copy full SHA for e7765a3 - Browse repository at this point
Copy the full SHA e7765a3View commit details -
fix spelling in ReactInstanceManager
Reviewed By: kathryngray Differential Revision: D5959860 fbshipit-source-id: 3d5358349fd6c0f9b8e57261914c945488684a96
Configuration menu - View commit details
-
Copy full SHA for 13d8375 - Browse repository at this point
Copy the full SHA 13d8375View commit details -
SafeAreaView was added to OSS RNTester project file
Reviewed By: rsnara Differential Revision: D5962563 fbshipit-source-id: c043d3ab32d6ed77a1a258b30fa86661338f5c76
Configuration menu - View commit details
-
Copy full SHA for 20ba515 - Browse repository at this point
Copy the full SHA 20ba515View commit details -
bring back box-none as layout only prop
Differential Revision: D5965540 fbshipit-source-id: a4a7b32a563674cf5f94e88390483763cf49d6da
Configuration menu - View commit details
-
Copy full SHA for bbcfcdb - Browse repository at this point
Copy the full SHA bbcfcdbView commit details -
Re-render views when direction changes
Reviewed By: shergin Differential Revision: D5959573 fbshipit-source-id: 36b2cde921362a934a2c88a3ed05be5082ed08bf
Configuration menu - View commit details
-
Copy full SHA for 992ade1 - Browse repository at this point
Copy the full SHA 992ade1View commit details
Commits on Oct 4, 2017
-
Modernize docs: remove 'use strict' from docs -- es6 has 'use strict'…
… by default Summary: Removed <b>'use strict'</b> from docs since ES6 Modules already use <b>'use strict'</b> by default. https://stackoverflow.com/questions/31685262/not-recommended-to-use-use-strict-in-es6 > 10.2.1 Strict Mode Code > An ECMAScript Script syntactic unit may be processed using either unrestricted or strict mode syntax and semantics. Code is interpreted as strict mode code in the following situations: > Global code is strict mode code if it begins with a Directive Prologue that contains a Use Strict Directive (see 14.1.1). Module code is always strict mode code. All parts of a ClassDeclaration or a ClassExpression are strict mode code. Eval code is strict mode code if it begins with a Directive Prologue that contains a Use Strict Directive or if the call to eval is a direct eval (see 12.3.4.1) that is contained in strict mode code. Function code is strict mode code if the associated FunctionDeclaration, FunctionExpression, GeneratorDeclaration, GeneratorExpression, MethodDefinition, or ArrowFunction is contained in strict mode code or if the code that produces the value of the function’s [[ECMAScriptCode]] internal slot begins with a Directive Prologue that contains a Use Strict Directive. Function code that is supplied as the arguments to the built-in Function and Generator constructors is strict mode code if the last argument is a String that when processed is a FunctionBody that begins with a Directive Prologue that contains a Use Strict Directive. Spec: http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code Closes #16163 Differential Revision: D5968746 Pulled By: hramos fbshipit-source-id: 308f49184b1565311d5fd71786639eaee13be60a
Configuration menu - View commit details
-
Copy full SHA for e1fb6ff - Browse repository at this point
Copy the full SHA e1fb6ffView commit details -
Fixed crash in ReactTextInputLocalData
Summary: Motivation: (SUDDENLY) There is a thing on Android called SpanWather, and their purpose is to notify "the watcher" about span-related changes in SpannableString. The idea is: some special kind of span can have some logic to prevent or tweak interleaving with some another kind of spans. To do so, it has to implement SpanWather interface. So, EditText uses this to control internal spannable object (!) and SUDDENLY (#><) calls internal "layout" method as a reaction to adding new spans. So, when we are cloning SpannableString, we are (re)applying same span objects to a new spannable instance, and it causes notifying other spans in the string, and they notify EditText, and the EditText does relayout and... BOOM! So, the solution is, easy, we should use SpannableStringBuilder instead of SpannableString because it does not notify SpanWather during cloning. See: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringBuilder.java#101 (the first argument is `false`). https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringBuilder.java#678 Compare with: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringInternal.java#43 Why? I believe because SpannableStringBuilder objects are "unfinished" by design, and documentation said: "it is the caller's responsibility to restore invariants [among spans]". As we do an exact clone of the string, that's perfectly okay to assume that all invariants were already satisfied for original string. Reviewed By: achen1 Differential Revision: D5970940 fbshipit-source-id: 590ca0e3aede4470b809c7db527c5d55ddf5edb4
Configuration menu - View commit details
-
Copy full SHA for cdea3c5 - Browse repository at this point
Copy the full SHA cdea3c5View commit details -
Set fishhook's header_dir to "fishhook"
Summary: This lets us import fishhook like `<fishhook/fishhook.h>`. Closes #16192 Differential Revision: D5971639 Pulled By: shergin fbshipit-source-id: c46503953a08a74bdd10ed35cbd30029f1666c7d
Configuration menu - View commit details
-
Copy full SHA for 26f6f60 - Browse repository at this point
Copy the full SHA 26f6f60View commit details -
Fix Android 4.1-4.3 WebView source baseUrl bug
Summary: Resolves #11753 and #9835. Android versions 4.1-4.3 don't understand the MIME type `text/html; charset=utf-8` and default to `text/plain` instead, rendering the content as an unparsed HTML string. Since the encoding is already set and passed separately, removing it from the MIME type has no negative effects. The same fix has already been discussed, successfully tested and incorporated in NativeScript/NativeScript#1038. Closes #13789 Differential Revision: D5971910 Pulled By: shergin fbshipit-source-id: 07795bdf0f13ddb1e8eec779d1cad59244f3687e
Configuration menu - View commit details
-
Copy full SHA for 59d9f8c - Browse repository at this point
Copy the full SHA 59d9f8cView commit details -
Return instancetype for shared RCTI18nUtil instance
Summary: In modern Objective-C you should use the `instancetype` keyword for methods which return an instance of the class they are called on. See Apple's [Adopting Modern Objective-C](https://developer.apple.com/library/content/releasenotes/ObjectiveC/ModernizationObjC/AdoptingModernObjective-C/AdoptingModernObjective-C.html) guide. Because `sharedInstance` was returning an object of type `id`, the returned value needed to be cast before it could be used in Swift. I also changed the implementation of `sharedInstance` to use Grand Central Dispatch, which is the generally accepted best way of creating a singleton in Objective-C. I verified my changes with the "RTLExample" app in RNTester. | LTR | RTL | |---|---| |<img width="300" src="https://user-images.githubusercontent.com/1413388/31155210-6454b4d6-a87a-11e7-9dd7-9a52f3924737.png">|<img width="300" src="https://user-images.githubusercontent.com/1413388/31155233-8702aff6-a87a-11e7-8028-51cf2b3eb0c4.png">| Closes #16196 Differential Revision: D5971898 Pulled By: shergin fbshipit-source-id: dfa375c89248adfc9fd885cacc6a6d4cbfea6e90
Configuration menu - View commit details
-
Copy full SHA for 09680f7 - Browse repository at this point
Copy the full SHA 09680f7View commit details -
Improve YellowBox output format
Summary: YellowBox currently assumes the first arg is a printf like format string, this adds support for any arguments so it works more like console in the browser. This also adds `stringifySafe` to format arguments when using printf style. The main annoyance that this fixes is when trying to log a single object it will currently print [object Object] instead of the fully stringified version. **Test plan** Tested a bunch of different log combinations. ```js console.warn({test: 'a'}); // {"test":"a"} (was [object Object] before this patch) console.warn('test %s %s', 1, {}); // test 1 {} console.warn('test %s', 1, {}); // test 1 {} console.warn({}, {}, {}, {}); // {} {} {} {} ``` Closes #16132 Differential Revision: D5973125 Pulled By: yungsters fbshipit-source-id: fc17105a79473a11c9b1c4728d435fc54fb094bb
1Configuration menu - View commit details
-
Copy full SHA for eae4fe8 - Browse repository at this point
Copy the full SHA eae4fe8View commit details -
Move URL escaping to Inspector layer
Reviewed By: Hypuk Differential Revision: D5967544 fbshipit-source-id: d741e6324aff7583778cb13c862505b61ca02a3d
Configuration menu - View commit details
-
Copy full SHA for ef2e29f - Browse repository at this point
Copy the full SHA ef2e29fView commit details -
Remove usage of "this" in a callback in RCTNativeModule
Summary: As RCTNativeModule can be destructed at any time, it's unsafe to capture "this" in a callback. Reviewed By: javache Differential Revision: D5963728 fbshipit-source-id: c80a01c851d97813e4fead2b31c442eaeb8ae204
Configuration menu - View commit details
-
Copy full SHA for d07279c - Browse repository at this point
Copy the full SHA d07279cView commit details -
Reviewed By: marco-cova Differential Revision: D5880274 fbshipit-source-id: e6741579d3de6090dea8d26cd07241d57adba84d
1Configuration menu - View commit details
-
Copy full SHA for 7677af1 - Browse repository at this point
Copy the full SHA 7677af1View commit details -
React sync for revisions b5ac963...5f93ee6f6
Reviewed By: gaearon Differential Revision: D5950896 fbshipit-source-id: 74aebcee8a64e8552b170223adf59ed4ed905a74
3Configuration menu - View commit details
-
Copy full SHA for 678a7f3 - Browse repository at this point
Copy the full SHA 678a7f3View commit details -
Add error customizer for React Native Android
Reviewed By: achen1 Differential Revision: D5954205 fbshipit-source-id: 8b92bf1484a037b333a6f0f4aeddd39ffee25361
1Configuration menu - View commit details
-
Copy full SHA for 0c234c9 - Browse repository at this point
Copy the full SHA 0c234c9View commit details -
Documentation about ABI split in Android Release
Summary: It leads to a reduction of 5-7MB for an app, which is a considerable saving when it comes to emerging markets. Also, I had written a [comment](#5037 (comment)) on an issue which seems to have helped at least 26 people. Closes #16197 Differential Revision: D5978945 Pulled By: TheSavior fbshipit-source-id: 391a992e2d8e62e59fb20e5d5f8e5f59c00b6295
1Configuration menu - View commit details
-
Copy full SHA for d0260b4 - Browse repository at this point
Copy the full SHA d0260b4View commit details -
Standard Flow type for style prop
Reviewed By: sahrens Differential Revision: D5978082 fbshipit-source-id: bd251ed3ecc1f15595e2f5ee941e3865a225c1fd
1Configuration menu - View commit details
-
Copy full SHA for 9c29ee1 - Browse repository at this point
Copy the full SHA 9c29ee1View commit details -
Summary: Update logo URL https://facebook.github.io/react/img/logo_og.png (old) to https://facebook.github.io/react/logo-og.png (new) Check that the old URL shows a "Page Not Found" and the new URL the correct image. Closes #16204 Differential Revision: D5978967 Pulled By: TheSavior fbshipit-source-id: f6af03dfd25d68c96e01054c256d8b6ba9fedba2
1Configuration menu - View commit details
-
Copy full SHA for 2d2dfa2 - Browse repository at this point
Copy the full SHA 2d2dfa2View commit details -
Differential Revision: D5963184 fbshipit-source-id: 206f0d52b66f4f1af284445b10a8a4ff7b2cc36d
1Configuration menu - View commit details
-
Copy full SHA for bee33a4 - Browse repository at this point
Copy the full SHA bee33a4View commit details -
Fix the debug logging regression
Reviewed By: AaaChiuuu Differential Revision: D5975880 fbshipit-source-id: 39c632ddf84e57c814b54fac465651120e4127da
1Configuration menu - View commit details
-
Copy full SHA for adde2ed - Browse repository at this point
Copy the full SHA adde2edView commit details -
Unify supplimentary bundle path creation logic between Android and iOS
Differential Revision: D5941546 fbshipit-source-id: c9b8fab887f480faa373c26a1d5ba310e8acde78
1Configuration menu - View commit details
-
Copy full SHA for 9e01d72 - Browse repository at this point
Copy the full SHA 9e01d72View commit details
Commits on Oct 5, 2017
-
Unify sampling profiler and reload logic by leveraging RCTPackagerCon…
…nection Differential Revision: D5951952 fbshipit-source-id: ceea04ebbddb02944717a266a14523be052ab213
1Configuration menu - View commit details
-
Copy full SHA for afec987 - Browse repository at this point
Copy the full SHA afec987View commit details -
Summary: Remove RCTWebSocketObserver as it's not used anywhere in the project. Reviewed By: shergin Differential Revision: D5960354 fbshipit-source-id: a5b9d128f7cf9384a9fa9ed20e869801023e1d57
1Configuration menu - View commit details
-
Copy full SHA for 7f6a7ae - Browse repository at this point
Copy the full SHA 7f6a7aeView commit details -
Fixed crash in [UIManager setLocalData:]
Summary: This is pretty normal and harmless case, we should not crash here. I plan to refactor similar places in this file soon. Reviewed By: AaaChiuuu Differential Revision: D5983443 fbshipit-source-id: 922fea8ed12ebef45d249f16739aa81fe3254f19
1Configuration menu - View commit details
-
Copy full SHA for f8e1386 - Browse repository at this point
Copy the full SHA f8e1386View commit details -
Replace getInt with asInt in native collections
Reviewed By: mhorowitz Differential Revision: D5904751 fbshipit-source-id: 995412196fd76ea60a65253719e49852322be6e6
1Configuration menu - View commit details
-
Copy full SHA for 790eabc - Browse repository at this point
Copy the full SHA 790eabcView commit details -
Remove AdSupport from React.podspec
Summary: Closes #16168 Differential Revision: D5988522 Pulled By: javache fbshipit-source-id: ac9c393915c249038eb34c4bd4f34ece58fe7975
1Configuration menu - View commit details
-
Copy full SHA for 1e3a8e2 - Browse repository at this point
Copy the full SHA 1e3a8e2View commit details -
Reviewed By: danzimm Differential Revision: D5969343 fbshipit-source-id: 376984a6e959349260c54884c0b0b719f4c353d6
1Configuration menu - View commit details
-
Copy full SHA for e87904c - Browse repository at this point
Copy the full SHA e87904cView commit details -
Updating blog post about RTL from setAllowRTL to allowRTL (Android).
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Updating blog post about RTL to use updated function `sharedI18nUtilInstance.allowRTL` for Android as mentioned in [this issue](#16166) Check [this blog post](https://facebook.github.io/react-native/blog/2016/08/19/right-to-left-support-for-react-native-apps.html). Closes #16184 Differential Revision: D5987016 Pulled By: hramos fbshipit-source-id: 96eb066e0326a550e84d290dc1397fdc2ca5c4f4
1Configuration menu - View commit details
-
Copy full SHA for 88a79b3 - Browse repository at this point
Copy the full SHA 88a79b3View commit details
Commits on Oct 6, 2017
-
Fix navigation links in documentation.
Summary: When navigating in the docs, these two links are broken. The "Continue Reading" in http://facebook.github.io/react-native/docs/more-resources.html page, and "Previous" in http://facebook.github.io/react-native/docs/platform-specific-code.html. This PR is to fix this. Closes #16236 Differential Revision: D5998970 Pulled By: hramos fbshipit-source-id: b339408eaada612133f6b63bd11967196ff3a039
1Configuration menu - View commit details
-
Copy full SHA for 2f2c3ea - Browse repository at this point
Copy the full SHA 2f2c3eaView commit details
Commits on Oct 7, 2017
-
1
Configuration menu - View commit details
-
Copy full SHA for 1b80118 - Browse repository at this point
Copy the full SHA 1b80118View commit details -
Fix minor typo in ScrollView doc
Summary: I don't think a test plan is required here! 😛 Closes #16243 Differential Revision: D6005196 Pulled By: hramos fbshipit-source-id: 3b46346e57e0d9971078c4807a4fa0045a8366b1
1Configuration menu - View commit details
-
Copy full SHA for f66c8f2 - Browse repository at this point
Copy the full SHA f66c8f2View commit details -
Fix warning on SectionList's tutorial
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> I wanted to fix issue #16231 - the warning is not displayed anymore: ![image](https://user-images.githubusercontent.com/2101647/31268083-7e2e0ddc-aac6-11e7-966b-b1e9ffa6cfa8.png) Closes #16232 Differential Revision: D6005386 Pulled By: hramos fbshipit-source-id: 33961ee7cd708c424c2665a38dc5e733f1ea2204
2Configuration menu - View commit details
-
Copy full SHA for c12681c - Browse repository at this point
Copy the full SHA c12681cView commit details -
Fixing test by updating snapshot for TouchableHighlight
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Tests were failing due to not updated snapshot about TouchableHighlight. Run `npm test`. Closes #16185 Differential Revision: D6005399 Pulled By: hramos fbshipit-source-id: eda5009b68ca121250817de448424105aec6f685
1Configuration menu - View commit details
-
Copy full SHA for 4ddc931 - Browse repository at this point
Copy the full SHA 4ddc931View commit details
Commits on Oct 8, 2017
-
Use UnimplementedView for CheckBox on iOS
Summary: `CheckBox` component was introduced in v0.49.0 and not implemented on iOS. Users who are trying to use `CheckBox` on iOS will get a warning that > Native component for "AndroidCheckBox" does not exist We should declare in the document that this component is Android only and use `UnimplementedView` for iOS. - Use `react-native init` new project - Apply pull request changes - Add `<Checkbox />` after welcome text in `App.js` - Run the app in iOS simulator Closes #16211 Differential Revision: D6005393 Pulled By: hramos fbshipit-source-id: 1c9b68b5e1c933496c4d7c2f487f0500264b603a
1Configuration menu - View commit details
-
Copy full SHA for f9be64a - Browse repository at this point
Copy the full SHA f9be64aView commit details -
Summary: In the spirit of #10932, I added the `mode` option to the `TimePicker` Android API. There is only one mode available for **Android < 5**, the `spinner` one. If we are on **Android >= 5** we can choose between `spinner` or `clock`. If we specify `default` it will use the default of the current Android version. On **Android < 5**, whatever we choose it will be this: ![screen shot 2017-02-14 at 17 05 44](https://cloud.githubusercontent.com/assets/5436545/22937805/024ec67e-f2da-11e6-8b32-a680d9bc2247.png) On **Android >= 5**, with the `spinner` mode: ![screen shot 2017-02-14 at 16 51 17](https://cloud.githubusercontent.com/assets/5436545/22937803/024e0bbc-f2da-11e6-9f4b-26102ff2eeac.png) And with the `clock` mode, the default: ![screen shot 2017-02-14 at 16 51 02](https://cloud.githubusercontent.com/assets/5436545/22937804/024e64e0-f2da-11e6-9911-4135049f4726.png) Closes #12384 Differential Revision: D6006689 Pulled By: hramos fbshipit-source-id: fcd37c867c4061b9982b1687f2c10211e54df7cf
1Configuration menu - View commit details
-
Copy full SHA for 1c24440 - Browse repository at this point
Copy the full SHA 1c24440View commit details
Commits on Oct 9, 2017
-
Introducing PseudoUIManagerQueue
Summary: Queues Problem Intro: UIManager queue is special queue because it has special relationship with the Main queue. This particular relationship comes from two key factors: 1. UIManager initiates execution of many blocks on the Main queue; 2. In some cases, we want to initiate (and wait for) some UIManager's work *synchronously* from the Main queue. So, how can we meet these criteria? "Pseudo UIManager queue" comes to rescue! "Pseudo UIManager queue" means safe execution of typical UIManager's work on the Main queue while the UIManager queue is explicitly blocked for preventing simultaneous/concurrent memory access. So, how can we technically do this? 1. `RCTAssertUIManagerQueue` is okay with execution on both actual UIManager and Pseudo UIManager queues. 2. Both `RCTExecuteOnUIManagerQueue` and `RCTUnsafeExecuteOnUIManagerQueueSync` execute given block *synchronously* if they were called on actual UIManager or Pseudo UIManager queues. 3. `RCTExecuteOnMainQueue` executes given block *synchronously* if we already on the Main queue. 4. `RCTUnsafeExecuteOnUIManagerQueueSync` is smart enough to do the trick: It detects calling on the Main queue and in this case, instead of doing trivial *synchronous* dispatch, it does: - Block the Main queue; - Dispatch the special block on UIManager queue to block the queue and concurrent memory access; - Execute the given block on the Main queue; - Unblock the UIManager queue. Imagine the analogy: We have two queues: the Main one and UIManager one. And these queues are two lanes of railway go in parallel. Then, at some point, we merge UIManager lane with the Main lane, and all cars use the unified the Main lane. And then we split lanes again. This solution assumes that the code running on UIManager queue will never *explicitly* block the Main queue via calling `RCTUnsafeExecuteOnMainQueueSync`. Otherwise, it can cause a deadlock. Reviewed By: mmmulani Differential Revision: D5935464 fbshipit-source-id: 6a60ff236280d825b4e2b101f06222266097b97f
1Configuration menu - View commit details
-
Copy full SHA for 5e25c0e - Browse repository at this point
Copy the full SHA 5e25c0eView commit details -
RCTTextInput: Fixed problem with accessory view & 3rd party libs
Summary: Now RCTTextInput relies on ivar to detect should it reconstruct inputAccessoryView or not. Previously we checked `inputAccessoryView` directly which breaks some 3rd party libs. See #16071 for more details. cc douglasjunior Reviewed By: javache Differential Revision: D5994798 fbshipit-source-id: c086efdd24f5528393a4c734ff7c984e0ed740d1
1Configuration menu - View commit details
-
Copy full SHA for bf36983 - Browse repository at this point
Copy the full SHA bf36983View commit details -
Using
StyleSheet.hairlineWidth
in TextInputExampleSummary: This is workaround for blury and thick borders on iOS when specified border size does not multiplier of pixel size. Original problem is probably related to CALayer border drawing specifics; documented as T22099662 and #14106 Before: https://pxl.cl/9cJ7 After: https://pxl.cl/9cJ4 Reviewed By: javache Differential Revision: D5999752 fbshipit-source-id: ad6d1078c6ebf7c8e0a3bc3c150525480a5a7a5c
1Configuration menu - View commit details
-
Copy full SHA for 9e220da - Browse repository at this point
Copy the full SHA 9e220daView commit details -
[RCTShadowView localData]
is now only setter.Summary: It saves 8 bytes per shadowView instance, and it is more logical because it does nothing by default. Reviewed By: javache Differential Revision: D5997804 fbshipit-source-id: c985a11aeea881e95911469e10c8c27429a2718a
1Configuration menu - View commit details
-
Copy full SHA for b0c1bd2 - Browse repository at this point
Copy the full SHA b0c1bd2View commit details -
Updated project file to fix Apple TV build
Reviewed By: rsnara Differential Revision: D6015068 fbshipit-source-id: 3c2cd902457e32dab843764267a1475a078eb64d
1Configuration menu - View commit details
-
Copy full SHA for aa97c9a - Browse repository at this point
Copy the full SHA aa97c9aView commit details
Commits on Oct 10, 2017
-
Summary: RCTWrapper is a library that allows turn any UIView/UIViewController-based widget into React Native component which will respect layout constrains of native (wrapped) view. So, you don't need to explicitly specify width and hight in styling. Take a look at examples to see how to use RCTWrapper. Reviewed By: mmmulani Differential Revision: D5868763 fbshipit-source-id: 0a503b42be166d547ca6cbf0829eea9c75a8e364
1Configuration menu - View commit details
-
Copy full SHA for c0e9936 - Browse repository at this point
Copy the full SHA c0e9936View commit details -
Deprecated stuff was removed from RCTUIManager
Summary: It was deprecated awhile ago. Reviewed By: javache Differential Revision: D5990505 fbshipit-source-id: 68deefb76fee31a49bfe832e281dc8ee11061cb8
1Configuration menu - View commit details
-
Copy full SHA for 4342879 - Browse repository at this point
Copy the full SHA 4342879View commit details -
Deprecated stuff was removed from RCTShadowView
Summary: It was deprecated awhile ago. Reviewed By: javache Differential Revision: D5990504 fbshipit-source-id: a218410d17f5f450d573338522b689e035106aba
1Configuration menu - View commit details
-
Copy full SHA for 32e5c8e - Browse repository at this point
Copy the full SHA 32e5c8eView commit details -
Summary: CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable. **Test plan** Quick manual test, cosmetic changes only. Closes #16229 Differential Revision: D6009748 Pulled By: TheSavior fbshipit-source-id: cabd44fed99dd90bd0b35626492719c139c89f34
1Configuration menu - View commit details
-
Copy full SHA for 0cd69e8 - Browse repository at this point
Copy the full SHA 0cd69e8View commit details -
Updated swift section to match current code base
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Current documentation was outdated. Follow the swift section with a recent version of RN and see that it works? Closes #16260 Differential Revision: D6017759 Pulled By: hramos fbshipit-source-id: 5d3ea56b08427694016c39b7ace5b2d5c63c1f4c
Configuration menu - View commit details
-
Copy full SHA for 3eced7f - Browse repository at this point
Copy the full SHA 3eced7fView commit details -
Direct assignment of the ref to avoid warning when mocking.
Summary: When Jest is mocking native components that are assigned a ref with an arrow function, a warning is generated about stateless components which can not have a ref. This does not happen when the ref is assigned directly. Fixes #16045. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> The test provided in the related issue is used to validate the fix. I don't know how to detect console warnings in a Jest test. Closes #16046 Differential Revision: D6017903 Pulled By: ericnakagawa fbshipit-source-id: a7ed61c39f141a4094f08fc875289a7a79ebe9e8
Configuration menu - View commit details
-
Copy full SHA for bbceb48 - Browse repository at this point
Copy the full SHA bbceb48View commit details -
Document adb shell input keyevent 82
Summary: This information could be found already in older docs see https://facebook.github.io/react-native/releases/0.21/docs/running-on-device-android.html#accessing-development-server-from-device. It is missing from latest. I think it's important alternative since shaking my device all the time borked my USB port Closes #16241 Differential Revision: D6017905 Pulled By: shergin fbshipit-source-id: 9426b4068a6bc60aed50f85b2f596d0494def52a
1Configuration menu - View commit details
-
Copy full SHA for b9da155 - Browse repository at this point
Copy the full SHA b9da155View commit details -
Add finally method to Promise flow definition
Summary: The `finally` method definition was missing, while it really exists causing a flow error when using it. Added the method definition and make sure flow doesn't throw any error anymore on a real-life example. Closes #16115 Differential Revision: D6017950 Pulled By: shergin fbshipit-source-id: 296f3467152eb6eedac817a89cf075e9f906a389
Configuration menu - View commit details
-
Copy full SHA for 4eccb16 - Browse repository at this point
Copy the full SHA 4eccb16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b4f49 - Browse repository at this point
Copy the full SHA 57b4f49View commit details -
Change attribute mentioned in alignItem
Summary: Since alignItem works on the secondary axis, in the example, the value heigth: 50 should be deleted so that alignItem: 'stretch' can work. Not width: 50. In fact, width needs to be there, or else no component will be shown at all. <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> (Write your motivation here.) I'm going through the docs, that's why I found this. It's already tested! Apologize if I'm contributing the wrong way. I read the instructions, but this is my first time ever, and will try to do it again correctly if needed. Closes #16109 Differential Revision: D6017969 Pulled By: shergin fbshipit-source-id: af37b831f1bb6206dabdaff36d4cb9e88fb1a496
Configuration menu - View commit details
-
Copy full SHA for 7c89cf3 - Browse repository at this point
Copy the full SHA 7c89cf3View commit details -
Omit all line terminators for ImageStore.getBase64ForTag
Summary: FIX #11142 This fixes #11142 and supersedes #11155 as I was unsure how to add/change commits in that PR. Wrote up a bunch of unit tests for the ImageStore module. The added tests showed that there was indeed a problem with the flags used for the Base64OutputStream, and they also show that that has been fixed now. Closes #13856 Differential Revision: D6017764 Pulled By: shergin fbshipit-source-id: adf667dc722ddfe31449afd8cd20a0a192eacff6
Configuration menu - View commit details
-
Copy full SHA for 7a7bdee - Browse repository at this point
Copy the full SHA 7a7bdeeView commit details -
Correct propTypes for placeholder
Summary: Proptype mistake, placeholder is a "string" not a "node". https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/Libraries/Text/RCTBackedTextInputViewProtocol.h#L18 https://github.com/facebook/react-native/blob/4d54b48167c99d0f3a8917e7637ffe3304c6bed6/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L300 Closes #16237 Differential Revision: D6017909 Pulled By: shergin fbshipit-source-id: 75046080a0f33196832f5d4ab58f8b1f4aabad1f
Configuration menu - View commit details
-
Copy full SHA for dbe6044 - Browse repository at this point
Copy the full SHA dbe6044View commit details -
Issue #16159 - RCTImageStoreManager's priority
Summary: RCTImageStoreManager and RCTBlobManager have the same priority, hence in certain cases, both are able to handle the request, but this causes non-deterministic behavior. Hence increased ImageStoreManager's Priority to 1 and thereby increasing RCTImageLoader's Priority to 2 to prevent similar issue of same priorities. Issue: #16159 Closes #16160 Differential Revision: D6017931 Pulled By: shergin fbshipit-source-id: 91f2737af4f2f97197734b696105e1cdc5683365
Configuration menu - View commit details
-
Copy full SHA for 4e5d50d - Browse repository at this point
Copy the full SHA 4e5d50dView commit details -
Handling exceptions in video player
Reviewed By: furdei Differential Revision: D5958119 fbshipit-source-id: 79b431a8422d60134890d44e99c358a07a5adc5b
Configuration menu - View commit details
-
Copy full SHA for 9424cd7 - Browse repository at this point
Copy the full SHA 9424cd7View commit details -
Fix that section headers in SectionList don't stick at correct position.
Summary: I noticed that section headers in SectionList don't stick at correct position in case of using with contentInset and contentOffset. (See the demo below. It looks that contentInset.top is ignored.) This is a common case of use of NavigationBar and TableView on iOS. ![](https://user-images.githubusercontent.com/143255/29018708-1e2f98aa-7b97-11e7-9599-19dbb832266d.gif) Here is a demo and an example code: ![](https://user-images.githubusercontent.com/143255/29018753-4201f660-7b97-11e7-9d31-28413d1b6269.gif) ```jsx import React, { Component } from 'react'; import { AppRegistry, StyleSheet, Text, View, SectionList, } from 'react-native'; export default class RNScrollExample extends Component { renderSectionHeader(title) { return ( <View style={styles.sectionHeader}> <Text>{title}</Text> </View> ) } renderItem(content) { return ( <View style={styles.cell}> <Text>{`Item ${content}`}</Text> </View> ) } renderSeparator() { return <View style={styles.separator} /> } renderSectionList() { const sections = Array.from(Array(10), (e, i) => ({ title: `Section ${i+1}`, data: Array.from(Array(10)).map((e, i) => i+1) })) const navigationBarHeight = 64 return ( <SectionList contentInset={{ top: navigationBarHeight }} contentOffset={{ y: -navigationBarHeight }} sections={sections} keyExtractor={(item, index) => index} renderSectionHeader={({ section }) => this.renderSectionHeader(section.title)} renderItem={({ item }) => this.renderItem(item)} ItemSeparatorComponent={this.renderSeparator} /> ) } renderHeader() { return ( <View style={styles.header}> <Text style={styles.headerText}>Contents</Text> </View> ) } render() { return ( <View> {this.renderSectionList()} {this.renderHeader()} </View> ) } } const styles = StyleSheet.create({ header: { position: 'absolute', top: 0, left: 0, right: 0, height: 64, paddingTop: 20, justifyContent: 'center', alignItems: 'center', backgroundColor: '#ffffffcc', }, headerText: { fontSize: 16, fontWeight: 'bold', }, sectionHeader: { paddingHorizontal: 8, paddingVertical: 4, backgroundColor: '#05bbd3', }, cell: { paddingHorizontal: 8, paddingVertical: 16, backgroundColor: '#82dde9', }, separator: { height: 1, backgroundColor: '#7d888d', }, }); AppRegistry.registerComponent('RNScrollExample', () => RNScrollExample); ``` Closes #15395 Differential Revision: D5988720 Pulled By: shergin fbshipit-source-id: d33f6ee943d4f913970e26c322b66b3c9c948a02
Configuration menu - View commit details
-
Copy full SHA for a541d58 - Browse repository at this point
Copy the full SHA a541d58View commit details -
Summary: We can't use spread syntax here. Prefer Array.concat(). Reviewed By: sahrens Differential Revision: D6014142 fbshipit-source-id: d2759893ea2df69975843ae821fb08b16b1d5d7c
Configuration menu - View commit details
-
Copy full SHA for d501713 - Browse repository at this point
Copy the full SHA d501713View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4193b81 - Browse repository at this point
Copy the full SHA 4193b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for e28f563 - Browse repository at this point
Copy the full SHA e28f563View commit details