Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use uniqBy for iteratee support #15615

Closed
wants to merge 2 commits into from
Closed

use uniqBy for iteratee support #15615

wants to merge 2 commits into from

Conversation

arahansen
Copy link
Contributor

I noticed uniq does not take a second parameter the way it's being used here. I think the function what was intended is uniqBy

@arahansen
use uniqBy for iteratee support
efb27b7 
I noticed `uniq` does not take a second parameter the way it's being used here. I think the function what was intended is `uniqBy`
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@pull-bot
Copy link

pull-bot commented Aug 23, 2017 •
edited
Loading

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

@facebook-github-bot label Needs more information

Attention: @grabbou, @Kureev

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@grabbou
Copy link
Contributor

grabbou commented Sep 1, 2017

Good catch! This error was introduced before we even merged this to react-native.

CC: @Kureev when replacing self-written helpers (in this case - ./uniq.js that I made) with loadsh version - we forgot to use uniqBy and as a result - stopped respecting the function.

@grabbou
Copy link
Contributor

grabbou commented Sep 1, 2017

Thanks for this! I have updated the branch to see if the tests stop failing.

Kureev
Kureev approved these changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@Kureev Kureev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Yeah, I've seen this PR a while ago, but didn't have time to take a look on a real use case. Thanks for taking care, @grabbou! I approve this.

@Kureev
Copy link
Contributor

Kureev commented Sep 18, 2017

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Sep 18, 2017
@facebook-github-bot
Copy link
Contributor

@Kureev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Kureev Kureev mentioned this pull request Sep 18, 2017
Closed
@deecewan
Copy link
Contributor

@Kureev any idea when this will make it into a release?

@arahansen arahansen deleted the patch-1 branch September 28, 2017 00:20
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@arahansen @facebook-github-bot
use uniqBy for iteratee support
9d44cfe 
Summary:
I noticed `uniq` does not take a second parameter the way it's being used here. I think the function what was intended is [uniqBy](https://lodash.com/docs/4.17.4#uniqBy)
Closes facebook/react-native#15615

Differential Revision: D5852155

Pulled By: hramos

fbshipit-source-id: 892d0bf7f24d30c24620350f698ffb416907ccc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kureev Kureev Kureev approved these changes

@grabbou grabbou grabbou approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arahansen @facebook-github-bot @pull-bot @grabbou @Kureev @deecewan