-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use uniqBy
for iteratee support
#15615
Conversation
I noticed `uniq` does not take a second parameter the way it's being used here. I think the function what was intended is `uniqBy`
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Good catch! This error was introduced before we even merged this to react-native. CC: @Kureev when replacing |
Thanks for this! I have updated the branch to see if the tests stop failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Yeah, I've seen this PR a while ago, but didn't have time to take a look on a real use case. Thanks for taking care, @grabbou! I approve this.
@facebook-github-bot shipit |
@Kureev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@Kureev any idea when this will make it into a release? |
Summary: I noticed `uniq` does not take a second parameter the way it's being used here. I think the function what was intended is [uniqBy](https://lodash.com/docs/4.17.4#uniqBy) Closes facebook/react-native#15615 Differential Revision: D5852155 Pulled By: hramos fbshipit-source-id: 892d0bf7f24d30c24620350f698ffb416907ccc5
I noticed
uniq
does not take a second parameter the way it's being used here. I think the function what was intended is uniqBy