Updated support for WebStorm #15984
Updated support for WebStorm #15984
Conversation
Added the executable path to the COMMON_EDITORS Added the executable name to the arguments selections
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -37,6 +37,7 @@ var COMMON_EDITORS = { | |||
| '/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2': | |||
| '/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl', | |||
| '/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code', | |||
| '/Applications/WebStorm.app/Contents/MacOS/webstorm': 'webstorm', | |||
There was a problem hiding this comment.
Cool; I didn't realize that's how it's wired up in React-Native. Just out of curiosity, do we need to add support for other IntelliJ products, like RubyMine + IntelliJ? 🤔
/Applications/RubyMine.app/Contents/MacOS/rubymine
There was a problem hiding this comment.
Of course, if people use RubyMine for RN development and it has a command line tool for opening files. I know that webstorm and idea have, but appcode doesn't seem to have one...
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Added the executable path to the `COMMON_EDITORS` Added the executable name to the arguments selections <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Need to be able to jump to specific files and line numbers in WebStorm and autodetect WebStorm as editor, without setting up any environment vars. Start a new RN project in WebStorm, make some JS errors and click the errors to confirm that it will jump to the right file and line number in WebStorm. Make sure that none of the other `COMMON_EDITORS` are running, unless you set the `REACT_EDITOR` environment variable. Closes facebook/react-native#15984 Differential Revision: D5911698 Pulled By: shergin fbshipit-source-id: 54fced7539520553dd2a93bf7ca7e4f457b0bfc3
Added the executable path to the
COMMON_EDITORSAdded the executable name to the arguments selections
Need to be able to jump to specific files and line numbers in WebStorm and autodetect WebStorm as editor, without setting up any environment vars.
Test Plan
Start a new RN project in WebStorm, make some JS errors and click the errors to confirm that it will jump to the right file and line number in WebStorm.
Make sure that none of the other
COMMON_EDITORSare running, unless you set theREACT_EDITORenvironment variable.