Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated support for WebStorm #15984

Closed
wants to merge 3 commits into from
Closed

Updated support for WebStorm #15984

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e8fa9
Updated support for Webstorm
esbenvb Sep 18, 2017
1b2518e
Update launchEditor.js
esbenvb Sep 18, 2017
d201c0e
Merge branch 'master' into patch-1
shergin Sep 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions local-cli/server/util/launchEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ var COMMON_EDITORS = {
'/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2':
'/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl',
'/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code',
'/Applications/WebStorm.app/Contents/MacOS/webstorm': 'webstorm',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; I didn't realize that's how it's wired up in React-Native. Just out of curiosity, do we need to add support for other IntelliJ products, like RubyMine + IntelliJ? 🤔

/Applications/RubyMine.app/Contents/MacOS/rubymine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, if people use RubyMine for RN development and it has a command line tool for opening files. I know that webstorm and idea have, but appcode doesn't seem to have one...

};

function addWorkspaceToArgumentsIfExists(args, workspace) {
Expand All @@ -56,6 +57,7 @@ function getArgumentsForLineNumber(editor, fileName, lineNumber, workspace) {
case 'Atom Beta':
case 'subl':
case 'sublime':
case 'webstorm':
case 'wstorm':
case 'appcode':
case 'charm':
Expand Down