-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ESLint cache file into node_modules #9977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsankhfr
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
November 1, 2020 11:13
n3tr
reviewed
Nov 1, 2020
ianschmitz
suggested changes
Nov 25, 2020
I simplified the impl. a fair bit. Here's some more context: eslint/eslint#11757 |
ianschmitz
changed the title
fix: eslint cache destination folder change
Move ESLint cache file into node_modules
Dec 8, 2020
mwbennett
added a commit
to Ravel-Labs/platform
that referenced
this pull request
Dec 19, 2020
Running into an issue locally where .eslintcache file is constantly generated. Looks to be the same issue as described here: facebook/create-react-app#10161. This commit is a temporary fix until create-react-app v4.0.2 is released to move default location of eslintcache file. See facebook/create-react-app#9977.
This was referenced Jan 12, 2021
Closed
garethsb
added a commit
to orfar1994/nmos-js
that referenced
this pull request
Jan 15, 2021
Closed
dimadk24
added a commit
to dimadk24/english-fight-ui
that referenced
this pull request
Feb 3, 2021
dimadk24
added a commit
to dimadk24/english-fight-ui
that referenced
this pull request
Feb 4, 2021
collinbarrett
added a commit
to collinbarrett/FilterLists
that referenced
this pull request
Feb 4, 2021
This reverts commit e3116f1. ref facebook/create-react-app#9977
blackarctic
added a commit
to blackarctic/create-react-app
that referenced
this pull request
Apr 29, 2021
* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921) Co-authored-by: Konstantin Simeonov <[email protected]> * Add logo license to README * Remove trailing space in reportWebVitals.ts (facebook#10040) * docs: add React Testing Library as a library requiring jsdom (facebook#10052) Co-authored-by: Ian Schmitz <[email protected]> * Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048) * Create FUNDING.yml * replace inquirer with prompts (facebook#10083) - remove `react-dev-utils/inquirer` public import * Prepare 4.0.1 release * Prepare 4.0.1 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * chore: bump web-vital dependency version (facebook#10143) * chore: bump typescript version (facebook#10141) Co-authored-by: Ian Schmitz <[email protected]> * Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964) * remove chalk from formatWebpackMessages (facebook#10198) * Upgrade @svgr/webpack to fix build error (facebook#10213) Co-authored-by: Ian Schmitz <[email protected]> * Improve vendor chunk names in development (facebook#9569) * Update postcss packages (facebook#10003) Co-authored-by: Ian Schmitz <[email protected]> * Recovered some integration tests (facebook#10091) * Upgrade sass-loader (facebook#9988) * Move ESLint cache file into node_modules (facebook#9977) Co-authored-by: Ian Schmitz <[email protected]> * Revert "Update postcss packages" (facebook#10216) This reverts commit 580ed5d. * Remove references to Node 8 (facebook#10214) * fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872) * Update using-the-public-folder.md (facebook#10314) Some library --> Some libraries * docs: add missing override options for Jest config (facebook#9473) * Fix CI tests (facebook#10217) * appTsConfig immutability handling by immer (facebook#10027) Co-authored-by: mad-jose <[email protected]> * Add support for new BUILD_PATH advanced configuration variable (facebook#8986) * Add opt-out for eslint-webpack-plugin (facebook#10170) * Prepare 4.0.2 release * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * tests: update test case to match the description (facebook#10384) * Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312) Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs * Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590) * update immer to 8.0.1 to address vulnerability (facebook#10412) Resolves facebook#10411 Bumps immer version to 8.0.1 to address the prototype pollution vulnerability with the current 7.0.9 version. * Prepare 4.0.3 release * Update CHANGELOG * Publish - [email protected] - [email protected] - [email protected] Co-authored-by: Ryota Murakami <[email protected]> Co-authored-by: Konstantin Simeonov <[email protected]> Co-authored-by: Ian Sutherland <[email protected]> Co-authored-by: sho90 <[email protected]> Co-authored-by: Anyul Rivas <[email protected]> Co-authored-by: Ian Schmitz <[email protected]> Co-authored-by: Jeffrey Posnick <[email protected]> Co-authored-by: Evan Bacon <[email protected]> Co-authored-by: Sahil Purav <[email protected]> Co-authored-by: Hakjoon Sim <[email protected]> Co-authored-by: Chris Shepherd <[email protected]> Co-authored-by: Jason Williams <[email protected]> Co-authored-by: Jabran Rafique⚡️ <[email protected]> Co-authored-by: John Ruble <[email protected]> Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]> Co-authored-by: Sergey Makarov <[email protected]> Co-authored-by: EhsanKhaki <[email protected]> Co-authored-by: Kristoffer K <[email protected]> Co-authored-by: Aviv Hadar <[email protected]> Co-authored-by: Tobias Büschel <[email protected]> Co-authored-by: mad-jose <[email protected]> Co-authored-by: mad-jose <[email protected]> Co-authored-by: Andrew Hyndman <[email protected]> Co-authored-by: Brody McKee <[email protected]> Co-authored-by: James George <[email protected]> Co-authored-by: Dion Woolley <[email protected]> Co-authored-by: Walker Clem <[email protected]>
wombleton
pushed a commit
to AurorNZ/create-react-app
that referenced
this pull request
Jun 1, 2021
Co-authored-by: Ian Schmitz <[email protected]>
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 19, 2023
Co-authored-by: Ian Schmitz <[email protected]>
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
Co-authored-by: Ian Schmitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9970
Fix #10161
As mentioned in #9977 (comment), likewise
eslint-loader
, we need to support non-existing OR inaccessible path fallback for cache folder intoos.tempdir
, as current(new) eslint plugin doesn't support the fallback.TEST PLAN:
To test how permission issue folder fallback works:
node_module
.cache
folder content, if folder exists..cache
folderchmod u=r--,g=r--,o=r-- node_modules/.cache
npm start
ls node_modules/.cache
should not show the.eslintcache
fileTo test how non-existent folder fallback works:
node_module
.cache
folder content, if folder existsnpm start
ls node_modules/.cache
should not show the.eslintcache
fileTo test how normal flow of caching works:
node_module
.cache
folder exists.cache
:chmod u=rwx,g=r-x,o=r-x node_modules/.cache
npm start
ls node_modules/.cache
should show the.eslintcache
file