Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ESLint cache file into node_modules #9977

Merged
merged 4 commits into from
Dec 8, 2020

Conversation

ehsankhfr
Copy link
Contributor

@ehsankhfr ehsankhfr commented Nov 1, 2020

Fix #9970
Fix #10161

As mentioned in #9977 (comment), likewise eslint-loader, we need to support non-existing OR inaccessible path fallback for cache folder into os.tempdir, as current(new) eslint plugin doesn't support the fallback.

TEST PLAN:

To test how permission issue folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists.
    • Or, create .cache folder
  2. run chmod u=r--,g=r--,o=r-- node_modules/.cache
  3. run npm start
  4. ls node_modules/.cache should not show the .eslintcache file

To test how non-existent folder fallback works:

  1. under the node_module
    • Remove the .cache folder content, if folder exists
  2. run npm start
  3. ls node_modules/.cache should not show the .eslintcache file

To test how normal flow of caching works:

  1. under the node_module
    1. Make sure the .cache folder exists
    2. Make sure there is enough access to the folder .cache: chmod u=rwx,g=r-x,o=r-x node_modules/.cache
  2. run npm start
  3. ls node_modules/.cache should show the .eslintcache file

packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
packages/react-scripts/config/paths.js Outdated Show resolved Hide resolved
@ianschmitz
Copy link
Contributor

I simplified the impl. a fair bit. Here's some more context: eslint/eslint#11757

@ianschmitz ianschmitz changed the title fix: eslint cache destination folder change Move ESLint cache file into node_modules Dec 8, 2020
@ianschmitz ianschmitz merged commit e039ad3 into facebook:master Dec 8, 2020
mwbennett added a commit to Ravel-Labs/platform that referenced this pull request Dec 19, 2020
Running into an issue locally where .eslintcache file is constantly generated.
Looks to be the same issue as described here:
facebook/create-react-app#10161. This commit is a
temporary fix until create-react-app v4.0.2 is released to move default
location of eslintcache file. See
facebook/create-react-app#9977.
@raix raix mentioned this pull request Dec 22, 2020
25 tasks
garethsb added a commit to orfar1994/nmos-js that referenced this pull request Jan 15, 2021
@ehsankhfr ehsankhfr deleted the eslint-cache-file branch January 19, 2021 16:20
@mrmckeb mrmckeb mentioned this pull request Jan 20, 2021
dimadk24 added a commit to dimadk24/english-fight-ui that referenced this pull request Feb 3, 2021
dimadk24 added a commit to dimadk24/english-fight-ui that referenced this pull request Feb 4, 2021
collinbarrett added a commit to collinbarrett/FilterLists that referenced this pull request Feb 4, 2021
blackarctic added a commit to blackarctic/create-react-app that referenced this pull request Apr 29, 2021
* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921)

Co-authored-by: Konstantin Simeonov <[email protected]>

* Add logo license to README

* Remove trailing space in reportWebVitals.ts (facebook#10040)

* docs: add React Testing Library as a library requiring jsdom (facebook#10052)

Co-authored-by: Ian Schmitz <[email protected]>

* Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048)

* Create FUNDING.yml

* replace inquirer with prompts (facebook#10083)

- remove `react-dev-utils/inquirer` public import

* Prepare 4.0.1 release

* Prepare 4.0.1 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* chore: bump web-vital dependency version (facebook#10143)

* chore: bump typescript version (facebook#10141)

Co-authored-by: Ian Schmitz <[email protected]>

* Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

* remove chalk from formatWebpackMessages (facebook#10198)

* Upgrade @svgr/webpack to fix build error (facebook#10213)

Co-authored-by: Ian Schmitz <[email protected]>

* Improve vendor chunk names in development (facebook#9569)

* Update postcss packages (facebook#10003)

Co-authored-by: Ian Schmitz <[email protected]>

* Recovered some integration tests (facebook#10091)

* Upgrade sass-loader (facebook#9988)

* Move ESLint cache file into node_modules (facebook#9977)

Co-authored-by: Ian Schmitz <[email protected]>

* Revert "Update postcss packages" (facebook#10216)

This reverts commit 580ed5d.

* Remove references to Node 8 (facebook#10214)

* fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872)

* Update using-the-public-folder.md (facebook#10314)

Some library --> Some libraries

* docs: add missing override options for Jest config (facebook#9473)

* Fix CI tests (facebook#10217)

* appTsConfig immutability handling by immer (facebook#10027)

Co-authored-by: mad-jose <[email protected]>

* Add support for new BUILD_PATH advanced configuration variable (facebook#8986)

* Add opt-out for eslint-webpack-plugin (facebook#10170)

* Prepare 4.0.2 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* tests: update test case to match the description (facebook#10384)

* Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312)

Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs

* Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590)

* update immer to 8.0.1 to address vulnerability (facebook#10412)

Resolves facebook#10411

Bumps immer version to 8.0.1 to address the prototype pollution
vulnerability with the current 7.0.9 version.

* Prepare 4.0.3 release

* Update CHANGELOG

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Co-authored-by: Ryota Murakami <[email protected]>
Co-authored-by: Konstantin Simeonov <[email protected]>
Co-authored-by: Ian Sutherland <[email protected]>
Co-authored-by: sho90 <[email protected]>
Co-authored-by: Anyul Rivas <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Jeffrey Posnick <[email protected]>
Co-authored-by: Evan Bacon <[email protected]>
Co-authored-by: Sahil Purav <[email protected]>
Co-authored-by: Hakjoon Sim <[email protected]>
Co-authored-by: Chris Shepherd <[email protected]>
Co-authored-by: Jason Williams <[email protected]>
Co-authored-by: Jabran Rafique⚡️ <[email protected]>
Co-authored-by: John Ruble <[email protected]>
Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]>
Co-authored-by: Sergey Makarov <[email protected]>
Co-authored-by: EhsanKhaki <[email protected]>
Co-authored-by: Kristoffer K <[email protected]>
Co-authored-by: Aviv Hadar <[email protected]>
Co-authored-by: Tobias Büschel <[email protected]>
Co-authored-by: mad-jose <[email protected]>
Co-authored-by: mad-jose <[email protected]>
Co-authored-by: Andrew Hyndman <[email protected]>
Co-authored-by: Brody McKee <[email protected]>
Co-authored-by: James George <[email protected]>
Co-authored-by: Dion Woolley <[email protected]>
Co-authored-by: Walker Clem <[email protected]>
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.eslintcache constantly generated Change eslint loader cache location
5 participants