Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript 4.x as peerDependency to react-scripts #9964

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add TypeScript 4.x as peerDependency to react-scripts #9964

merged 1 commit into from
Nov 26, 2020

Conversation

sheepsteak
Copy link
Contributor

@sheepsteak sheepsteak commented Oct 30, 2020 •
edited
Loading

CRA is supposed to officially support TypeScript 4 as of 4.0.0 but react-scripts is still set at only allowing TypeScript as ^3.2.1. As the CRA TypeScript template comes with TypeScript 4 I think this is causing an install error for users on npm 7 as it now attempts to install peerDependencies by default but the TypeScript versions conflict.

If CRA now supports TypeScript 4 I think this is the correct change to make things right.

Closes #9892
Closes #9764 (not really related to this but it can close after this)
Closes #9995

@ianschmitz ianschmitz added this to the 4.0.1 milestone Oct 30, 2020
ianschmitz
ianschmitz reviewed Oct 30, 2020
View reviewed changes
.gitignore Outdated
@@ -13,3 +13,4 @@ yarn-error.log*
/.changelog
.npm/
yarn.lock
.eslintcache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert? We're going to update this save location in another PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I was just trying to figure it out 😄

@sheepsteak sheepsteak force-pushed the typescript-4-peer branch 2 times, most recently from 7d74490 to 3008a5b Compare October 30, 2020 15:48
@n3tr n3tr mentioned this pull request Nov 3, 2020
Closed
@ljharb ljharb mentioned this pull request Nov 5, 2020
Closed
This was referenced Nov 18, 2020
Open
Open
Open
Closed
@neolivz
Copy link

neolivz commented Nov 23, 2020

Can we merge this ASAP?

@iansu iansu modified the milestones: 4.0.1, 4.0.2 Nov 23, 2020
@dwelle dwelle mentioned this pull request Nov 23, 2020
Closed
@pd8
Copy link

pd8 commented Nov 23, 2020

Is there any movement on this PR, CRA team?
Currently have to get around this by doing npm i --legacy-peer-deps, however I don't want to rely on that for too long.

@ianschmitz ianschmitz changed the title Add TypeScript 4 as a valid peerDependency version of react-scripts Add TypeScript 4.x as peerDependency to react-scripts Nov 26, 2020
@ianschmitz ianschmitz merged commit 9b08e3c into facebook:master Nov 26, 2020
@sheepsteak sheepsteak deleted the typescript-4-peer branch November 26, 2020 08:37
@Semigradsky Semigradsky mentioned this pull request Dec 6, 2020
Closed
This was referenced Dec 17, 2020
Open
Open
This was referenced Dec 17, 2020
Open
Closed
@rati-dzidziguri
Copy link

Any update on this? We are also waiting on it and currently had to use a legacy flag, which is not a thing we want to have as a long-running thing.

@sheepsteak
Copy link
Contributor Author

It's been put in the 4.0.2 milestone but there are 15 other issues to be closed in it 😩

It's frustrating because it's merged and just sat there waiting. This would be a great thing to put out in a patch release by itself as the amount of people moving to npm7 will only be increasing.

I'll started a discussion to try and persuade the team to start making smaller releases - #10489

@rati-dzidziguri
Copy link

Please try to escalate this as Node 15 and NPM7 with workspaces are something that people are switching to, making it almost impossible to properly use the latest LTS software and force us to do the different hack.

@rati-dzidziguri
Copy link

rati-dzidziguri commented Feb 3, 2021 •
edited
Loading

Thank you so much 4.0.2 released 4 hours ago, and I can confirm the issue is fixed there.

@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2021
Open
@chludwig-haufe chludwig-haufe mentioned this pull request Apr 8, 2021
Closed
blackarctic added a commit to blackarctic/create-react-app that referenced this pull request Apr 29, 2021
@blackarctic @ryota-murakami
@KonstantinSimeonov @iansu @sho-t @anyulled @ianschmitz @jeffposnick @EvanBacon @trainto @sheepsteak @jasonwilliams @jabranr @jrr @raix @maxsbelt @ehsankhfr @merceyz @Avivhdr @tobiasbueschel @josezone @mad-jose @ajhyndman @mrmckeb @jamesgeorge007 @Awarua- @wclem4
Align with react-scripts 4.0.3 (#17)
109f05d 
* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921)

Co-authored-by: Konstantin Simeonov <[email protected]>

* Add logo license to README

* Remove trailing space in reportWebVitals.ts (facebook#10040)

* docs: add React Testing Library as a library requiring jsdom (facebook#10052)

Co-authored-by: Ian Schmitz <[email protected]>

* Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048)

* Create FUNDING.yml

* replace inquirer with prompts (facebook#10083)

- remove `react-dev-utils/inquirer` public import

* Prepare 4.0.1 release

* Prepare 4.0.1 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* chore: bump web-vital dependency version (facebook#10143)

* chore: bump typescript version (facebook#10141)

Co-authored-by: Ian Schmitz <[email protected]>

* Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

* remove chalk from formatWebpackMessages (facebook#10198)

* Upgrade @svgr/webpack to fix build error (facebook#10213)

Co-authored-by: Ian Schmitz <[email protected]>

* Improve vendor chunk names in development (facebook#9569)

* Update postcss packages (facebook#10003)

Co-authored-by: Ian Schmitz <[email protected]>

* Recovered some integration tests (facebook#10091)

* Upgrade sass-loader (facebook#9988)

* Move ESLint cache file into node_modules (facebook#9977)

Co-authored-by: Ian Schmitz <[email protected]>

* Revert "Update postcss packages" (facebook#10216)

This reverts commit 580ed5d.

* Remove references to Node 8 (facebook#10214)

* fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872)

* Update using-the-public-folder.md (facebook#10314)

Some library --> Some libraries

* docs: add missing override options for Jest config (facebook#9473)

* Fix CI tests (facebook#10217)

* appTsConfig immutability handling by immer (facebook#10027)

Co-authored-by: mad-jose <[email protected]>

* Add support for new BUILD_PATH advanced configuration variable (facebook#8986)

* Add opt-out for eslint-webpack-plugin (facebook#10170)

* Prepare 4.0.2 release

* Publish

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]

* tests: update test case to match the description (facebook#10384)

* Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312)

Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs

* Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590)

* update immer to 8.0.1 to address vulnerability (facebook#10412)

Resolves facebook#10411

Bumps immer version to 8.0.1 to address the prototype pollution
vulnerability with the current 7.0.9 version.

* Prepare 4.0.3 release

* Update CHANGELOG

* Publish

 - [email protected]
 - [email protected]
 - [email protected]

Co-authored-by: Ryota Murakami <[email protected]>
Co-authored-by: Konstantin Simeonov <[email protected]>
Co-authored-by: Ian Sutherland <[email protected]>
Co-authored-by: sho90 <[email protected]>
Co-authored-by: Anyul Rivas <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Jeffrey Posnick <[email protected]>
Co-authored-by: Evan Bacon <[email protected]>
Co-authored-by: Sahil Purav <[email protected]>
Co-authored-by: Hakjoon Sim <[email protected]>
Co-authored-by: Chris Shepherd <[email protected]>
Co-authored-by: Jason Williams <[email protected]>
Co-authored-by: Jabran Rafique⚡️ <[email protected]>
Co-authored-by: John Ruble <[email protected]>
Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]>
Co-authored-by: Sergey Makarov <[email protected]>
Co-authored-by: EhsanKhaki <[email protected]>
Co-authored-by: Kristoffer K <[email protected]>
Co-authored-by: Aviv Hadar <[email protected]>
Co-authored-by: Tobias Büschel <[email protected]>
Co-authored-by: mad-jose <[email protected]>
Co-authored-by: mad-jose <[email protected]>
Co-authored-by: Andrew Hyndman <[email protected]>
Co-authored-by: Brody McKee <[email protected]>
Co-authored-by: James George <[email protected]>
Co-authored-by: Dion Woolley <[email protected]>
Co-authored-by: Walker Clem <[email protected]>
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@sheepsteak @wombleton
Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)
00b9ff4
This was referenced Sep 15, 2021
Closed
Open
Open
This was referenced Apr 12, 2022
Closed
Open
@davetapley davetapley mentioned this pull request Jul 21, 2022
Open
@davetapley
Copy link

@sheepsteak I presume your assumption was that ^3.2.1 should still be fully supported in CRA 4 (hence the ||)?

I ask because a couple of us are seeing ⬇️ unless we go from ^3.2.1 to ^4, but it's easy to miss during CRA 3 to 4 upgrade because npm doesn't warn about bad peer deps 🤔

@ljharb
Copy link

ljharb commented Jul 21, 2022

@davetapley npm 7+ definitely warns about bad peer deps, fwiw.

@davetapley
Copy link

@ljharb sorry, bad phrasing on my part: npm doesn't warn about bad peer deps because ^3.2.1 is still in the spec ⬇️
(even though #10852 (comment) suggests that it isn't fully supported)

create-react-app/packages/react-scripts/package.json

Lines 96 to 98 in 228528c

"peerDependencies": {
"typescript": "^3.2.1 || ^4"
},

@phoenixy1 phoenixy1 mentioned this pull request Nov 3, 2022
Merged
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023
@sheepsteak @abhiisheek
Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)
12dfd73
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@sheepsteak @abhiisheek
Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)
540d510
@hzhz hzhz mentioned this pull request Jun 23, 2023
Open
@sirinartk sirinartk mentioned this pull request Jun 30, 2023
Open
@lili2311 lili2311 mentioned this pull request Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
4.0.2
9 participants
@sheepsteak @neolivz @pd8 @rati-dzidziguri @davetapley @ljharb @ianschmitz @iansu @facebook-github-bot