use generation_node_name on the GeneratorRun #2003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
mgarrard
force-pushed
the
export-D51432075
branch
from
bebe368
to
948a859
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
mgarrard
force-pushed
the
export-D51432075
branch
from
948a859
to
65b220b
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
mgarrard
force-pushed
the
export-D51432075
branch
from
65b220b
to
3965682
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
mgarrard
force-pushed
the
export-D51432075
branch
from
3965682
to
7073359
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
added 5 commits
November 28, 2023 12:00
…ethod on GenerationNode (facebook#2018) Summary: This diff does the following: Replaces the `get_generator_run_limit()` method on GenerationStep with `generator_run_limit` on GenerationNode. The new method relies on transition criterion to determine the number of generator runs, and only checks criterion that are trial based. I actually think this may not need to be expanded because the trial based criterion seem the most related to new generator run creation, but it could be expanded easily in the future if a usecase requires doing so. upcoming: (0) Finish removing GenerationStep methods in (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51169425
…ategy (facebook#2002) Summary: This diff removes the last uses of num_remaining_trials_until_max_parallelism(), num_trials, num_can_complete, and enforce_num_trials from the GenerationStrategy file. This can be done bc we can compute all the necessary info on GenerationNode now. And, since we want GenerationStrategy to accept GenerationNodes and GenerationSteps we cannot have any leftover calls from the GenerationStep level. Reviewed By: lena-kashtelyan Differential Revision: D51172395
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
mgarrard
force-pushed
the
export-D51432075
branch
from
7073359
to
3cf5425
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51432075 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index Differential Revision: D51432075
|
This pull request has been merged in b56610f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Replace the use of generation_step_index with generation_node_name because GenerationStrategy should no longer access index
Differential Revision: D51432075