Remove _check_previous_required_observation method #1999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51420534 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
force-pushed
the
export-D51420534
branch
from
3e30ab1
to
a11d8ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51420534 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 94.50% 94.47% -0.04%
==========================================
Files 460 460
Lines 44333 44334 +1
==========================================
- Hits 41898 41883 -15
- Misses 2435 2451 +16 ☔ View full report in Codecov by Sentry. |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
force-pushed
the
export-D51420534
branch
from
a11d8ee
to
e4b694f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51420534 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
added 2 commits
November 28, 2023 13:49
…ategy (facebook#2002) Summary: This diff removes the last uses of num_remaining_trials_until_max_parallelism(), num_trials, num_can_complete, and enforce_num_trials from the GenerationStrategy file. This can be done bc we can compute all the necessary info on GenerationNode now. And, since we want GenerationStrategy to accept GenerationNodes and GenerationSteps we cannot have any leftover calls from the GenerationStep level. Reviewed By: lena-kashtelyan Differential Revision: D51172395
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant. Reviewed By: lena-kashtelyan Differential Revision: D51420534
mgarrard
force-pushed
the
export-D51420534
branch
from
e4b694f
to
69fa2f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51420534 |
|
This pull request has been merged in 14a5615. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This method is redundant and checks for a state that we should never reach. In the process of updating to GenerationNode based GS, maintaining this method would entail keeping track of previous nodes. The tech debt of doing so outweighs the potential reward of keeping the function. Also I think since use_update has been deprecated this function is also less relevant.
Differential Revision: D51420534