Replace self._curr.model with self._curr.fitted_model #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51431892 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 28, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
force-pushed
the
export-D51431892
branch
from
e2d9d27
to
a2e3664
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51431892 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 460 460
Lines 44335 44341 +6
=======================================
+ Hits 41885 41891 +6
Misses 2450 2450 ☔ View full report in Codecov by Sentry. |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
force-pushed
the
export-D51431892
branch
from
a2e3664
to
fc7dca6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51431892 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 29, 2023
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model Reviewed By: lena-kashtelyan Differential Revision: D51431892
mgarrard
force-pushed
the
export-D51431892
branch
from
fc7dca6
to
6459a68
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51431892 |
|
This pull request has been merged in 918c9c2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We want to use the GenerationNode equivalent of model which is fitted_model instead of the GenerationStep field model
Differential Revision: D51431892