chore(crd-generator): Add approval tests for crd-generator

[baloo42]

Description

Add approval tests for crd-generator

Fixes #5850

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report

[baloo42]

@manusa @shawkins @andreaTP: I need some initial feedback here:

1. Keep or remove the old tests (atm marked as deprecated)?
2. Structure ok?
   • Keep and reuse the examples package (which are also used by other unit tests)
   • Approval files next to test source files? (instead of somewhere in resources)
3. Other thoughts?

I would suggest to create such a test for each of the existing examples.

If you know some missing edge cases, please let me know ;)

[manusa]

@manusa @shawkins @andreaTP: I need some initial feedback here:

1. Keep or remove the old tests (atm marked as deprecated)?

If the approval tests make those redundant and no production code is being touched, then remove them.

2. Structure ok?
   
   * Keep and reuse the examples package (which are also used by other unit tests)

Please, create specific test samples so we can keep a narrowed scope and purpose for the files.

   * Approval files next to test source files? (instead of somewhere in resources)

Whatever, we're doing at the moment in other modules (keep consistent).

If you know some missing edge cases, please let me know ;)

Yes, it would be good to have a thorough set of tests to ensure nothing breaks during upcoming refactors. I'm not a user of the crd-generator, but I encourage anyone else using it to ensure their use cases are being covered.

[manusa]

Is this PR affected by the changes introduced in #5954?

[baloo42]

Is this PR affected by the changes introduced in #5954?

I think yes. I'm rebasing and testing it atm.

[manusa]

OK, I'll probably add some changes on top and send you a PR

[manusa]

@baloo42 I've added some changes on top of your branch, please take a look and merge if you think it's OK:
baloo42#6

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[manusa]

LGTM, thx!