Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDGenerator: Replace assertions with ApprovalTests #5850

Closed
baloo42 opened this issue Apr 1, 2024 · 0 comments · Fixed by #5943
Closed

CRDGenerator: Replace assertions with ApprovalTests #5850

baloo42 opened this issue Apr 1, 2024 · 0 comments · Fixed by #5943
Assignees
@baloo42
Labels
component/crd-generator Related to the CRD generator technical-debt
Milestone
6.13.0

Comments

@baloo42
Copy link
Contributor

baloo42 commented Apr 1, 2024

Is your task related to a problem? Please describe

At the moment we have implemented some tests with self-developed assertions.

Describe the solution you'd like

Those tests can be replaced by ApprovalTests.

This test approach is also used for the Java-Generator and requires less self developed code.

Describe alternatives you've considered

No response

Additional context

No response
@baloo42 baloo42 mentioned this issue Apr 1, 2024
Merged
11 tasks
@manusa manusa added component/crd-generator Related to the CRD generator technical-debt labels Apr 15, 2024
@baloo42 baloo42 mentioned this issue Apr 15, 2024
Closed
11 tasks
baloo42 added a commit to baloo42/kubernetes-client that referenced this issue Apr 23, 2024
@baloo42
chore(crd-generator): Add approval tests for crd-generator
689fb11 
Fixes fabric8io#5850
@baloo42 baloo42 mentioned this issue Apr 23, 2024
Merged
8 tasks
baloo42 added a commit to baloo42/kubernetes-client that referenced this issue Apr 23, 2024
@baloo42
chore(crd-generator): Add approval tests for crd-generator
01dafb2 
Fixes fabric8io#5850
baloo42 added a commit to baloo42/kubernetes-client that referenced this issue Apr 24, 2024
@baloo42
chore(crd-generator): Add approval tests for crd-generator
35d7375 
Fixes fabric8io#5850
@manusa manusa added this to the 6.13.0 milestone Apr 27, 2024 — with automated-tasks
@baloo42 baloo42 mentioned this issue May 3, 2024
Closed
4 tasks
This was referenced May 6, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baloo42 baloo42

Labels
component/crd-generator Related to the CRD generator technical-debt
Projects
None yet
Milestone
6.13.0
Development

Successfully merging a pull request may close this issue.

chore(crd-generator): Add approval tests for crd-generator baloo42/kubernetes-client
2 participants
@manusa @baloo42