Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crd-generator): Sort required properties to ensure deterministic output #5954

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(crd-generator): Sort required properties to ensure deterministic output #5954

merged 1 commit into from
Apr 25, 2024

Conversation

baloo42
Copy link
Contributor

@baloo42 baloo42 commented Apr 25, 2024 •
edited
Loading

Description

Sort required properties to ensure deterministic output

See also #5949

Fixes partially #5951

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@baloo42 baloo42 force-pushed the fix-crd-generator-required-order branch from ac2960d to 0b4b99c Compare April 25, 2024 11:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baloo42 baloo42 marked this pull request as ready for review April 25, 2024 12:14
shawkins
shawkins approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa added this to the 6.13.0 milestone Apr 25, 2024 — with automated-tasks
manusa
manusa approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 8a19f1f into fabric8io:main Apr 25, 2024
20 checks passed
@manusa manusa mentioned this pull request Apr 25, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@shawkins shawkins shawkins approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@baloo42 @manusa @shawkins @rohanKanojia