chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.1 #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
requested review from
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
oscerd
approved these changes
Dec 25, 2023
dependabot
bot
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
0c6f327 to
655396b
Compare
|
|
strange, Edit: I'm able to reproduce once I delete |
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
655396b to
453263c
Compare
rohanKanojia
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
453263c to
70162a1
Compare
manusa
reviewed
Feb 6, 2024
pom.xml
Outdated
Comment on lines
851
to
857
| <dependency> | ||
| <groupId>org.junit</groupId> | ||
| <artifactId>junit-bom</artifactId> | ||
| <version>${junit.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
I'm not really sure why it's working. I tried changing various things in Istio model pom and Makefile but none of them seem to fix the issue.
During model generation process, only during Istio model compilation maven-compiler-plugin throws these warnings:
[INFO] Artifact org.junit:junit-bom:pom:5.10.1 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, ver
ifying that is downloadable from [central (https://repo.maven.apache.org/maven2, default, releases), plexus.snapshots (https://oss.sonatype.org/content/repositories/plexus
-snapshots, default, snapshots), apache.snapshots (https://repository.apache.org/snapshots, default, snapshots)]
and fails with this error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (default-compile) on project istio-model-v1alpha3: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile failed: Plugin org.apache.maven.plugins:maven-compiler-plugin:3.12.1 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-compiler-plugin:jar:3.12.1 -> org.codehaus.plexus:plexus-compiler-api:jar:2.14.2: Failed to read artifact descriptor for org.codehaus.plexus:plexus-compiler-api:jar:2.14.2: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.junit:junit-bom:pom:5.10.1 has not been downloaded from it before.
Following the error message, I saw that Junit5 bom is added in plexus-compiler-api/pom.xml . When I added same bom in our pom.xml, it started working.
There was a problem hiding this comment.
We should try to align versions with plexus-compiler-api then, or try to figure out the dependency convergence issue.
rohanKanojia
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
70162a1 to
653c468
Compare
Merged
11 tasks
manusa
reviewed
Feb 7, 2024
rohanKanojia
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
653c468 to
b06803d
Compare
manusa
approved these changes
Feb 7, 2024
Bumps [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.11.0 to 3.12.1. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.11.0...maven-compiler-plugin-3.12.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
rohanKanojia
force-pushed
the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
from
b06803d to
b33dee3
Compare
|
manusa
deleted the
dependabot/maven/org.apache.maven.plugins-maven-compiler-plugin-3.12.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.apache.maven.plugins:maven-compiler-plugin from 3.11.0 to 3.12.1.
Release notes
Sourced from org.apache.maven.plugins:maven-compiler-plugin's releases.
Commits
736da68[maven-release-plugin] prepare release maven-compiler-plugin-3.12.1ef93f3d[MCOMPILER-568] Bump plexusCompilerVersion from 2.14.1 to 2.14.2 (#220)eb7840c[MCOMPILER-567] - Fail to compile if the "generated-sources/annotations" does...2a7a73b[maven-release-plugin] prepare for next development iterationc08b0fd[maven-release-plugin] prepare release maven-compiler-plugin-3.12.0a1c5b13[MCOMPILER-565] Allow project build by Maven 44855773Bump plexusCompilerVersion from 2.13.0 to 2.14.11d05342[MCOMPILER-562] Add property maven.compiler.outputDirectory to CompilerMojo (...ea74978[MCOMPILER-381] - Refactor incremental detection (#181)fd37f09[MCOMPILER-333] Cleanup generated source files (#214)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)