Skip to content

Commit

Permalink
fix (extensions/istio) : Remove offline flag from Istio Model generat…
Browse files Browse the repository at this point in the history
…or maven execution

Somehow Istio V1alpha3 model generation build seems to be failing
requiring junit-bom dependency due to maven-compiler-plugin bump

Omit `-o` flag from model generation maven command

Signed-off-by: Rohan Kumar <[email protected]>
  • Loading branch information
rohanKanojia committed Feb 7, 2024
1 parent 655396b commit b06803d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion extensions/istio/generator-v1alpha3/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ all: build

build: gobuild
pushd ../model-v1alpha3 && \
mvn -Pgenerate clean install -DskipTests -o && \
mvn -Pgenerate clean install -DskipTests && \
popd

gobuild:
Expand Down
2 changes: 1 addition & 1 deletion extensions/istio/generator-v1beta1/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ all: build

build: gobuild
pushd ../model-v1beta1 && \
mvn -Pgenerate clean install -DskipTests -o && \
mvn -Pgenerate clean install -DskipTests && \
popd

gobuild:
Expand Down
4 changes: 0 additions & 4 deletions extensions/istio/model-v1alpha3/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>

0 comments on commit b06803d

Please sign in to comment.