fix (extensions/istio) : Add Junit5 dependency to model-v1alpha3 pom

Somehow Istio V1alpha3 model generation build seems to be failing requiring junit-bom dependency due to maven-compiler-plugin bump Signed-off-by: Rohan Kumar <[email protected]>
fabric8io · Feb 6, 2024 · 653c468 · 653c468
1 parent 655396b
commit 653c468
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/extensions/istio/generator-v1alpha3/Makefile b/extensions/istio/generator-v1alpha3/Makefile
@@ -20,7 +20,7 @@ all: build
 
 build: gobuild
 	pushd ../model-v1alpha3 && \
-	mvn -Pgenerate clean install -DskipTests -o && \
+	mvn -Pgenerate clean install -DskipTests && \
   popd
 
 gobuild:

diff --git a/extensions/istio/generator-v1beta1/Makefile b/extensions/istio/generator-v1beta1/Makefile
@@ -20,7 +20,7 @@ all: build
 
 build: gobuild
 	pushd ../model-v1beta1 && \
-	mvn -Pgenerate clean install -DskipTests -o && \
+	mvn -Pgenerate clean install -DskipTests && \
   popd
 
 gobuild:

diff --git a/extensions/istio/model-v1alpha3/pom.xml b/extensions/istio/model-v1alpha3/pom.xml
@@ -62,6 +62,11 @@
       <groupId>org.projectlombok</groupId>
       <artifactId>lombok</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-engine</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <profiles>
@@ -134,10 +139,6 @@
           </execution>
         </executions>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-release-plugin</artifactId>
-      </plugin>
     </plugins>
   </build>
 </project>