Create test to ensure HttpLoggingInterceptor doesn't consume bytes #5251
Comments
|
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Oct 19, 2023
…ptor to not consume response bytes (fabric8io#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert fabric8io#5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
I can reproduce the original issue using a unit test in AbstractHttpLoggingInterceptorTest, by test do you mean a unit test or an E2E test (in kubernetes-itests)? |
11 tasks
|
A black-boxed unit test that ensures the behavior (i.e. avoid mocking and verify calls to things like |
rohanKanojia
added a commit
to rohanKanojia/kubernetes-client
that referenced
this issue
Oct 19, 2023
…ptor to not consume response bytes (fabric8io#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert fabric8io#5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
|
I see only |
manusa
pushed a commit
that referenced
this issue
Nov 9, 2023
…ptor to not consume response bytes (#5251) Add a unit test in AbstractHttpLoggingInterceptor to verify response bytes are not consumed after they've been processed by HttpLoggingInterceptor. I've verified that test fails when I revert #5250 in httpclient-okhttp and httpclient-vertx modules Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Relates to #5250
In #5146 we removed by mistake the
copyinstruction for the consumedByteBuffer.This has basically reintroduced the problems (eclipse-jkube/jkube#2000, eclipse-jkube/jkube#1950) that were originally addressed by our HttpLoggingInterceptor feature.
We need to add a specific test to ensure that this is not a problem again.
The text was updated successfully, but these errors were encountered: